From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74AB64241A; Thu, 19 Jan 2023 16:07:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 180CF40223; Thu, 19 Jan 2023 16:07:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D2E05400D5 for ; Thu, 19 Jan 2023 16:07:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674140846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OKRttLy9ghQvZDJvMYMTfKFg5bBm/Wv3eNr59xPBWCY=; b=VDurDgES+l9a+JhjZMiHg4e8dqnnTyFDRoH2v4g8lnB+u4p/mlDOyc6nTCv5p9f7zINgp/ nuVhVhuFe4mDYrey5f95FRAnq2kBeXb8dXh6vK8f7PRw3vZ9DEam8+lxempNTIIij918fv m35MiLKZWYmTxeH8OrGrqE/mhDG9w+Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-481-9u7ds3QhO32Crw1VEI4ePA-1; Thu, 19 Jan 2023 10:07:23 -0500 X-MC-Unique: 9u7ds3QhO32Crw1VEI4ePA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B40A5857A89; Thu, 19 Jan 2023 15:07:22 +0000 (UTC) Received: from ringo.home (unknown [10.39.208.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C98840C2064; Thu, 19 Jan 2023 15:07:21 +0000 (UTC) From: Robin Jarry To: dev@dpdk.org Cc: Tyler Retzlaff , Kevin Laatz , Robin Jarry Subject: [PATCH v6 0/5] lcore telemetry improvements Date: Thu, 19 Jan 2023 16:06:51 +0100 Message-Id: <20230119150656.418404-1-rjarry@redhat.com> In-Reply-To: <20221123102612.1688865-1-rjarry@redhat.com> References: <20221123102612.1688865-1-rjarry@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which leaves the cpu cycles accounting completely up to the application. For reference, I have implemented a draft patch in OvS to use rte_lcore_register_usage_cb() and report the already available busy cycles information. https://github.com/rjarry/ovs/commit/643e672fe388e348ea7ccbbda6f5a87a066fd919 Changes since v5: - Added/rephrased some inline comments to address reviews. - Added a new commit that adds the /eal/lcore/usage endpoint as suggested by Kevin and Morten. Changes since v4: - rte_lcore_usage_cb now takes a pointer to a rte_lcore_usage structure. I chose not to include any API version tracking mechanism since the unsupported/unused fields can simply be left to zero. This is only telemetry after all. Changes since v3: - Changed nomenclature from CPU cycles to TSC cycles in the docstring of rte_lcore_usage_cb. Changes since v2: - Fixed typos in docstrings. - Used if (xxx != NULL) instead of if (xxx) test convention. - Guarded against an unlikely race if rte_lcore_dump() is called by a thread while another one calls rte_lcore_register_usage_cb(NULL). - s/utilization/usage/ - Fixed build on Windows. Changes since v1: - The cpuset field in telemetry is now a JSON list of CPU ids. - Applications must now report their raw CPU cycles counts. The busyness ratio and rate of change is left to external monitoring tools. - Renamed show lcores -> dump_lcores in testpmd. Robin Jarry (5): eal: add lcore info in telemetry eal: allow applications to report their cpu usage testpmd: add dump_lcores command testpmd: report lcore usage telemetry: add /eal/lcore/usage endpoint app/test-pmd/5tswap.c | 5 +- app/test-pmd/cmdline.c | 3 + app/test-pmd/csumonly.c | 6 +- app/test-pmd/flowgen.c | 2 +- app/test-pmd/icmpecho.c | 6 +- app/test-pmd/iofwd.c | 5 +- app/test-pmd/macfwd.c | 5 +- app/test-pmd/macswap.c | 5 +- app/test-pmd/noisy_vnf.c | 4 + app/test-pmd/rxonly.c | 5 +- app/test-pmd/shared_rxq_fwd.c | 5 +- app/test-pmd/testpmd.c | 39 +++++- app/test-pmd/testpmd.h | 14 +- app/test-pmd/txonly.c | 7 +- lib/eal/common/eal_common_lcore.c | 205 +++++++++++++++++++++++++++++- lib/eal/include/rte_lcore.h | 35 +++++ lib/eal/version.map | 1 + 17 files changed, 322 insertions(+), 30 deletions(-) -- 2.39.0