From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 13FBA42420;
	Thu, 19 Jan 2023 21:39:26 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A9EB140223;
	Thu, 19 Jan 2023 21:39:25 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 95208400D5
 for <dev@dpdk.org>; Thu, 19 Jan 2023 21:39:24 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id D242F20E09FA; Thu, 19 Jan 2023 12:39:23 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D242F20E09FA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1674160763;
 bh=rwVmqCPQJ+aEocleyLwT75PqQraCaz2Q0ywT2coobNo=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=aVJ8UhWQRrQeAZdJ6CrvhC4msOpni2Mn1pvTJRW/3aBsckh2JES0UIZ44VstHVU1s
 5yqrwS+OHogr15hQmrtCF/Ufe78f8glMXR56IetECTI+wkt1W7GBKqYeqCy/dFiKhf
 hemHNtWPoTm2bsbGshQATv01jjWaYt9Pk0jCVLKI=
Date: Thu, 19 Jan 2023 12:39:23 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org,
 maxime.coquelin@redhat.com, chenbo.xia@intel.com,
 jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com,
 Anatoly Burakov <anatoly.burakov@intel.com>,
 Mattias =?iso-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>,
 David Christensen <drc@linux.vnet.ibm.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock
Message-ID: <20230119203923.GA32536@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20220328121758.26632-1-david.marchand@redhat.com>
 <20230119184620.3195267-1-david.marchand@redhat.com>
 <20230119184620.3195267-2-david.marchand@redhat.com>
 <20230119114202.27f7da80@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230119114202.27f7da80@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Jan 19, 2023 at 11:42:02AM -0800, Stephen Hemminger wrote:
> On Thu, 19 Jan 2023 19:46:12 +0100
> David Marchand <david.marchand@redhat.com> wrote:
> 
> > +#ifndef __DOXYGEN__
> > +	__rte_exclusive_lock_function(&seqlock->lock)
> > +#endif
> >  {
> 
> Would be cleaner any required ifdefs was in rte_lock_annotations
> rather than sprinkling the code

we briefly touched on abstracting annotations in another thread. it
would be favorable if annotations were stashed behind macros that could
be expanded for more than just clang/internal/under doxygen to make
available opportunities to use other annotation dialects that may be
compatible.

no change requested, just thoughts for discussion.