From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 468DC4242A; Fri, 20 Jan 2023 04:32:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13F1742DB6; Fri, 20 Jan 2023 04:32:02 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 201F042DA0 for ; Fri, 20 Jan 2023 04:31:58 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NylPg36TBzJsB2; Fri, 20 Jan 2023 11:30:31 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 20 Jan 2023 11:31:51 +0800 From: Chengwen Feng To: , , CC: , , , Subject: [PATCH v3 3/5] ethdev: add newline to telemetry log string Date: Fri, 20 Jan 2023 03:25:34 +0000 Message-ID: <20230120032536.33595-4-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230120032536.33595-1-fengchengwen@huawei.com> References: <20221219090723.29356-1-fengchengwen@huawei.com> <20230120032536.33595-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The telemetry related code may invoke RTE_ETHDEV_LOG to display information, the newline character is not added automatically to the RTE_ETHDEV_LOG, therefore, the newline character must be explicitly added to the log string. Fixes: 5514319e7b43 ("telemetry: fix passing full params string to command") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 5d5e18db1e..9eeae61024 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -5880,7 +5880,7 @@ eth_dev_handle_port_xstats(const char *cmd __rte_unused, port_id = strtoul(params, &end_param, 0); if (*end_param != '\0') RTE_ETHDEV_LOG(NOTICE, - "Extra parameters passed to ethdev telemetry command, ignoring"); + "Extra parameters passed to ethdev telemetry command, ignoring\n"); if (!rte_eth_dev_is_valid_port(port_id)) return -1; @@ -5931,7 +5931,7 @@ eth_dev_handle_port_dump_priv(const char *cmd __rte_unused, port_id = strtoul(params, &end_param, 0); if (*end_param != '\0') RTE_ETHDEV_LOG(NOTICE, - "Extra parameters passed to ethdev telemetry command, ignoring"); + "Extra parameters passed to ethdev telemetry command, ignoring\n"); if (!rte_eth_dev_is_valid_port(port_id)) return -EINVAL; @@ -5973,7 +5973,7 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused, port_id = strtoul(params, &end_param, 0); if (*end_param != '\0') RTE_ETHDEV_LOG(NOTICE, - "Extra parameters passed to ethdev telemetry command, ignoring"); + "Extra parameters passed to ethdev telemetry command, ignoring\n"); if (!rte_eth_dev_is_valid_port(port_id)) return -1; @@ -6011,7 +6011,7 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, port_id = strtoul(params, &end_param, 0); if (*end_param != '\0') RTE_ETHDEV_LOG(NOTICE, - "Extra parameters passed to ethdev telemetry command, ignoring"); + "Extra parameters passed to ethdev telemetry command, ignoring\n"); if (!rte_eth_dev_is_valid_port(port_id)) return -EINVAL; -- 2.17.1