From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6886E4242A; Fri, 20 Jan 2023 05:42:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BD0642DBE; Fri, 20 Jan 2023 05:41:58 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mails.dpdk.org (Postfix) with ESMTP id A961C42D65 for ; Fri, 20 Jan 2023 05:41:53 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37F8B61E06; Fri, 20 Jan 2023 04:41:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACC78C433EF; Fri, 20 Jan 2023 04:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674189713; bh=OA9aKvIimBSPp+xtTJJVhYWAQ4KuSadN9gXKHvpeV1w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PyI7NGUpdhBFRF5bud7SmadwEs70zI1TwHTO0KBrbBAP7kk94al8RZyih1idr/S4U I/PqdayNYL2WwzEZ230I22XcIfjfQbQ4XzyojtweJbKNl1s3/Q8vWcRqqiDfaDnYVF BUrXRfWi6FLtO6sPUnUJMpBfID3OlXVONgoSNxR19nuF6FlibXnIT+p5WxB/twzLmk xxdziznSW/RBCuKJwkkbO6veuyXKpOSBSzikfKWuRag/uUK/nomLeJpW6cySAESZaM W62OPF/N9YALF8Ccq3Puz1VECxJ307s9HM/vvvNFNsYqtDdHdpQewBJxuEsA+75FPy zCASTAGYEafbw== From: okaya@kernel.org To: Anatoly Burakov Cc: dev@dpdk.org, Sinan Kaya Subject: [PATCH v3 05/10] malloc: check result of rte_mem_virt2memseg_list Date: Thu, 19 Jan 2023 23:41:35 -0500 Message-Id: <20230120044140.95975-6-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230120044140.95975-1-okaya@kernel.org> References: <20230120044140.95975-1-okaya@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sinan Kaya In alloc_pages_on_heap result of call to rte_mem_virt2memseg_list is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index 503e551bf9..3f41430e42 100644 --- a/lib/eal/common/malloc_heap.c +++ b/lib/eal/common/malloc_heap.c @@ -323,6 +323,8 @@ alloc_pages_on_heap(struct malloc_heap *heap, uint64_t pg_sz, size_t elt_size, map_addr = ms[0]->addr; msl = rte_mem_virt2memseg_list(map_addr); + if (msl == NULL) + return NULL; /* check if we wanted contiguous memory but didn't get it */ if (contig && !eal_memalloc_is_contig(msl, map_addr, alloc_sz)) { -- 2.25.1