From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86F0742401; Wed, 25 Jan 2023 17:16:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3891A42D8C; Wed, 25 Jan 2023 17:16:09 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B065542D47 for ; Wed, 25 Jan 2023 17:16:07 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id ED48320E61AB; Wed, 25 Jan 2023 08:16:06 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ED48320E61AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1674663366; bh=DOFUS4vjyslMYg23oBe7tYoB1nsceqSCcLLtDLsO/0w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a5z2IrpAaK1r0cp8n5L9cHspDg/vQAszvLQR+xEd3rsAUL68ogsbqsWge1AM0Uqty ujK7FdWhrWJUSIFm6YUFdrZlNzxKz8gVFb71KevLphIqJcnnCZ34IVzMfwoUxc8vXj gPpgkJX/rs+EsdhcMTzYKZp1epxNMz7Lmh1gYwfc= Date: Wed, 25 Jan 2023 08:16:06 -0800 From: Tyler Retzlaff To: Thomas Monjalon Cc: Tomasz Duszynski , dev@dpdk.org, jerinj@marvell.com, stephen@networkplumber.org, chenbo.xia@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com Subject: Re: [PATCH 1/2] lib: add helper to read strings from sysfs files Message-ID: <20230125161606.GA7184@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230110234642.1188550-1-tduszynski@marvell.com> <20230125103311.1249988-1-tduszynski@marvell.com> <20230125103311.1249988-2-tduszynski@marvell.com> <73101748.RN2Pgac3cq@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73101748.RN2Pgac3cq@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 25, 2023 at 11:39:30AM +0100, Thomas Monjalon wrote: > 25/01/2023 11:33, Tomasz Duszynski: > > Reading strings from sysfs files is a re-occurring pattern > > hence add helper for doing that. > > In general it would be to nice to clean sysfs parsing in libs and drivers, > so they all use some functions from EAL. maybe there should be a general utility library for dealing with sysfs separate from the core EAL that drivers / platform specific libs can share?