From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9002242478;
	Wed, 25 Jan 2023 23:36:42 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 40E2640A7A;
	Wed, 25 Jan 2023 23:36:42 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id F2930400D7
 for <dev@dpdk.org>; Wed, 25 Jan 2023 23:36:40 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 3B55C20E61CE; Wed, 25 Jan 2023 14:36:40 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3B55C20E61CE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1674686200;
 bh=bz61BaF64J2b+NfeZ+48kaScVgOevbtbUIML7VbPCPc=;
 h=Date:From:To:Subject:From;
 b=pS1norja9Q79ckC4RKvDdM5ixlM64rSFgoStXFv6Zxq7f8bpqjTz4hpuMkcNz1/sl
 go7mfIbAPOcIZTGPgrKYwcEXSMtAe/4cRb0NYJkb7zOMfj+DsrOgw7RLTqYA0//8R+
 SWEjd1u6UHqIWXQaTdt/WNWgZ1iRHlRgRHfA1kPg=
Date: Wed, 25 Jan 2023 14:36:40 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Subject: deprecation notice process / clarification
Message-ID: <20230125223640.GA28039@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

hi,

i'm looking for some guidance when cleaning up / removing the remaining
shim functions for pthread in windows and i'm not sure how our
deprecation notice / policies apply.

windows has been providing lib/eal/windows/include/pthread.h shim that
allowed applications to use e.g. pthread_xxx functions on windows.

these shim functions were all being provided as inline functions and
were not part of the EAL api but on windows they were implicitly part of
the api surface exposed (to windows only). on posix platforms applications
did not rely on EAL for pthread abi or api (obviously).

recently we introduced a set of platform agnostic thread api in the EAL.
the functions were marked __rte_experimental as a part of new API
addition policy.

what's the most appropriate way to remove the pthread_xxx shim inline
functions from lib/eal/windows/include/pthread.h? do we have to wait the
full deprecation notice period which can't be started until we make the
new functions stable? also keeping in mind we can't actually mark inline
functions __rte_deprecated.

is this a special case where we can just rip them out and break
compilation?

input is appreciated, particularly from any consumers of the windows
port who might be unhappy.

thanks