From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 98CAE42495;
	Thu, 26 Jan 2023 18:29:00 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2F32840143;
	Thu, 26 Jan 2023 18:29:00 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id DB73E400D7
 for <dev@dpdk.org>; Thu, 26 Jan 2023 18:28:58 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 2D1BC20DFE6C; Thu, 26 Jan 2023 09:28:58 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2D1BC20DFE6C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1674754138;
 bh=GACmkqua9m+BL9DKVlsfcgAxptgZae/Ud3y+LADDpP8=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=RqLU7sHB2J18wa5gpl85b130GIPOUA9nmfowESOsQCfdlgPhmJE4sRtzaxocN45MN
 JpQtrAxJUelFY3Mg2WeD+6o1iFcDbKG7UJh/1bJ/gN+zkJ11GIsO/TSUTp7geEiuj3
 EeqLteS4vjvdkwz287qmRYIs2ugDjIh5YrE33jsA=
Date: Thu, 26 Jan 2023 09:28:58 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 3/3] build: limit what is built when using MSVC compiler
Message-ID: <20230126172858.GC13258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com>
 <1674674707-3094-4-git-send-email-roretzla@linux.microsoft.com>
 <Y9Jfog5UqZabyp8h@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y9Jfog5UqZabyp8h@bricha3-MOBL.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Jan 26, 2023 at 11:10:26AM +0000, Bruce Richardson wrote:
> On Wed, Jan 25, 2023 at 11:25:07AM -0800, Tyler Retzlaff wrote:
> > Build only kvargs and telemetry when is_ms_compiler.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> >  lib/meson.build |  7 +++++++
> >  meson.build     | 13 +++++++++----
> >  2 files changed, 16 insertions(+), 4 deletions(-)
> > 
> > diff --git a/lib/meson.build b/lib/meson.build
> > index 82e4666..8e99e21 100644
> <snip>
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -76,11 +76,16 @@ subdir('config')
> >  
> >  # build libs and drivers
> >  subdir('lib')
> > -subdir('drivers')
> >  
> > -# build binaries and installable tools
> > -subdir('usertools')
> > -subdir('app')
> > +if is_ms_compiler
> > +    enabled_apps = []
> > +else
> > +    subdir('drivers')
> > +
> > +    # build binaries and installable tools
> > +    subdir('usertools')
> > +    subdir('app')
> > +endif
> >  
> 
> My own preference here would be to put the checks inside the
> subdirectories, and try and keep the top-level meson.build file clean.
> Would that work ok?

no objection. one clarification request though.

do you mean just for drivers, usertools and app or do you mean for every
lib/<foo> as well?

i'll send up a v2 once i get confirmation.

> 
> >  # build docs
> >  subdir('doc')
> > -- 
> > 1.8.3.1
> >