From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B0FE042495;
	Thu, 26 Jan 2023 18:36:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A33C840695;
	Thu, 26 Jan 2023 18:36:34 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id EEC3840143
 for <dev@dpdk.org>; Thu, 26 Jan 2023 18:36:32 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 1BA2E20E6590; Thu, 26 Jan 2023 09:36:32 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1BA2E20E6590
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1674754592;
 bh=7w5TAGj/s5qe49YshqDHcfMz/QqeUb/Iz1SQyrJ/bp0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=WiEk6g4QL58n6YmY8KcC+biV9EsYqxhurhEuK6oB35L4PsxZ7NhMEar4lobozYQHC
 Cu+Dh6i/yX57qyVfUFyGxdk8Iqx+EG0+9lf/Ab0rOk8urRfz0Hgm3HNhhc0KknVzx/
 1h18guQ3rGaUeawec1oAbOfOQ+hpGOquVWoSzFNA=
Date: Thu, 26 Jan 2023 09:36:32 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 3/3] build: limit what is built when using MSVC compiler
Message-ID: <20230126173632.GE13258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com>
 <1674674707-3094-4-git-send-email-roretzla@linux.microsoft.com>
 <Y9Jfog5UqZabyp8h@bricha3-MOBL.ger.corp.intel.com>
 <20230126172858.GC13258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <Y9K5upo1Xd0YDbAv@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y9K5upo1Xd0YDbAv@bricha3-MOBL.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Jan 26, 2023 at 05:34:50PM +0000, Bruce Richardson wrote:
> On Thu, Jan 26, 2023 at 09:28:58AM -0800, Tyler Retzlaff wrote:
> > On Thu, Jan 26, 2023 at 11:10:26AM +0000, Bruce Richardson wrote:
> > > On Wed, Jan 25, 2023 at 11:25:07AM -0800, Tyler Retzlaff wrote:
> > > > Build only kvargs and telemetry when is_ms_compiler.
> > > > 
> > > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > > ---
> > > >  lib/meson.build |  7 +++++++
> > > >  meson.build     | 13 +++++++++----
> > > >  2 files changed, 16 insertions(+), 4 deletions(-)
> > > > 
> > > > diff --git a/lib/meson.build b/lib/meson.build
> > > > index 82e4666..8e99e21 100644
> > > <snip>
> > > > --- a/meson.build
> > > > +++ b/meson.build
> > > > @@ -76,11 +76,16 @@ subdir('config')
> > > >  
> > > >  # build libs and drivers
> > > >  subdir('lib')
> > > > -subdir('drivers')
> > > >  
> > > > -# build binaries and installable tools
> > > > -subdir('usertools')
> > > > -subdir('app')
> > > > +if is_ms_compiler
> > > > +    enabled_apps = []
> > > > +else
> > > > +    subdir('drivers')
> > > > +
> > > > +    # build binaries and installable tools
> > > > +    subdir('usertools')
> > > > +    subdir('app')
> > > > +endif
> > > >  
> > > 
> > > My own preference here would be to put the checks inside the
> > > subdirectories, and try and keep the top-level meson.build file clean.
> > > Would that work ok?
> > 
> > no objection. one clarification request though.
> > 
> > do you mean just for drivers, usertools and app or do you mean for every
> > lib/<foo> as well?
> > 
> 
> No, not for every lib, there are far too many of them. What you have done
> there makes most sense. But for drivers/apps/usertools, putting the check
> in the subfolder help keep the top-level file cleaner.

thanks, i'll fire up v2 sometime today.