From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10E43424AA; Sat, 28 Jan 2023 18:17:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E9ED40143; Sat, 28 Jan 2023 18:17:49 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 3D4724003F for ; Sat, 28 Jan 2023 18:17:48 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id t12-20020a17090aae0c00b00229f4cff534so10221513pjq.1 for ; Sat, 28 Jan 2023 09:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AHPUT41mp4nXfFKaJYcsAwuthexjXXriGMV6culC4kg=; b=8RBzmFV1asiFcp5OOpZvnI+YxBSa/0EeAFd9TOlfN1WwrjjOW2XPm1ZbOVG3l2awBj QRO3DB3XXkEQdIaX7Xvl2pD4nZR33ryk0TaMjXgKOK4A1nUPQts8aRZ/0TK1YIBVk/y7 4e2iTLdHVVHz0PZ05WkpjJY/KqznQY+T5nKkL8JpPzB0p9Du7+NQdHz5WtXggW+o9lZF JEmeykx9x8jkaQ8OsiThW6skCSmUkq/yKI6s8UOveMW3iJz1/Z8LanX/Fhk/gWWWuEHC CSjOsC90OpsEfARXSuHH6m1rytWu0f1lZUY9bQej9vCL3PE1yggHK7zyXUJNLgWIagcg fHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AHPUT41mp4nXfFKaJYcsAwuthexjXXriGMV6culC4kg=; b=kxewOdzqiHOl/GV43brGex7jik98TAJ/6mZRDfD7wuHXhMDi7JBNWscGPuXVl3CLzP KvZ8v292Uxbna+XLpqSGhWOetMQMzy1K9OBeRUp9k/ytWore6pmKwm0p9lHHmDMTHR9E uNt6IPSQireSkWtzA3NvYu7ogs8eSVxBgvCD00lxAxk8S5msJL0lbUbz39ljiUjCPdVW LTMGvKdGykZxIuWet3oWBBkrgxehjgapy/9apRt/h3RDz64kjeKbvW32Sl4P+zbkLeFv 5xR6g4jeC5CX2HPXLxaaJiiykA8QHJMV4XvQ99BSK7Y233Gi8FyVsCsbnOTFmbr1mqPK 0S5g== X-Gm-Message-State: AFqh2kqhmtl7e37DH7eQWa06IqFL/iZSImqDRHg09kpGTlxNPPs6swKP hbnuru768dTX8kQHPahGfxzh8w== X-Google-Smtp-Source: AMrXdXu6c6wb2Dl9svoIWu5w5WJWcbaNnAi9ALiS00Sxy4edZsQUO45AjDxuHPzB/GAf+NKa8UTVJg== X-Received: by 2002:a05:6a20:3d86:b0:b8:d032:6486 with SMTP id s6-20020a056a203d8600b000b8d0326486mr61372862pzi.16.1674926267086; Sat, 28 Jan 2023 09:17:47 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id v22-20020aa78516000000b00592a74b9b4dsm3171647pfn.141.2023.01.28.09.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Jan 2023 09:17:46 -0800 (PST) Date: Sat, 28 Jan 2023 09:17:45 -0800 From: Stephen Hemminger To: Mingjin Ye Cc: dev@dpdk.org, qiming.yang@intel.com, stable@dpdk.org, yidingx.zhou@intel.com, Qi Zhang Subject: Re: [PATCH v8] doc: add PMD known issue Message-ID: <20230128091745.6f56c9b4@hermes.local> In-Reply-To: <20230128060139.58516-1-mingjinx.ye@intel.com> References: <20221227090040.38394-1-mingjinx.ye@intel.com> <20230128060139.58516-1-mingjinx.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 28 Jan 2023 06:01:38 +0000 Mingjin Ye wrote: > Add a known issue: Rx path dynamic change is not supported for PMD. > > Fixes: de853a3bb151 ("net/ice: disable DDP package on Windows") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye > --- > doc/guides/nics/ice.rst | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst > index ce075e067c..115625523e 100644 > --- a/doc/guides/nics/ice.rst > +++ b/doc/guides/nics/ice.rst > @@ -395,3 +395,15 @@ file is used by both the kernel driver and the DPDK PMD. > > Windows support: The DDP package is not supported on Windows so, > loading of the package is disabled on Windows. > + > +ice: Rx path does not support dynamic change > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +The ice driver supports fast and offload rx path. When pmd is initialized, > +the fast rx path is selected by default. Even if offload is subsequently > +enabled through the API, which will not work because the past rx path is > +still used. > + > +The ice driver does not support to change the rx path after application > +is initialized. If HW offload is required, the ``--rx-offloads`` parameter > +should be used to choose the offload Rx path by default. Is this when the device is stopped, or running. Dynamic configuration of offload parameters is not safe on many devices. Usually the device driver requires the device not be started to change offloads. The driver should reject in the API things it does not support.