From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D32AA41B82;
	Mon, 30 Jan 2023 17:47:50 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7E84E40DF6;
	Mon, 30 Jan 2023 17:47:50 +0100 (CET)
Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com
 [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 7948440C35
 for <dev@dpdk.org>; Mon, 30 Jan 2023 17:47:49 +0100 (CET)
Received: by mail-pj1-f44.google.com with SMTP id 88so11605104pjo.3
 for <dev@dpdk.org>; Mon, 30 Jan 2023 08:47:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=U66LZYKklQZr0Z3Bw9iviFN32+eXCcD6iq0eF+l24Kg=;
 b=0o61pwq1ctIcXaS7Ma+E/odSL0Rc5hlSgHH/Sx6FL1JWi3td7vJZoqosYvNE1n/tz0
 +vpMrfBTFCFV5okMkJSpc3bPTtXV44UHSQSyLC+dJ963/qwCM7u2BZecCE1HVCoyfbBj
 pfjvQHMidXyFvMX7RP2sNsR+PpajNQf4DlzEK/AmTp+8E4+yqRD6YHPf9i4TYEFwL7+9
 DcgaUTPRYfYGb5a4rthQLmyeKNHs3WXrt2eXHkC5Elruf+03T4nUZSOdMwfUMCwomK6O
 quEE8zGEkMzh1mwPCd1dQ53flaYynLRHaI+XIXaIe3GDRgVfYqMi10MxOoo6DfjR22wT
 qkRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=U66LZYKklQZr0Z3Bw9iviFN32+eXCcD6iq0eF+l24Kg=;
 b=XkjR+BCokfp6VuG1ANf/wk8jJy+1zX+P92xzLgTAF/6CEZCclO3taf73giyyfrrbkh
 z7CL5WLpo3B5czVHGcbwvMy6IUMkRFNBRRAE/JK6/cPZ9UEz+MTUmKvKlGmxWJc7y4OU
 S/ZD+V4xIVu+2EP8xlKnjlWZ1ictwPFCp6bznz8LjK/LEyEtLMPHC/OHJ4Z/sV5F3Mbi
 kh+8bfHvvE7tMmHZ1DXp3xu2IUG4DV1mTlXVh8uZDNAEmOHAM/ziSqWlY1VlWwXkITis
 iImWDgmBu9xL/nVoscNJZjLdbeTosy9pdkoKbbb//aPfdGY1BOd4WyW3PRRAKrxNMmy+
 qaSw==
X-Gm-Message-State: AFqh2krD7Bum4cN0nUBxZrJvvh99ucK+Lt2msv/EktrHkkjitlNW5HSu
 fH1QnRlI+MBB9oj+wtlWEgw/dQ==
X-Google-Smtp-Source: AMrXdXuKrAz+IXxNFKDylIaffKQPTUCnwFJj7awUbvjonZmvVJwrqNRw+Ovng8LPygfGiGZZdezS8w==
X-Received: by 2002:a17:903:11c7:b0:194:a531:4b39 with SMTP id
 q7-20020a17090311c700b00194a5314b39mr66581264plh.67.1675097268327; 
 Mon, 30 Jan 2023 08:47:48 -0800 (PST)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
 by smtp.gmail.com with ESMTPSA id
 h6-20020a170902f7c600b001963232f49dsm1860071plw.233.2023.01.30.08.47.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 30 Jan 2023 08:47:48 -0800 (PST)
Date: Mon, 30 Jan 2023 08:47:46 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Rongwei Liu <rongweil@nvidia.com>
Cc: <matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,
 <thomas@monjalon.net>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
 <yuying.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>, "Andrew
 Rybchenko" <andrew.rybchenko@oktetlabs.ru>, Olivier Matz
 <olivier.matz@6wind.com>, <dev@dpdk.org>, <rasland@nvidia.com>
Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header
 definition
Message-ID: <20230130084746.101226e2@hermes.local>
In-Reply-To: <20230130035941.1495874-2-rongweil@nvidia.com>
References: <5da6632a-0976-dc1f-facb-f778c8aad8e6@oktetlabs.ru>
 <20230130035941.1495874-1-rongweil@nvidia.com>
 <20230130035941.1495874-2-rongweil@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, 30 Jan 2023 05:59:33 +0200
Rongwei Liu <rongweil@nvidia.com> wrote:

>  
> +/**
> + * IPv6 Routing Extension Header
> + */
> +struct rte_ipv6_routing_ext {
> +	uint8_t next_hdr;			/**< Protocol, next header. */
> +	uint8_t hdr_len;			/**< Header length. */
> +	uint8_t type;				/**< Extension header type. */
> +	uint8_t segments_left;			/**< Valid segments number. */
> +	__extension__
> +	union {
> +		rte_be32_t flags;
> +		struct {
> +			uint8_t last_entry;	/**< The last_entry field of SRH */
> +			uint8_t flag;		/**< Packet flag. */
> +			rte_be16_t tag;		/**< Packet tag. */
> +		};
> +	};
> +	__extension__
> +	rte_be32_t segments[0];			/**< Each hop IPv6 address. */

Use flex array rather than zero size.
Zero size arrays cause warnings with later compilers.