From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 622CC41BBF; Fri, 3 Feb 2023 18:45:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E07B842D2D; Fri, 3 Feb 2023 18:45:48 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id E0C5642D10 for ; Fri, 3 Feb 2023 18:45:47 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id o68so2955326pfg.9 for ; Fri, 03 Feb 2023 09:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=08jACoMkChimeK9xVNEx3IRlNlOXBnO960SARFqa/Xg=; b=EudOD82zqB0g9169v3wkzKDZCsH4PdqCWeLRmyhIvWUW0Mb6frY6THkzfBafUaYe/1 Wiqgo8ywn+hv9kvUOBuChfZETTchokNN742dkR64jvIDUFpRvPFxLcrysrQEIZdq0ZRz de9nZNPAyJY7ayNvlm6Qnij7A9s5MQS6nqDseBsTyF/k+2Ea65jnYOkzdw4zrPJRxXZE 2hVLnJqgOczxLmAyJl7zLaaUO9rhkfNTtMEhdnrK1112ULnb2kr1XgJDYBNVyacWwq9M 9AtwKla3Hg4XpoeFD8oJQ8wyJXa/RBSyeSQ9ECG7nyOAw3t+gIB5iqQZY7IPB49lqNND uRrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=08jACoMkChimeK9xVNEx3IRlNlOXBnO960SARFqa/Xg=; b=Oq24Ji3UV+NLVQmvj/IJENQCs/Iff+OolZ6B2G7Td8EEfWxfpar6q2eKd21WtqHDdX 1FasBbsASotH/lBeUEihQCFBXhqoBV7dTcnaHWWRiax8tkQyanfpc9gOVG4QNLCfabTH znQkjXDGHzEEDkZl0Fy8zneDu41dUiOyzGV2pqASxyDXysCPVAB2/DJGQJ3Bvsv6LKgj 5OLE1uZhXATMc+X0EBhQeW5wEbnUL0D1qHUrLFvRSgS84eWSlAeQf/fRQvSHD0prbiHj nGQgMToQtOAtVJchegLQXdjJxx+om+9HYdSolnRxKuSuXscaA7pgEr+PyWCnpgbprk6b 4+Ww== X-Gm-Message-State: AO0yUKXC/56xy4EodoZalFpwntzdF7dgW+IlzLkWljgI5mD2Dv7tlRyu QCB+TG9+w9gQfF7A3G81BV1PTg== X-Google-Smtp-Source: AK7set8dt1RNxZhb+eG5cLAFAEWxnArhO2YSDIT+bfMNELIyIeuAr4Na9/q2+sxEGWKIiq76Dz07bQ== X-Received: by 2002:a05:6a00:18a2:b0:572:6e9b:9f9e with SMTP id x34-20020a056a0018a200b005726e9b9f9emr13398523pfh.19.1675446347024; Fri, 03 Feb 2023 09:45:47 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id b23-20020aa78717000000b00585cb0efebbsm2131801pfo.175.2023.02.03.09.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 09:45:46 -0800 (PST) Date: Fri, 3 Feb 2023 09:45:45 -0800 From: Stephen Hemminger To: Mike Pattrick Cc: Maxime Coquelin , Chenbo Xia , dev@dpdk.org Subject: Re: [PATCH v2] vhost: exclude VM hugepages from coredumps Message-ID: <20230203094545.1e91f183@hermes.local> In-Reply-To: <20221206150509.772408-1-mkp@redhat.com> References: <20221206150509.772408-1-mkp@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 6 Dec 2022 10:05:09 -0500 Mike Pattrick wrote: > + > +static __rte_always_inline void > +mem_set_dump(__rte_unused void *ptr, __rte_unused size_t size, __rte_unused bool enable) > +{ > +#ifdef MADV_DONTDUMP > + if (madvise(ptr, size, enable ? MADV_DODUMP : MADV_DONTDUMP) == -1) { > + rte_log(RTE_LOG_INFO, vhost_config_log_level, > + "VHOST_CONFIG: could not set coredump preference (%s).\n", strerror(errno)); > + } > +#endif > +} Why is this inlined in vhost.h? Hardly a critical path function.