From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3689941BC0; Fri, 3 Feb 2023 21:26:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0B5140EDF; Fri, 3 Feb 2023 21:26:31 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 9F52E40ED4 for ; Fri, 3 Feb 2023 21:26:30 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id d2so2488185pjd.5 for ; Fri, 03 Feb 2023 12:26:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OwniIrfShJ6LMivq0UmPKdIFrRs70CBJUBqD5NDmhTQ=; b=CVesl1PQBtXO6QifYRCp9zWKKkC9yoP5rboqYa9i9RKGbz9v3OOWrS4ty4XZDnioEV 1WogXvBcPdjzSB6812m6Mx8nMuOJvTulkuYhfs8vAFBskZLQgOBL4rJe3f+XKhAAUPXK b8n6crw2yyWpsTMpedeOgfwN0LL04AiFoL6b1jWl76kish4bDDabOfGSUVWSCHypLwet 9WwEcZJ4t6qF57xPuxjAkTE6e9J9jGW2kvYDdUWdby7mkwIkfbD/rkACYXUVh87e6rEz R038zNHEyo/xfYvNJmlt2IowFEPea2fAlpWAmZ0T1LmjP8Ku1mvpAc0G+z2G04yzHXG4 xvlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OwniIrfShJ6LMivq0UmPKdIFrRs70CBJUBqD5NDmhTQ=; b=sZbF+PaazMBIwo5S2oAJsntk6nK+yU8CXENpHXKA0uvJYvZSvqVs9SFqQ72hro5LAw t4r5WcX0cBuY2wPMtAZBtnVz8FOAtNhD5M36tmXM5FUP5d9qiu6CCaurIhhOAMLuw0uC TKSlRb/mVRWNKrOLp0yikrNH4ZjurhzzL3lXGxbSFaYmTLB2mTn/JMNws4cGPW4hRc1m AqzueOi072lvF7n6yh9A6V0m2F40LLTM+LL2MWfMXsamhIbG284BnMNy5k/0KFfW8Tpd /OVZdGuQfSVIyAISPCuGHbH9aYg0lNJVdmARm7/oiUzzPcCr+BW60+3Mtt48MQYHWR3G q+uw== X-Gm-Message-State: AO0yUKXexRf37+l1My+4h/r2Yvh+b0SR/m8tT34UacfXwJdoNymsNFGY O1z+rFpWNGuU9C7SVnPfwYEc/Q== X-Google-Smtp-Source: AK7set8jKw3IjtfrPWWqnytMARN//rmus3XMUEN72+W8zifg+PLAEfSBJYsYbbfI7CvxkmX9cbEuBw== X-Received: by 2002:a05:6a20:3b89:b0:be:f077:9dc with SMTP id b9-20020a056a203b8900b000bef07709dcmr11657237pzh.19.1675455989247; Fri, 03 Feb 2023 12:26:29 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id i137-20020a636d8f000000b004b4d4de54absm1865218pgc.59.2023.02.03.12.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 12:26:29 -0800 (PST) Date: Fri, 3 Feb 2023 12:26:25 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: Shivah Shankar Shankar Narayan Rao , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Bruce Richardson , Srikanth Yalavarthi , "ferruh.yigit@xilinx.com" , "ajit.khaparde@broadcom.com" , "aboyer@pensando.io" , "andrew.rybchenko@oktetlabs.ru" , "beilei.xing@intel.com" , "chas3@att.com" , "chenbo.xia@intel.com" , "ciara.loftus@intel.com" , Devendra Singh Rawat , "ed.czeck@atomicrules.com" , "evgenys@amazon.com" , "grive@u256.net" , "g.singh@nxp.com" , "zhouguoyang@huawei.com" , "haiyue.wang@intel.com" , Harman Kalra , "heinrich.kuhn@corigine.com" , "hemant.agrawal@nxp.com" , "hyonkim@cisco.com" , "igorch@amazon.com" , Igor Russkikh , "jgrajcia@cisco.com" , "jasvinder.singh@intel.com" , "jianwang@trustnetic.com" , "jiawenwu@trustnetic.com" , "jingjing.wu@intel.com" , "johndale@cisco.com" , "john.miller@atomicrules.com" , "linville@tuxdriver.com" , "keith.wiles@intel.com" , Kiran Kumar Kokkilagadda , "oulijun@huawei.com" , Liron Himi , "longli@microsoft.com" , "mw@semihalf.com" , "spinler@cesnet.cz" , "matan@nvidia.com" , "matt.peters@windriver.com" , "maxime.coquelin@redhat.com" , "mk@semihalf.com" , "humin29@huawei.com" , Pradeep Kumar Nalla , Nithin Kumar Dabilpuram , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , Radha Chintakuntla , "rahul.lakkireddy@chelsio.com" , Rasesh Mody , "rosen.xu@intel.com" , "sachin.saxena@oss.nxp.com" , Satha Koteswara Rao Kottidi , Shahed Shaikh , "shaibran@amazon.com" , "shepard.siegel@atomicrules.com" , "asomalap@amd.com" , "somnath.kotur@broadcom.com" , "sthemmin@microsoft.com" , "steven.webster@windriver.com" , Sunil Kumar Kori , "mtetsuyah@gmail.com" , Veerasenareddy Burru , "viacheslavo@nvidia.com" , "xiao.w.wang@intel.com" , "cloud.wangxiaoyun@huawei.com" , "yisen.zhuang@huawei.com" , "yongwang@vmware.com" , "xuanziyang2@huawei.com" , Prasun Kapoor , Nadav Haklai , Satananda Burla , Narayana Prasad Raju Athreya , Akhil Goyal , "mdr@ashroe.eu" , "dmitry.kozliuk@gmail.com" , "anatoly.burakov@intel.com" , "cristian.dumitrescu@intel.com" , "honnappa.nagarahalli@arm.com" , "mattias.ronnblom@ericsson.com" , "ruifeng.wang@arm.com" , "drc@linux.vnet.ibm.com" , "konstantin.ananyev@intel.com" , "olivier.matz@6wind.com" , "jay.jayatheerthan@intel.com" , Ashwin Sekhar T K , Pavan Nikhilesh Bhagavatula , "eagostini@nvidia.com" , Derek Chickles , Parijat Shukla , Anup Prabhu , Prince Takkar , david.marchand@redhat.com Subject: Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library Message-ID: <20230203122625.513d4c0a@hermes.local> In-Reply-To: <8214941.NyiUUSuA9g@thomas> References: <20220803132839.2747858-2-jerinj@marvell.com> <12142603.O9o76ZdvQC@thomas> <20230203093354.5cff4558@hermes.local> <8214941.NyiUUSuA9g@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 03 Feb 2023 21:18:40 +0100 Thomas Monjalon wrote: > 03/02/2023 18:33, Stephen Hemminger: > > On Fri, 03 Feb 2023 09:42:45 +0100 > > Thomas Monjalon wrote: > > > > > 03/02/2023 01:25, Stephen Hemminger: > > > > On Wed, 1 Feb 2023 13:34:41 +0000 > > > > Shivah Shankar Shankar Narayan Rao wrote: > > > > > > > > > --- a/lib/eal/include/rte_log.h > > > > > +++ b/lib/eal/include/rte_log.h > > > > > @@ -48,6 +48,7 @@ extern "C" { > > > > > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > > > > > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > > > > > #define RTE_LOGTYPE_GSO 20 /**< Log related to GSO. */ > > > > > +#define RTE_LOGTYPE_MLDEV 21 /**< Log related to mldev. */ > > > > > > > > NAK to this part. > > > > No new static logtypes please. > > > > > > Good catch. > > > By the way, we should remove unused RTE_LOGTYPE_*. > > > > Yes, for 23.11 would like to work down the list. > > Do we need to wait 23.11? > It is not an ABI breakage. > And most of these defines are already unused. Turning them into deprecated would be API breakage though