From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F5F941BC0; Fri, 3 Feb 2023 20:14:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDB5A40DDA; Fri, 3 Feb 2023 20:14:16 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id BA55A4067B for ; Fri, 3 Feb 2023 20:14:14 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id z1so4419503pfg.12 for ; Fri, 03 Feb 2023 11:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mxazDyPNclTXxkvMqi7qk5HfZgyxnlRe4TkpRj6YJ+I=; b=ZT6ECiRZsorfC+z5cz3rgToODoTDiXes6I+s7b5WHPEydX3nVPPT/vieyTI8Ow+9+W JJ0L3v3wfIdYbZuYr0bO4QVwcXKnJe7JIuMijBepv9ye9zxr5W0s733WEw92KTtw6QUo TFwMEwbJt4b22J6ct7Np5ryyJA44NlJLsL/C/dPo1Bhf00bVtNM0jm2l6C8cOKiarQko Z2mWTUQDJTgXgSTFjC9N+xP2njcpivF7mXJ7/hMVpgSSXt65htOm20SHPv1NYvnhDhKQ ICCNFiNqptyYJ+mPL1Yc3MJYP6vC5w8mD9VOMAn4knjv6hArGB5kchuxaB/lYawVGMRX rgOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mxazDyPNclTXxkvMqi7qk5HfZgyxnlRe4TkpRj6YJ+I=; b=3rAj6AdqxvQbVL4Pcga6cw0/mdlF+5qfOSKlUCyaeQQepP3sr5U8fo0TK27xYfYIJF vtJTqDzJ+ikA2pCUU5vi551mr6HLfhWfEo2RT/S69w5qNRWGcnePEl9o2eIk693ZvgFO E32kWfLHJHIcfBqZ1FeUg0uTL7kmkGt5qPaAcoOozJgg001eIIywaFCi09mV0wnf0bYF bRVbM4KuOVkoJuevXQIfiyB6kCQ32to547bE1lRNYQGkQg98ORWs33SXLoB4KEEiNWbM r5zxa9eaAEUnBZ3Z7bKrjR+mVqlGAaZKkGGc6M3SU/dvV8rwoyarRKKv7hPTg0Us3Lw2 hNag== X-Gm-Message-State: AO0yUKWDk7gmdfDBwKdq5RxeVbpVbhyN65NpXZUfcz4BaUC5UCee1mZ7 Sr/CSdXJpfp0ucrlRY677gjGxj7Tb6aCLCG4Xx9j+A== X-Google-Smtp-Source: AK7set/X7veMG99SBmRF7gIUY5vsh2yvaJDb65I6ZxOJXT/6FkzOP6suTCyMHstNbGpPMhu9xw5Lhg== X-Received: by 2002:a05:6a00:1d81:b0:58d:bbf:8bb1 with SMTP id z1-20020a056a001d8100b0058d0bbf8bb1mr9630264pfw.14.1675451653751; Fri, 03 Feb 2023 11:14:13 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id l9-20020a056a00140900b00593edee1af6sm2200898pfu.67.2023.02.03.11.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 11:14:13 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: stable@dpdk.org, Stephen Hemminger , dmitry.kozliuk@gmail.com Subject: [PATCH v11 1/3] cmdline: make rdline status not private Date: Fri, 3 Feb 2023 11:14:07 -0800 Message-Id: <20230203191409.97567-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230203191409.97567-1-stephen@networkplumber.org> References: <20230130200914.22049-1-stephen@networkplumber.org> <20230203191409.97567-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function cmdline_poll() returns values from rdline_status enum but that was moved to being defined only in cmdline_private.h. For proper use of the API the return value needs to be visible to callers. This was not a problem before because cmdline_poll() was not used anywhere. Fixes: f8f8dc289095 ("cmdline: make struct rdline opaque") Cc: dmitry.kozliuk@gmail.com Signed-off-by: Stephen Hemminger --- lib/cmdline/cmdline.h | 6 ++++++ lib/cmdline/cmdline_private.h | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h index 96674dfda224..b14355ef5121 100644 --- a/lib/cmdline/cmdline.h +++ b/lib/cmdline/cmdline.h @@ -23,6 +23,12 @@ extern "C" { #endif +enum rdline_status { + RDLINE_INIT, + RDLINE_RUNNING, + RDLINE_EXITED +}; + struct cmdline; struct cmdline *cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out); diff --git a/lib/cmdline/cmdline_private.h b/lib/cmdline/cmdline_private.h index c2e906d8de6d..a3271c76934a 100644 --- a/lib/cmdline/cmdline_private.h +++ b/lib/cmdline/cmdline_private.h @@ -23,12 +23,6 @@ #define RDLINE_HISTORY_BUF_SIZE BUFSIZ #define RDLINE_HISTORY_MAX_LINE 64 -enum rdline_status { - RDLINE_INIT, - RDLINE_RUNNING, - RDLINE_EXITED -}; - struct rdline { enum rdline_status status; /* rdline bufs */ -- 2.39.0