From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C170F41C30; Tue, 7 Feb 2023 17:25:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB0DE40A84; Tue, 7 Feb 2023 17:25:42 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id F13FB40151 for ; Tue, 7 Feb 2023 17:25:41 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id j1so9667595pjd.0 for ; Tue, 07 Feb 2023 08:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qwZN1RnaZktXGIHc25bE7gDNKvS2YE8nCJAmPuG5LPM=; b=wDBUQVyu/7bKUx9wuCAumDJXMmHBrHiwAucY1hGn6NRyyIpQnYMQBMDISXKtQ2H6KP Lk87O+r7u35dWG5QHeFbZCYokNrysvpksfAkAnahWNX52vOek42Mpv5A2sKPNlBDJMkv EEQXjdkM7fvQ6ZdY4V/RuEioEQqTMPuZmovdVxqLha4tFWJmWbVExHwXvcsCY83GCEum NRGzffSrnlMRALIKgZWFqVN/dO/ga2Vl84ignZAUaoht0jRGe4kJ9jh3mqHY3nmrPCR+ /Fyq7/kC+kByjOJv4mBDCPviAkP9CIKJhh1PVLNIleJBG/TqvErVkCqJWx0XzZtHut6b quEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qwZN1RnaZktXGIHc25bE7gDNKvS2YE8nCJAmPuG5LPM=; b=q90+OMrdcr2rqNAs3tQmZdpRDPmdbaZnqE7zZtqWZp8FKLRGSu0KO5kMylwgntdEJO mO/vYZl7TSURrcL6WtgLzQFJMKswvilhGANgH/k2hjJG9Tk3iLXA+V30i+7e0CS6Dj/q 5s32YBoz9QhjVQCTANflQuIaVTEto3Qj5RYuFliIqiFJUSqdcuznhnGjFwO98LmSoO80 J4S1WTLKwHDDb8IdA8MZGJTHEuLnX8tgB7snss7yhvzbx9vP71FWBq5QkFaPpjJuGob3 pJ3tnykDVguvvQTb7nK8KzjnGwRWjlKkusbt6QMXjWPV1FFFn+q5h9ZgVwy1+ewc+nZv ZUsQ== X-Gm-Message-State: AO0yUKWOjE6VTH/A6aPVx3p7bS+l7U7eeji4f3jYSf1MT9i3bYKbPv78 Hx/RYsMpS61g8Q2aJsB92xdqtQ== X-Google-Smtp-Source: AK7set9eY23mwnvRUkdZoSwwabTCKA0ika8z/O7AadpNOh8YcXc4KGBcYw2d5DBRtKOHEImetOBa0g== X-Received: by 2002:a17:902:f355:b0:199:1fa8:dad0 with SMTP id q21-20020a170902f35500b001991fa8dad0mr2694125ple.20.1675787141147; Tue, 07 Feb 2023 08:25:41 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id p24-20020a170902b09800b001992181b5d5sm3496758plr.245.2023.02.07.08.25.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:25:40 -0800 (PST) Date: Tue, 7 Feb 2023 08:25:39 -0800 From: Stephen Hemminger To: Volodymyr Fialko Cc: , Reshma Pattan , David Hunt , , Subject: Re: [PATCH 2/2] test/reorder: fix double free of drained buffers Message-ID: <20230207082539.42f88f06@hermes.local> In-Reply-To: <20230107151939.2540148-3-vfialko@marvell.com> References: <20230107151939.2540148-1-vfialko@marvell.com> <20230107151939.2540148-3-vfialko@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 7 Jan 2023 16:19:39 +0100 Volodymyr Fialko wrote: > Set to zero array of drained buffers after free, to prevent freeing them > one more time. > Discovered with enabled `RTE_LIBRTE_MEMPOOL_DEBUG`. > > Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") > > Signed-off-by: Volodymyr Fialko Maybe include the actual test failure log next time. Looks correct to me. Acked-by: Stephen Hemminger