* [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL
@ 2023-02-07 8:46 Robin Jarry
2023-02-07 9:51 ` Morten Brørup
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Robin Jarry @ 2023-02-07 8:46 UTC (permalink / raw)
To: dev
Cc: Robin Jarry, Ciara Power, Morten Brørup, Tyler Retzlaff,
Bruce Richardson
The doc string was left to its previous definition. Make it explicit
that RTE_TEL_INT_VAL is a 64-bit signed integer.
Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API")
Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
lib/telemetry/rte_telemetry.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h
index ad712732be04..d8ea97f17395 100644
--- a/lib/telemetry/rte_telemetry.h
+++ b/lib/telemetry/rte_telemetry.h
@@ -43,7 +43,7 @@ struct rte_tel_data;
*/
enum rte_tel_value_type {
RTE_TEL_STRING_VAL, /** a string value */
- RTE_TEL_INT_VAL, /** a signed 32-bit int value */
+ RTE_TEL_INT_VAL, /** a signed 64-bit int value */
RTE_TEL_UINT_VAL, /** an unsigned 64-bit int value */
RTE_TEL_CONTAINER, /** a container struct */
};
--
2.39.1
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL
2023-02-07 8:46 [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL Robin Jarry
@ 2023-02-07 9:51 ` Morten Brørup
2023-02-07 10:05 ` Bruce Richardson
2023-02-09 9:18 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: Morten Brørup @ 2023-02-07 9:51 UTC (permalink / raw)
To: Robin Jarry, dev; +Cc: Ciara Power, Tyler Retzlaff, Bruce Richardson
> From: Robin Jarry [mailto:rjarry@redhat.com]
> Sent: Tuesday, 7 February 2023 09.47
>
> The doc string was left to its previous definition. Make it explicit
> that RTE_TEL_INT_VAL is a 64-bit signed integer.
>
> Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API")
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
> lib/telemetry/rte_telemetry.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/telemetry/rte_telemetry.h
> b/lib/telemetry/rte_telemetry.h
> index ad712732be04..d8ea97f17395 100644
> --- a/lib/telemetry/rte_telemetry.h
> +++ b/lib/telemetry/rte_telemetry.h
> @@ -43,7 +43,7 @@ struct rte_tel_data;
> */
> enum rte_tel_value_type {
> RTE_TEL_STRING_VAL, /** a string value */
> - RTE_TEL_INT_VAL, /** a signed 32-bit int value */
> + RTE_TEL_INT_VAL, /** a signed 64-bit int value */
> RTE_TEL_UINT_VAL, /** an unsigned 64-bit int value */
> RTE_TEL_CONTAINER, /** a container struct */
> };
> --
> 2.39.1
>
Yes, this value type has changed as the comment reflects.
We could consider adding a note that the value does not exceed 32-bit when using API version 23, because the "set" functions in API version 23 only take a 32-bit value parameter. But such a note will be purely informative, and would probably add more confusion than information.
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL
2023-02-07 8:46 [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL Robin Jarry
2023-02-07 9:51 ` Morten Brørup
@ 2023-02-07 10:05 ` Bruce Richardson
2023-02-09 9:18 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2023-02-07 10:05 UTC (permalink / raw)
To: Robin Jarry; +Cc: dev, Ciara Power, Morten Brørup, Tyler Retzlaff
On Tue, Feb 07, 2023 at 09:46:36AM +0100, Robin Jarry wrote:
> The doc string was left to its previous definition. Make it explicit
> that RTE_TEL_INT_VAL is a 64-bit signed integer.
>
> Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API")
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
> lib/telemetry/rte_telemetry.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h
> index ad712732be04..d8ea97f17395 100644
> --- a/lib/telemetry/rte_telemetry.h
> +++ b/lib/telemetry/rte_telemetry.h
> @@ -43,7 +43,7 @@ struct rte_tel_data;
> */
> enum rte_tel_value_type {
> RTE_TEL_STRING_VAL, /** a string value */
> - RTE_TEL_INT_VAL, /** a signed 32-bit int value */
> + RTE_TEL_INT_VAL, /** a signed 64-bit int value */
> RTE_TEL_UINT_VAL, /** an unsigned 64-bit int value */
> RTE_TEL_CONTAINER, /** a container struct */
> };
Thanks for catching this.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL
2023-02-07 8:46 [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL Robin Jarry
2023-02-07 9:51 ` Morten Brørup
2023-02-07 10:05 ` Bruce Richardson
@ 2023-02-09 9:18 ` David Marchand
2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-02-09 9:18 UTC (permalink / raw)
To: Robin Jarry
Cc: dev, Ciara Power, Morten Brørup, Tyler Retzlaff, Bruce Richardson
On Tue, Feb 7, 2023 at 9:46 AM Robin Jarry <rjarry@redhat.com> wrote:
>
> The doc string was left to its previous definition. Make it explicit
> that RTE_TEL_INT_VAL is a 64-bit signed integer.
>
> Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API")
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-09 9:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 8:46 [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL Robin Jarry
2023-02-07 9:51 ` Morten Brørup
2023-02-07 10:05 ` Bruce Richardson
2023-02-09 9:18 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).