* [PATCH 1/2] net/gve: change offloading capability
@ 2023-02-10 13:05 Levend Sayar
0 siblings, 0 replies; 7+ messages in thread
From: Levend Sayar @ 2023-02-10 13:05 UTC (permalink / raw)
To: junfeng.guo; +Cc: dev, Levend Sayar
Google Virtual NIC is not doing IPv4 checksummimg.
Removed that capability from PMD.
Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
drivers/net/gve/gve_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
index 97781f0ed3..e357f16e16 100644
--- a/drivers/net/gve/gve_ethdev.c
+++ b/drivers/net/gve/gve_ethdev.c
@@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
dev_info->rx_offload_capa = 0;
dev_info->tx_offload_capa =
RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
- RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
--
2.37.1 (Apple Git-137.1)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] net/gve: change offloading capability
2023-02-17 9:11 ` Guo, Junfeng
2023-02-17 9:15 ` Levend Sayar
@ 2023-02-20 15:43 ` Ferruh Yigit
1 sibling, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2023-02-20 15:43 UTC (permalink / raw)
To: Guo, Junfeng, Levend Sayar; +Cc: dev
On 2/17/2023 9:11 AM, Guo, Junfeng wrote:
>
>
>> -----Original Message-----
>> From: Levend Sayar <levendsayar@gmail.com>
>> Sent: Friday, February 17, 2023 02:58
>> To: Guo, Junfeng <junfeng.guo@intel.com>
>> Cc: dev@dpdk.org; Levend Sayar <levendsayar@gmail.com>
>> Subject: [PATCH 1/2] net/gve: change offloading capability
>>
>> Google Virtual NIC is not doing IPv4 checksummimg.
>> Removed that capability from PMD.
>>
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>> ---
>
> Acked-by: Junfeng Guo <junfeng.guo@intel.com>
>
> Acked-by: Rushil Gupta <rushilg@google.com>
>
Fixes: a46583cf43c8 ("net/gve: support Rx/Tx")
Cc: stable@dpdk.org
Added Rushil's name to .mailmap while merging.
Patch 2/2 is not merged and it can progress independently.
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] net/gve: change offloading capability
2023-02-17 9:11 ` Guo, Junfeng
@ 2023-02-17 9:15 ` Levend Sayar
2023-02-20 15:43 ` Ferruh Yigit
1 sibling, 0 replies; 7+ messages in thread
From: Levend Sayar @ 2023-02-17 9:15 UTC (permalink / raw)
To: Guo, Junfeng; +Cc: dev
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
Thanks Junfeng for acknowledging.
Best,
Levend
> On 17 Feb 2023, at 12:11, Guo, Junfeng <junfeng.guo@intel.com> wrote:
>
>
>
>> -----Original Message-----
>> From: Levend Sayar <levendsayar@gmail.com>
>> Sent: Friday, February 17, 2023 02:58
>> To: Guo, Junfeng <junfeng.guo@intel.com>
>> Cc: dev@dpdk.org; Levend Sayar <levendsayar@gmail.com>
>> Subject: [PATCH 1/2] net/gve: change offloading capability
>>
>> Google Virtual NIC is not doing IPv4 checksummimg.
>> Removed that capability from PMD.
>>
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>> ---
>
> Acked-by: Junfeng Guo <junfeng.guo@intel.com <mailto:junfeng.guo@intel.com>>
>
> Regards,
> Junfeng Guo
[-- Attachment #2: Type: text/html, Size: 5206 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] net/gve: change offloading capability
2023-02-16 18:58 Levend Sayar
2023-02-16 20:14 ` Rushil Gupta
@ 2023-02-17 9:11 ` Guo, Junfeng
2023-02-17 9:15 ` Levend Sayar
2023-02-20 15:43 ` Ferruh Yigit
1 sibling, 2 replies; 7+ messages in thread
From: Guo, Junfeng @ 2023-02-17 9:11 UTC (permalink / raw)
To: Levend Sayar; +Cc: dev
> -----Original Message-----
> From: Levend Sayar <levendsayar@gmail.com>
> Sent: Friday, February 17, 2023 02:58
> To: Guo, Junfeng <junfeng.guo@intel.com>
> Cc: dev@dpdk.org; Levend Sayar <levendsayar@gmail.com>
> Subject: [PATCH 1/2] net/gve: change offloading capability
>
> Google Virtual NIC is not doing IPv4 checksummimg.
> Removed that capability from PMD.
>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
Acked-by: Junfeng Guo <junfeng.guo@intel.com>
Regards,
Junfeng Guo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] net/gve: change offloading capability
2023-02-16 20:14 ` Rushil Gupta
@ 2023-02-17 9:07 ` Levend Sayar
0 siblings, 0 replies; 7+ messages in thread
From: Levend Sayar @ 2023-02-17 9:07 UTC (permalink / raw)
To: Rushil Gupta; +Cc: Junfeng Guo, dev
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
Thanks Rushil for acknowledging.
Best,
Levend
> On 16 Feb 2023, at 23:14, Rushil Gupta <rushilg@google.com> wrote:
>
> Makes sense. The virtual device only does L4 checksum.
>
> Acked-by: Rushil Gupta <rushilg@google.com <mailto:rushilg@google.com>>
>
> On Thu, Feb 16, 2023 at 10:58 AM Levend Sayar <levendsayar@gmail.com <mailto:levendsayar@gmail.com>> wrote:
>> Google Virtual NIC is not doing IPv4 checksummimg.
>> Removed that capability from PMD.
>>
>> Signed-off-by: Levend Sayar <levendsayar@gmail.com <mailto:levendsayar@gmail.com>>
>> ---
>> drivers/net/gve/gve_ethdev.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
>> index 06d1b796c8..fef2458a16 100644
>> --- a/drivers/net/gve/gve_ethdev.c
>> +++ b/drivers/net/gve/gve_ethdev.c
>> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>> dev_info->rx_offload_capa = 0;
>> dev_info->tx_offload_capa =
>> RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
>> - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
>> RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
>> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
>> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
>> --
>> 2.37.1 (Apple Git-137.1)
>>
[-- Attachment #2: Type: text/html, Size: 2435 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] net/gve: change offloading capability
2023-02-16 18:58 Levend Sayar
@ 2023-02-16 20:14 ` Rushil Gupta
2023-02-17 9:07 ` Levend Sayar
2023-02-17 9:11 ` Guo, Junfeng
1 sibling, 1 reply; 7+ messages in thread
From: Rushil Gupta @ 2023-02-16 20:14 UTC (permalink / raw)
To: Levend Sayar; +Cc: junfeng.guo, dev
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
Makes sense. The virtual device only does L4 checksum.
Acked-by: Rushil Gupta <rushilg@google.com>
On Thu, Feb 16, 2023 at 10:58 AM Levend Sayar <levendsayar@gmail.com> wrote:
> Google Virtual NIC is not doing IPv4 checksummimg.
> Removed that capability from PMD.
>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
> drivers/net/gve/gve_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
> index 06d1b796c8..fef2458a16 100644
> --- a/drivers/net/gve/gve_ethdev.c
> +++ b/drivers/net/gve/gve_ethdev.c
> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> dev_info->rx_offload_capa = 0;
> dev_info->tx_offload_capa =
> RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
> - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
> RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> --
> 2.37.1 (Apple Git-137.1)
>
>
[-- Attachment #2: Type: text/html, Size: 1707 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] net/gve: change offloading capability
@ 2023-02-16 18:58 Levend Sayar
2023-02-16 20:14 ` Rushil Gupta
2023-02-17 9:11 ` Guo, Junfeng
0 siblings, 2 replies; 7+ messages in thread
From: Levend Sayar @ 2023-02-16 18:58 UTC (permalink / raw)
To: junfeng.guo; +Cc: dev, Levend Sayar
Google Virtual NIC is not doing IPv4 checksummimg.
Removed that capability from PMD.
Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
drivers/net/gve/gve_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
index 06d1b796c8..fef2458a16 100644
--- a/drivers/net/gve/gve_ethdev.c
+++ b/drivers/net/gve/gve_ethdev.c
@@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
dev_info->rx_offload_capa = 0;
dev_info->tx_offload_capa =
RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
- RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
--
2.37.1 (Apple Git-137.1)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-02-20 15:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-10 13:05 [PATCH 1/2] net/gve: change offloading capability Levend Sayar
2023-02-16 18:58 Levend Sayar
2023-02-16 20:14 ` Rushil Gupta
2023-02-17 9:07 ` Levend Sayar
2023-02-17 9:11 ` Guo, Junfeng
2023-02-17 9:15 ` Levend Sayar
2023-02-20 15:43 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).