From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FFBC41C8C; Mon, 13 Feb 2023 20:59:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2A0F40FAE; Mon, 13 Feb 2023 20:59:32 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 61D5140EE4 for ; Mon, 13 Feb 2023 20:59:32 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id a8-20020a17090a6d8800b002336b48f653so12009444pjk.3 for ; Mon, 13 Feb 2023 11:59:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L3aqaeK/W/k2B6TMYwTak/loUQqlYC0thUkEp6I0Mps=; b=H/r3UzylVsjfQ1aUIzo7/QFbQENHKbYM28EpUWKAL5nmu+c13qH6tdnPyN0ETvMPFQ h8MJOy/zi4x/VFCcpSw93+5ws7I/SwsCrESYMuj0UERX/Kr56lr1BprovW05ZuJobPwJ UrXqSEnaQ2AUSIST/3d+VFIyiwB3JeVsCmJzPOWSWXxKz0wuVMd3rnJu6IfqNVFF8yEf OeqIlWI1VYJkurTNkluQUcGfHUaqrBiXuwE2R6W4vWhk0ZZchsf0HumWp0eFVFHudCZ8 i+JaK+yP1taXrwbXp+lqT2X4a8crw006hpW1CcjevqoijCOjEr3WvnwmVymm/2RBOVnf u2zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L3aqaeK/W/k2B6TMYwTak/loUQqlYC0thUkEp6I0Mps=; b=uYvnRMndUHAAnnWgDr5q0HxtBXhi9nyifVeUmg1eJhkr/s9KIlzg+MzFHHpAXlEkdy hCmxv3OuTwVM1vh5BwrBOZOCVPpEWA1nPtBAkaip4PWdLrufEgPXxPgE1SU8KyzCiWFr wMeN6hALiGE1QdLCZfB2z0JNpqJJw/KlzP/HFje3djks2saPe+4yq33bCGKREX/ZDPdr PRzAJUmXriYVcXd6xZbm93gyDzTYLdtPqq/wbhc8XGLXxihgR0ORh/SlRgy/yV1fx5aK JZ+vGgSzovYKVTxxQ4KmEqHSAx6VyUNj/U8uT/yNTFRwpSSMxWLB/B1HVIibEEP/KPNU hnEQ== X-Gm-Message-State: AO0yUKXEOWr6/mHDpfw1ojPqEmvNTeqUQZSmqxH8LvHEW2zn58cQvjRF XTxPIN6pg6a1p5TnZy0KgK1WDUKivj4jk8R6Cfo= X-Google-Smtp-Source: AK7set+h/Dt01e8lM6ZQ4TgGn1xH7OIO/OBGfhMXbN9ektGsDo/oxWpNhsYeXQG2lTKNjC0KGWEjBA== X-Received: by 2002:a17:903:2281:b0:19a:93fa:2921 with SMTP id b1-20020a170903228100b0019a93fa2921mr135440plh.24.1676318371351; Mon, 13 Feb 2023 11:59:31 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id n20-20020a170902d0d400b001994e74c094sm8578911pln.275.2023.02.13.11.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 11:59:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , jiayu.hu@intel.com, Mark Kavanagh , Konstantin Ananyev Subject: [PATCH v4 01/19] gso: don't log message on non TCP/UDP Date: Mon, 13 Feb 2023 11:55:33 -0800 Message-Id: <20230213195551.1146298-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213195551.1146298-1-stephen@networkplumber.org> References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230213195551.1146298-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: jiayu.hu@intel.com Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c index 4b59217c16ee..c8e67c2d4b48 100644 --- a/lib/gso/rte_gso.c +++ b/lib/gso/rte_gso.c @@ -80,9 +80,8 @@ rte_gso_segment(struct rte_mbuf *pkt, ret = gso_udp4_segment(pkt, gso_size, direct_pool, indirect_pool, pkts_out, nb_pkts_out); } else { - /* unsupported packet, skip */ - RTE_LOG(DEBUG, GSO, "Unsupported packet type\n"); - ret = 0; + ret = -ENOTSUP; /* only UDP or TCP allowed */ + } if (ret < 0) { -- 2.39.1