From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECCC941C8E; Tue, 14 Feb 2023 03:19:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7B8642D31; Tue, 14 Feb 2023 03:19:22 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 9A7F242D0D for ; Tue, 14 Feb 2023 03:19:21 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id z3so3062407pfw.7 for ; Mon, 13 Feb 2023 18:19:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L3aqaeK/W/k2B6TMYwTak/loUQqlYC0thUkEp6I0Mps=; b=IwddeVjXgKShPgx507c5D4+/sY8aPv84jMgqff2z9PFY+wqZBzZ+FJtHkr/pMV3Ozx pyOTldc4VbKlUSnZISd9xs13rOx+hs6eMirDbxO3B+B3oJCMexKlnL0OCT3FanZnCytZ cwK5+jADrK9aNJ8akaxSVYsfTWNI8iZkDzZsOztbLyeCJwIS7ZK7vtxmCHDm6s/S9YaX tK7WWRJ/2Ns9DtzUnkGXPQqy6A6NHfbMZAKBard1XjYiVUNas9jx78bm71zsQm8GJ/Ws Wv0qzUbvOOQfgVHv7mOch/uvKLj3eExtP9+81VTAnc4K71Vw1y3RYCbu37VQ+fWr9j3L D2Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L3aqaeK/W/k2B6TMYwTak/loUQqlYC0thUkEp6I0Mps=; b=q8c1vUC5RXFszGqvpY+ImJR0CQ2eMQ+c23T+AbIVQQtVRz/bapCfG93GD7tCOpP0GE z6onA/T6KPBrMN4ijDLCJ5qq0JTFJ2Zkhv/oGVsxKBwrO9B/hbJxvhfjndmN4DctCJSv LxC2skn87IWe8pJ5JHFvXym6GrrVbEiPz0VLvwSbear1UV6Fv1kVHxxmQ9cc9S5HeIUY 4k5dBWis9pIn8bO9AHJYFgln2Pq+7YdSuFssA/WucSTWO/FDqyXUL+0/+ws/XLqf2+wn svcoT8S/sTnSikta7qSbq1fzkMYi9tVzphbp0fFsDezLldIqGjrLrFGtKeCfou45NXKY QFCw== X-Gm-Message-State: AO0yUKUYjaDiFM4O3012JT9wW/RnIURfZQqVtUqHA3iP7jgpRj39536V zdzvIciY7U47QP71yknwtDyJ7ZJY+rEq+jTo9Hk= X-Google-Smtp-Source: AK7set/CQLKguSPu2+YXTXnGzQb/xtx3xB0mA/rwPuDwZy/90CcTflVpa8xSk7auMI8LUhZYPAl6wA== X-Received: by 2002:aa7:960b:0:b0:5a8:4c8b:49e with SMTP id q11-20020aa7960b000000b005a84c8b049emr570111pfg.3.1676341160602; Mon, 13 Feb 2023 18:19:20 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e16-20020aa78250000000b005a75d85c0c7sm8494840pfn.51.2023.02.13.18.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 18:19:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , jiayu.hu@intel.com, Konstantin Ananyev , Mark Kavanagh Subject: [PATCH v5 01/22] gso: don't log message on non TCP/UDP Date: Mon, 13 Feb 2023 18:18:47 -0800 Message-Id: <20230214021908.1396498-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230214021908.1396498-1-stephen@networkplumber.org> References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230214021908.1396498-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: jiayu.hu@intel.com Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c index 4b59217c16ee..c8e67c2d4b48 100644 --- a/lib/gso/rte_gso.c +++ b/lib/gso/rte_gso.c @@ -80,9 +80,8 @@ rte_gso_segment(struct rte_mbuf *pkt, ret = gso_udp4_segment(pkt, gso_size, direct_pool, indirect_pool, pkts_out, nb_pkts_out); } else { - /* unsupported packet, skip */ - RTE_LOG(DEBUG, GSO, "Unsupported packet type\n"); - ret = 0; + ret = -ENOTSUP; /* only UDP or TCP allowed */ + } if (ret < 0) { -- 2.39.1