From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0731241CA8; Wed, 15 Feb 2023 18:12:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EB9E40A7D; Wed, 15 Feb 2023 18:12:38 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 94F114067E for ; Wed, 15 Feb 2023 18:12:36 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id bx22so18775109pjb.3 for ; Wed, 15 Feb 2023 09:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=b1i7viEvP44EJYrPwRP08ILZ5zGhrSx4mUviOg15Kxk=; b=Tbid3Y8LNmb97p2RcencGJUTxsuVXtVUguFi4IeNEMLB+A5ilbhUmTpnGyaPrQqZgZ 1HfDhr25uDPCAeNBnwji/haNNYIGavf9dQKO9md+MXEvd04qSuYJh4iavKY8IanOZleI cOEf7junOLf9rjVazAIugJsYbr13rf63SqjJ5oL9N2CZaJtlTaldeGM0gkFKnAAwIeZ/ 1ROb9xlWJyGJ26gXetudAxs6RqB1wTZzj6LlnH+wN1RzSCUj69hE16rN4UGVCsdatZkD tG74mafM12QOh7XM8eU8qcycyeuYopOzQre2/jXUZgMrPkOlOJTzNGLLhDa3cdnoD3wz fSFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b1i7viEvP44EJYrPwRP08ILZ5zGhrSx4mUviOg15Kxk=; b=Qm5oxoCmTq7nom6pJqlGG1IGHJxgYsbgstqlaXRgLEr7r6NJTq6z93l9YyejHPdtLo qPvejDxeg1ylhRfssZJLYfKGVwZzeECP7llD6vbxLWku4YiQYvVttnjufGDNfUJ/n6CX J76WHA1GKA9wpURiyO2n8t5++Qeuaf9JVsTmKrAJ+0w6qYizHTS6swLHvyasNCwndp6r 3cmpQ9iOrytOOhNEjOUB8yqyfq1/wN5Mh23f+f9yAtPDXS4Qd08sordoTUExNEJnLRix o+qqPWVyFeH00hE2jbMzmEh6VP3nAMNNXvqN6oM/j71rSdjyti4qMF/p2yDFvDTkZoC3 YHQg== X-Gm-Message-State: AO0yUKU3Bhv/HvrB0kc2//PeKndb3xaTNLCJAVUtD9H6YN6Li6uafT0d AJrRTRyflEbWH48pM/GV/HExFw== X-Google-Smtp-Source: AK7set9RL7ez5ahBsckVI+240jY92zJ4W+eQ8fl+TBBsYR9l+S9QchtFuSZ2W39eeZ+BM/tTo1dToA== X-Received: by 2002:a17:903:84d:b0:19a:a5d0:fac7 with SMTP id ks13-20020a170903084d00b0019aa5d0fac7mr2505485plb.7.1676481155639; Wed, 15 Feb 2023 09:12:35 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id f22-20020a170902ab9600b0019a7385079esm10219612plr.123.2023.02.15.09.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 09:12:35 -0800 (PST) Date: Wed, 15 Feb 2023 09:12:34 -0800 From: Stephen Hemminger To: "Hu, Jiayu" Cc: "dev@dpdk.org" , Konstantin Ananyev , Mark Kavanagh Subject: Re: [PATCH v6 01/22] gso: don't log message on non TCP/UDP Message-ID: <20230215091234.57b26084@hermes.local> In-Reply-To: References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230214224735.1404326-1-stephen@networkplumber.org> <20230214224735.1404326-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 15 Feb 2023 07:26:22 +0000 "Hu, Jiayu" wrote: > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Wednesday, February 15, 2023 6:47 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Hu, Jiayu > > ; Konstantin Ananyev > > ; Mark Kavanagh > > > > Subject: [PATCH v6 01/22] gso: don't log message on non TCP/UDP > > > > If a large packet is passed into GSO routines of unknown protocol then library > > would log a message. > > Better to tell the application instead of logging. > > > > Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") > > Cc: jiayu.hu@intel.com > > Signed-off-by: Stephen Hemminger > > --- > > lib/gso/rte_gso.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c index > > 4b59217c16ee..c8e67c2d4b48 100644 > > --- a/lib/gso/rte_gso.c > > +++ b/lib/gso/rte_gso.c > > @@ -80,9 +80,8 @@ rte_gso_segment(struct rte_mbuf *pkt, > > ret = gso_udp4_segment(pkt, gso_size, direct_pool, > > indirect_pool, pkts_out, nb_pkts_out); > > } else { > > - /* unsupported packet, skip */ > > - RTE_LOG(DEBUG, GSO, "Unsupported packet type\n"); > > - ret = 0; > > + ret = -ENOTSUP; /* only UDP or TCP allowed */ > > + > > The function signature annotation in rte_gso.h also needs update for ENOTSUP. > In addition, will it break ABI? Not really, if anybody hits this error case, nothing good would have been happening.