From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3955341CAC; Thu, 16 Feb 2023 07:28:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 277DC40A8B; Thu, 16 Feb 2023 07:28:39 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2129.outbound.protection.outlook.com [40.107.244.129]) by mails.dpdk.org (Postfix) with ESMTP id 7473E40695 for ; Thu, 16 Feb 2023 07:28:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NWHWD8AoL9N2WrYY1ygoHk23+FV+BeQ5oZWYpryFuodExvRRC3tgtITnRR/7YLuU96IbwpwmmZlkVq3C3J7vRc8EWjB1P1ym26Gusp00NHmweSmUGIeaGxUxYuaibEtnzAkhNqFk9Py12InUcvQLnaIeXBi9MB99q323EPrgn0vVYw/U1pooNrbAZxiGzZ7wGopZVT7pJClHGK7WiE3F03ukTQFej8wrKYxH/k5YcyKkecE87jay07NE4PNB2v5nhX4IUNQ6nb6Yr9DgZu7qbnvgIwnmIRGgsFXfVd1ntzbuf6jR7YU1SfZTvyYc0FiraTDM0D0ajrxZ0v9soAgWTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OgOagA1UDjF441hCshVAfebYSUOv5Vzan+LHtIl+3U8=; b=Q6LyqNWP1WKJk3lpAQ13DO9M1hSOtG8sbr2LiZVKr58YZE9LoHEhc8rdBoyL1u7ZZbTZutkrC0GzD7IXUSU4OrGBjzAs8YgFgk8+UUS0cZ3CefVFKLVumDPRdSw9qAbxgo2Lk8MpD/dWM9jGkCnR5DRpWNFHpxZ4X2QG9F6RJRahSoHzC9HT8l15uRHJ+arg3IUyeqHUiFab2EJxLfWGrQoblGkC9PCH70Aur2z9gdRrnypx0ka7iuIdKl+raGaBo40vQ6eA6HEB1gRK5eLBH7P8E3W/IbG/J+QW0yH/otBxIUBJB0/PQsWcMm5M1cRa1ARRV+gYie0N3JxmxR8zLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OgOagA1UDjF441hCshVAfebYSUOv5Vzan+LHtIl+3U8=; b=g+YBDAShK5vbYI6IkiG53Tw/ve9yXbJCWuv+jL+yJIIZnGUa4q1VfyJvYXBBQAJDcYkS+qoRG8vAYhWzFXsnmIcH5mAHhYawS4v0X56fcbOB8ICwpXZETY871afjOrFmLr9VnJ5lilzq+7nAHleUlN9FiOrx4uN80IlWkacGKL4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SJ0PR13MB5723.namprd13.prod.outlook.com (2603:10b6:a03:40a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Thu, 16 Feb 2023 06:28:33 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%5]) with mapi id 15.20.6086.026; Thu, 16 Feb 2023 06:28:33 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He Subject: [PATCH] net/nfp: remove the unneeded check logic Date: Thu, 16 Feb 2023 14:28:13 +0800 Message-Id: <20230216062813.8534-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI2PR01CA0002.apcprd01.prod.exchangelabs.com (2603:1096:4:191::21) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SJ0PR13MB5723:EE_ X-MS-Office365-Filtering-Correlation-Id: 34e2557e-37f3-40fd-a90b-08db0fe706b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u5/8fKLyXK6hqE4clfYFKEVay9MfBmj+4GI4YBWf/j/HH0wSDUWV/CGUbmaHZ4i6mJ6CmFUyU7cUtUdWTOLyzhiJz322b8vL2ZtT6SJM83mjiLYP6tJrll9Im7tuHJEIvYofdtuzNHyfyex6WxuxYvzwTNAkIbKRgCBTQ7nNUd+pPa52SnzIJW+pn1DTrYe6Jk75B8OksjeirwDg4jqLaOyI/uq21ctC//Nl89sbxx9cbgjA+qqAX/da2Jg7CrJFCIrpDnraN/LEvl/StZEhQlAGGBuIO0psr8PhvLntixtymVKs+NfFr0GAST0ajwU2zUXgpEThbAnPsA8mqzcUAO5nB8QLn4PpDiLezSJfy7DRRtOKyobJViwEKLdqQkW6fhpU1z24fFUMw2TWaxDn1npkWF2K4Zw3FuJ0FQRBfNe7fGt1ebory4ENqd05LMzfDoZgwWyx+uL3LenR71dcgSrhMwnccHK15Ug3C6kxuq/IV/aiFHBbaHUKrFuW59khvBERNwtiGkg7u9s/Z7j6iwNYJL0AOswu3oUxvO7HKk6mIuvPtSKquc8OHjdS02aaXB2uYge7hccQ/y1+CAclb8QzfHj4HHj/wIJsel8mS/uT7bsgFo/SCt0sx7JXrilEWBZG/hotLACsEJ03rMFEHuXWQtzYBXnAqQgVlFq20oalUOh/B0e1B7fpU7AaKF/s+E4P89ojdtcngq5LYrn/Hw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(136003)(39840400004)(366004)(376002)(346002)(451199018)(36756003)(41300700001)(8676002)(316002)(6916009)(66476007)(66556008)(66946007)(4326008)(38350700002)(38100700002)(86362001)(1076003)(52116002)(107886003)(26005)(6666004)(6512007)(186003)(6506007)(8936002)(44832011)(2906002)(5660300002)(478600001)(6486002)(66574015)(2616005)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEhROVkxTFlaY0lXZEJkdFIvdGNzUWcwWWgxNlN4MlpRQWwzd0RzVXZYUTQ2?= =?utf-8?B?WWJ5d09MRkJ3dVJwTEt0VmFGaHhUb0dXN3YvS0hzczQ5Rm1VM24vZVF3MlZR?= =?utf-8?B?T3g4b2ppNmFzTHJ5bitST1RIQXVUeHdBZ016REVnOWVvVVQ2K2hkMEo4ZS85?= =?utf-8?B?ckhkSkZxWU1jMlFQeG1oWEZmd2s1YTBzUHVLenZhQkV4alBrVWMwOGs5emd6?= =?utf-8?B?VndEQWVjeE1BYmJXcWtYNGxaNW9xSnc3cjNjUWZEeXVxbng4Ny9oMVBUbFd3?= =?utf-8?B?ZXlpVm53a0R4U2kwODBEbWhBbHB2a2RSM2h3bEZRelVBaERXQ25zNXc5eUty?= =?utf-8?B?dWx6TExkK0c1M1ozNy9BTWc1RENwYlpEWG1iRDdxeTM5SHgvY1V3alc2OUFS?= =?utf-8?B?VDJZUTlvN3Q1bmhpS1dMM3NrZkdmR3FQYk9nVXh5MjdYZWNPdCtaTEZjTWRa?= =?utf-8?B?bGJFOEV1bEx6Y3pGMjdQdGNhb2FocUR0Zm9QdXZrR1RIWDB6UmQ4WVlrTFZi?= =?utf-8?B?Q3kyMmNyTUJwNDFmYTdUMUlaZFZ6dUNQR1BFdmg0T2c3NHE1b0s3ZEI2QzA4?= =?utf-8?B?S0hJcDBoR3UvYUhmbzZhUUF2Y00rNG1PSXE1UzlJL0gxQXd6Y3M1N2VHN1dW?= =?utf-8?B?NEc5QlFjQzBPd2xXUVlaVnNsZExGNjQwRFl1aGZKaWVYanFKN0JobmtGNjYw?= =?utf-8?B?UHAra2Ria1ZqUnRuUENoYjdyd2tlVnkwZ3M5K3JxMkp6VUdyMTI4VStmTDRv?= =?utf-8?B?UElWN1FveWtkN1FTQVBPcFVGaFFPcE1PLzJkRFlOYk5tdXRNaDZ5TjhDVGpJ?= =?utf-8?B?WEcwd1NqSWovUzNGMDl6bURpb1hGRjgwSnJ4Yy9xUTROQWxjSTQvSXMrTUFs?= =?utf-8?B?dWZ5MmdBTERWbklScDJSRHREM29xektJOVo0QVZhcTY3c2dYMGNwaE9VTEZH?= =?utf-8?B?S2hWMnF5REUxdUNSUEhZeXA2cThqaWxYbUNqQktONzFmYXBoZ0NZYTY4VWdX?= =?utf-8?B?WTVwTlozUlBkY0xHVXJvQ0dRRklGeHFFWFJKMHZ0SWk0NEVyOFpyMVVsTWtN?= =?utf-8?B?NFNjUGF5MHZPMjk4R2x6alBtYjRqMGJmdUdTZ2NzVUVTMWVkenVTTGdWc01T?= =?utf-8?B?ZWFBTWJWQlNZRnlzYUdaR2hXVFVLLy9mbEdINjNvaFBYRno3UXNsNVp0ZlZy?= =?utf-8?B?Q1JrM1BQMWtaS3dHbkJSdnpmT3hLbFRubWlPRWFFNGczVWZreHMzN242cERl?= =?utf-8?B?TmJlMGtQMmtQS29hemx3eVowajEreHZ2TThpQnBQY05aYmlRNXlVMnNlY2xw?= =?utf-8?B?a25PYzFyckZad09nMGpZMHBmYlNZb0M1TG5VMGhXWDFadS82L3k4emh5bjFh?= =?utf-8?B?SDNVRzIvakkrTTI3dTVnU3IwZzc2enJXSys4OXVlQnJkMVJTOXBoS1NrbFJZ?= =?utf-8?B?cldTUkRRc1dzTHZSSThPVGI5YzgyOVU1YjdQS3h2R01NT0dCaXM3ZG5nTEEy?= =?utf-8?B?VUtybHU5SDZoRUVTMmVyMld0Z3dCU09lTzNHaTFLLzZ6UjRPTUEyeHhHdi9M?= =?utf-8?B?elpZcWpqVlRvT1JVeG9uL2hycEdqbUhkV1MxNkgxaWIrajBySmptMytwOG9R?= =?utf-8?B?MXEvb0RybVFsb1p1cVlXM0xDY1loZTlKaElQdUNjSzdrUGtlR1JPdkUrdTd5?= =?utf-8?B?MDc0Z200Q2dJZEFkR08rQ3FVc3d4bHduWFRRZU9QWE5xQUF1aUdFUUVzT0M4?= =?utf-8?B?T3d5WmFFMmlDaVdsRHd0UmNXcmczZTV4Umw4c2FVeUhHNVRWU2NRMFAyMGIw?= =?utf-8?B?TkRMeG1PdEkrWkVXUnpicGdIWVdRQWo4K3dPMWk0VXZ1Z1Z2ZEJVZ21yRG9T?= =?utf-8?B?d250WW14Z1M4WTEwVWM2cGRGZHNQcWdSdS8rZ1FZbVoxQkZQYVRzei81QUxw?= =?utf-8?B?V1hEVXUxeGp2a094MUg2U2xJYzlZUXhWYU5WYzM0M1Z0QkdpVk16NGVIWVZE?= =?utf-8?B?bjJGSEYzQmRGdiszWXlTaDAramY2bnBsOTFFS2ZXSjdjMjdCNHY5WGpsMFE5?= =?utf-8?B?dnk2UXVWMCtVbmF2NlFBNFFsMzZHdWtEQ1JrYmFJbWZtVTZxMUZ4RGdBYWdL?= =?utf-8?B?dzJraFk0TVQxUXdKTGlIelk3bWlpUmJORzY1ZHFEc1B4VGYxL0MyQUpwTERS?= =?utf-8?B?RVE9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34e2557e-37f3-40fd-a90b-08db0fe706b6 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 06:28:33.0535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: usILHEPNke9aL4xO0Mg2cx2InfMrFE0ZBk2Gzja4p+2HvSoXheCfV+yjTcA9neE3IdCZNW+xtcBaYRbI+EY7QPRUqs3R3gsbuVfJxn5CzQU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5723 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove the unneeded check logic of ingress and egress flow attribute. After the OVS commit c7da49bc ("netdev-offload-dpdk: Fix transfer flows"), the flow can not offload anymore if we don't do this modification. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index bd3a8d2a3b..c9abaa3adc 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -3613,7 +3613,7 @@ nfp_flow_setup(struct nfp_flower_representor *representor, const struct rte_flow_attr *attr, const struct rte_flow_item items[], const struct rte_flow_action actions[], - struct rte_flow_error *error, + __rte_unused struct rte_flow_error *error, bool validate_flag) { if (attr->group != 0) @@ -3625,18 +3625,6 @@ nfp_flow_setup(struct nfp_flower_representor *representor, if (attr->transfer != 0) PMD_DRV_LOG(INFO, "Pretend we support transfer attribute."); - if (attr->egress != 0) { - rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, - NULL, "Egress is not supported."); - return NULL; - } - - if (attr->ingress == 0) { - rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, - NULL, "Only ingress is supported."); - return NULL; - } - return nfp_flow_process(representor, items, actions, validate_flag); } -- 2.29.3