* [PATCH] net/iavf: remove contrains for AEAD IV and AAD size
@ 2023-02-17 11:52 Radu Nicolau
2023-02-21 0:33 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Radu Nicolau @ 2023-02-17 11:52 UTC (permalink / raw)
To: dev; +Cc: Radu Nicolau, Jingjing Wu, Beilei Xing
Because of incosistencies between IPsec library and sample app
implementations for inline crypto remove IV and AAD size constrains
from the advertised crypto capabilities
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
drivers/net/iavf/iavf_ipsec_crypto.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c b/drivers/net/iavf/iavf_ipsec_crypto.c
index 08a80137e5..082948b61f 100644
--- a/drivers/net/iavf/iavf_ipsec_crypto.c
+++ b/drivers/net/iavf/iavf_ipsec_crypto.c
@@ -1305,13 +1305,14 @@ update_aead_capabilities(struct rte_cryptodev_capabilities *scap,
capability->aead.key_size.max = acap->max_key_size;
capability->aead.key_size.increment = acap->inc_key_size;
- capability->aead.aad_size.min = acap->min_aad_size;
- capability->aead.aad_size.max = acap->max_aad_size;
- capability->aead.aad_size.increment = acap->inc_aad_size;
-
- capability->aead.iv_size.min = acap->min_iv_size;
- capability->aead.iv_size.max = acap->max_iv_size;
- capability->aead.iv_size.increment = acap->inc_iv_size;
+ /* remove constrains for aead and iv length */
+ capability->aead.aad_size.min = 0;
+ capability->aead.aad_size.max = 65535;
+ capability->aead.aad_size.increment = 1;
+
+ capability->aead.iv_size.min = 0;
+ capability->aead.iv_size.max = 65535;
+ capability->aead.iv_size.increment = 1;
capability->aead.digest_size.min = acap->min_digest_size;
capability->aead.digest_size.max = acap->max_digest_size;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] net/iavf: remove contrains for AEAD IV and AAD size
2023-02-17 11:52 [PATCH] net/iavf: remove contrains for AEAD IV and AAD size Radu Nicolau
@ 2023-02-21 0:33 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2023-02-21 0:33 UTC (permalink / raw)
To: Nicolau, Radu, dev; +Cc: Nicolau, Radu, Wu, Jingjing, Xing, Beilei
> -----Original Message-----
> From: Radu Nicolau <radu.nicolau@intel.com>
> Sent: Friday, February 17, 2023 7:53 PM
> To: dev@dpdk.org
> Cc: Nicolau, Radu <radu.nicolau@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH] net/iavf: remove contrains for AEAD IV and AAD size
>
> Because of incosistencies between IPsec library and sample app
> implementations for inline crypto remove IV and AAD size constrains from
> the advertised crypto capabilities
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-21 0:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 11:52 [PATCH] net/iavf: remove contrains for AEAD IV and AAD size Radu Nicolau
2023-02-21 0:33 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).