From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9A0641CE2; Sun, 19 Feb 2023 18:53:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3A0442D3A; Sun, 19 Feb 2023 18:53:53 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 924EB42D31 for ; Sun, 19 Feb 2023 18:53:51 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id d21-20020a17090abf9500b0023127b2d602so1003554pjs.2 for ; Sun, 19 Feb 2023 09:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=m+4bcEYEPT09uO9tT2H0UallzBxKXmq9oSZbX6bJoKc=; b=E/4oDL5Ox8wS82E5sD6aY14UYPQJ4FIQDQevaRetOCG2+f0esbQxYlIqitGDeQRfjm ZJEsW0kPTYGNbVD/wLKiqB2v+6A+SFrK/YKkCu3cUOLib9n7UqtuirEeOqyMDEYVs1CR OzyJU+hXyx2xlXgR4hWVJh2GWAHU4d+9M2LfxpfX2gl4B1yYmJN46ofrHfOW5mcLY+IB y6Mn2aIf96dJx3lbMWeqPMNeSrb+Nk8DkwHdrfeuH95O95UELkM4xwVygkN/ABw1Pd0T Sb+BybAlrtXtsVwsz7tCM+zn8rgNzOj/2BcDhL456S7u/C74ZwPSx3GWn2t9/GV2vdZW v4qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m+4bcEYEPT09uO9tT2H0UallzBxKXmq9oSZbX6bJoKc=; b=eCMJd0myOTaB5+uhVpmgwFuzzNw1w+sGxptQRzglmvwNmtiIrnfqH/c6nPLgpoBsZ3 C5FO8ciYfyMM6R9nxiRPwEs13jMLXjhREpTDexVAYRGIfNGk5OizItgtlZVbhMuQwMb8 L7zFkW9PzGns+tABpH6KQfjEkAGnT7bJPR7vGOmcysJz5fczvmWspSxrWlZKdab9NayX Dw8+6PV6H1Ye7jv9IS4XMr4vB5Ji60ttXHQJk39Ivh5Mubw9xex/PXtoST7HRjb7MhZp /hTTnxdMam6c711K/58wni5HO1w9PZ1mO6nyUNuXIqNuFKkRMm4WL2bbp3xtzh73Ua3d fVGw== X-Gm-Message-State: AO0yUKXC2RxrXohzIvZkkbnwAK9CNYh6j3D2fc1zmmLnvvp3BUIZSN2q 5QDYfWiS4bQPBOMwVfYh/iJ0HfO3oovhDXyJFag= X-Google-Smtp-Source: AK7set+VVjkJ+ZZVTsuwkokuSOWRsxBphb6ntv7HpUbvsXZCpzaV1DQVTZf8kIUzUrRnaNjpdAhNGg== X-Received: by 2002:a17:90b:1e02:b0:234:86a5:f7f0 with SMTP id pg2-20020a17090b1e0200b0023486a5f7f0mr1754728pjb.16.1676829230315; Sun, 19 Feb 2023 09:53:50 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id b14-20020a17090acc0e00b00230da56ddecsm963652pju.27.2023.02.19.09.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 09:53:50 -0800 (PST) Date: Sun, 19 Feb 2023 09:53:48 -0800 From: Stephen Hemminger To: dev@dpdk.org Cc: stable@dpdk.org Subject: Re: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling Message-ID: <20230219095348.5f496a67@hermes.local> In-Reply-To: <20230203191409.97567-1-stephen@networkplumber.org> References: <20230130200914.22049-1-stephen@networkplumber.org> <20230203191409.97567-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 3 Feb 2023 11:14:06 -0800 Stephen Hemminger wrote: > This patchset keeps uncovering bad practices in the cmdline library > around end of file and signal handling. > > Stephen Hemminger (3): > cmdline: make rdline status not private > cmdline: handle EOF in cmdline_poll > testpmd: cleanup cleanly from signal > > app/test-pmd/cmdline.c | 29 +++++-------- > app/test-pmd/testpmd.c | 77 ++++++++++++++++------------------- > app/test-pmd/testpmd.h | 1 + > lib/cmdline/cmdline.c | 11 +++-- > lib/cmdline/cmdline.h | 6 +++ > lib/cmdline/cmdline_private.h | 6 --- > 6 files changed, 62 insertions(+), 68 deletions(-) > Could this please be merged for 23.03? There are Ack's. The only CI failure is a bogus performance test failure.