From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CA0841CEC; Mon, 20 Feb 2023 17:31:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AAA94303B; Mon, 20 Feb 2023 17:31:38 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id B92D143095 for ; Mon, 20 Feb 2023 17:31:36 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id 99so1964754pjz.4 for ; Mon, 20 Feb 2023 08:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TzCrCAPSlnQU/8y+a5W+A1Z//Ickk30181NrFHyR6Jk=; b=rUbvC7B9bcVj2WmZXE9tb+3JR/DuCAvugaQ4Qvwf/YCsc1ikmWf2qRp+rKyPoWNxPD z/UET5wvmphpLHu+4AxXVWxJXEj2UV4b96nimBKdCYlKzwvd70F4CyC4kuPWB8u6lUXQ cccu1VwuOfpY1vLpaAlgSGw+qTmlRr9dUIcIp/zK8xf5eLEEuSkkc7QNUJl7z4z/hOxz +dN1OSpTqpPz8s2lQ2LvW2Z7pKdDcjJy6KkXHZv8F23kNjnjyhYLjQq97uBGaPapKwdE zHx9sbE4tEmMMndcNfaGXtWvQwM2wm4CheB+DhjztV57GCA8KQ338EQvT7ntwjCyLZhp Hwvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TzCrCAPSlnQU/8y+a5W+A1Z//Ickk30181NrFHyR6Jk=; b=GaEO4IU42NznBn4KYKbgs3UjkT1v17NCkXg4eM86Syd+NFYnKzm0gz15hgk5rowYiA 7XiilHFfg906jbjmQ2oN4rJAp2z8+0+Ahhlwq+t3XvgJm/Y+ix/ESDIJwB5bNQIu7Re2 ZLlgpnd1nc0OceHfAUcXJp1JabBcEO5osYnw6at4nVbX5ySi+D7iNb5Qz4Au60/0iU7L n5yUr5UgFIR+Ytr2PmxY0zHqFwc2v4zYeeyREz2mzwaTD/xHWEsZKDQ1Hvco7XV0Hwxu Uf3gHK6eE6Qn/Ib8v2u6TJ9Y6WizTeRKpO3HIL77Kh5M4kxvMGx/0iulJJOPRgnKSYan NFuQ== X-Gm-Message-State: AO0yUKUNzqshSZgWIdpSBQ03J3td6RtE5d0FaHK+6HlJtZtne4VUe1z8 EpmidFcY7qn5qKms/hluxADpRA== X-Google-Smtp-Source: AK7set+Pnt1S6p9FKMOl3YKhWvgsiJ9uVB1H95VFFrpYc4q+oCSCmf4ACPETmu+RupSjhoL+auUeSA== X-Received: by 2002:a17:90b:4c0a:b0:233:ca14:6ae8 with SMTP id na10-20020a17090b4c0a00b00233ca146ae8mr532756pjb.45.1676910695703; Mon, 20 Feb 2023 08:31:35 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j14-20020a17090a2a8e00b00231224439c1sm1738238pjd.27.2023.02.20.08.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:31:35 -0800 (PST) Date: Mon, 20 Feb 2023 08:31:33 -0800 From: Stephen Hemminger To: Simon Horman Cc: Chaoyong He , dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu Subject: Re: [PATCH 1/2] net/bonding: add independent LACP sending function Message-ID: <20230220083133.02283b8f@hermes.local> In-Reply-To: References: <20230216071514.29418-1-chaoyong.he@corigine.com> <20230216071514.29418-2-chaoyong.he@corigine.com> <20230216114727.561e8abf@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 20 Feb 2023 10:46:16 +0100 Simon Horman wrote: > On Thu, Feb 16, 2023 at 11:47:27AM -0800, Stephen Hemminger wrote: > > On Thu, 16 Feb 2023 15:15:13 +0800 > > Chaoyong He wrote: > > > > > +void > > > +rte_eth_bond_8023ad_lacp_send_one(void *queue) > > > +{ > > > + uint32_t i; > > > + uint16_t slave_tx_count; > > > + uint16_t active_slave_count; > > > + uint16_t active_slave_ids[RTE_MAX_ETHPORTS]; > > > > Thinking ahead, all of bonding driver should remove the usage of the > > terms master and slave. Perhaps you don't want to introduce new > > usages that will have to be fixed. > > > > FYI - there is no usage of master/slave in any of the IEEE standards, > > or operating systems other than Linux. > > Thanks Stephen, > > could we agree on alternative language? I did a little looking around and did not come to a great answer. Looking at FreeBSD (and Solaris) they use lagg for the aggregating device and laggport for the devices associated with it. Applying same logic to DPDK would be awkward because it already uses the term "port" in multiple ways. Cisco uses the term "port channel group" when configuring link aggregation. Going that way maybe use channels as the replacement for slave in code like this.