From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F09B041CF8; Tue, 21 Feb 2023 06:52:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 751C143184; Tue, 21 Feb 2023 06:52:45 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2129.outbound.protection.outlook.com [40.107.94.129]) by mails.dpdk.org (Postfix) with ESMTP id 5B5E043184; Tue, 21 Feb 2023 06:52:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ipSnSYh1pr7DfvGbraW6YR+Mh4bY4fsWUFy2St9iwkIeyZ1rzHiUFaBlR0EchDn2SyKgT+CsCH+LO+eoYwuuiu4NYuM3NULZ+bTEOK7JPy1n3b426PpiZre1S/LcjZHyACuYDjgDnO8LnQx04ny8OlIhKwqBjI5Yyp6KcT2VcQQuxfvwH9QROQ8htUGxyfupsyisCTZ+3KJIJjDp7kjfuja4DTbeLSq3eQqLEVRLa27QmIjtVKZLzC2/3dL3mewAxLelpmFAp0zvbT0QJYraLoS4S9+gR6Cv7AmwLgpEv7ST9PWfXoEgYm0vtCn6tvg0L/cnmEavS9ThYZ75LIS/IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fQJo6Rgl1nycSssmrVppAVElZlufoFN6V1/WvEEhfIM=; b=klOCiKxw1CNR3fG0Xw+3C8JeRhyRhivSrR+yldQ2aAWEm2Rp3XAB5rKFr67dodWL/Yhw9f1YZZ9r0lLQ33pk2uR0iSwxHlcZGKG4ERr1k6Z+e3jXMsHK2FaloygJSB/IOmJZBI24nMmxIPqUvb7AVhes89OyuDNHKKsFwQ8bj+jGmqQTQm1knvk5dK4MDpG6sCraOdJ2dibMFeeRe0V/G2Q595Ylca5d9gXhfp610FN8sYjd8SYUnZbVHznyKxPlpvXjXXQ7dYsP75oZo9vG7vkCfpVuSeB0Y2pEloR1hIOD1OaSKwK3I4NefbNrOmwnMg3OZyYC0yKMl0cPGvBBjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fQJo6Rgl1nycSssmrVppAVElZlufoFN6V1/WvEEhfIM=; b=gwKbKEL+qNJtxCvI5B1jHKLWmCORLahqrKaRmezbtwBV2EjfBT2o1w75Sl/Kvva7pu1WVLZ0CFauDHuJB5PRtlylhN1nF02iEdMMZMEwNwZ4W6TeGiJqWqdqOhQ0nSpHIisVqJKxGkCgBsmDb3Nl9Td5SggpMwQW7j1BJpSJ1VY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SN4PR13MB5661.namprd13.prod.outlook.com (2603:10b6:806:21c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Tue, 21 Feb 2023 05:52:41 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 05:52:41 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu , louis.peens@corigine.com, stable@dpdk.org, Chaoyong He Subject: [PATCH 2/2] net/nfp: fix getting wrong RSS configuration Date: Tue, 21 Feb 2023 13:52:22 +0800 Message-Id: <20230221055222.38289-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221055222.38289-1-chaoyong.he@corigine.com> References: <20230221055222.38289-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR05CA0084.namprd05.prod.outlook.com (2603:10b6:a03:e0::25) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SN4PR13MB5661:EE_ X-MS-Office365-Filtering-Correlation-Id: a28f79c0-992c-471c-d894-08db13cfd811 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8xpu2L+RQrRpsOkcENs9YcKBYY9lECkppOv1I6PEacnpQBkZWnJDzyWD9M+/3952soh2Ju8R9Kwt64GcmbuJbi3uTOiFDKo8VGzAUGIShMZA/pYkydoQoPXwWnQojQd9f/itSsA8up35U16JG3XxoiYNLI2XDDBhFgdY7gRWvFJD1b3xRj7hOk6ezZpO2mDqwCxWwxWCVXgzr1wD42Rf/f4JKPI5knASetmENhhru0GqhsI/aMZtASMrXOAfaZ+SRO66oFT/6lpuZys/PIZvtyT+4x95mOaALGy7nnlVnAXf+GPPJzWJTgP48PPph4WBqCr6vehDbP0lfo4LzgA7XMUIPQnMnYnawNosUtSOJ+sSMG6FQYOhk33v9ouUnMoqQPoDuZ1rCWD33BxuypIKYU1xy+BSiazMnuc0wN8EM9RNIjGeapH/b9yO5QFF62IoIvT2pMVB1jcdC5LFZNYXAXp5ES/oXY046WHHu0gc/WqaSpQ8sd72Mh7mA1hBjeuAn6SfJLkUd+74RdWhqBi/+/UpTvFxjY3PtZonUFEHD5a+LzZZ0c3A0haZqwykf3kBklE4+fnKgbNc44MfOOnY8fDXg1atb1FPOxR1F/S78HhIjuVv+B8R7lj0MoQsJChZUDmGBQio/KhIoFYQei3DmC1t70rO6JZhnHXezmBmDVk5ixTWzh8SclXESh7i7voijDOKni/PriDx5g7xQswz4OeuOXG1IldgkuFKk/3w+Ib2KjCpmbw7eugpS1gcBy7F X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39840400004)(376002)(346002)(396003)(136003)(366004)(451199018)(5660300002)(8936002)(44832011)(4326008)(450100002)(6916009)(8676002)(2906002)(66556008)(66946007)(66476007)(316002)(54906003)(6486002)(478600001)(107886003)(52116002)(6666004)(1076003)(186003)(6512007)(26005)(41300700001)(6506007)(86362001)(36756003)(2616005)(83380400001)(38350700002)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTNFcGNkSHNVUmJWeXlTYXkzZWRxaVNtbG9IZnJzcUhiSlJaSzlrRXkrYWE0?= =?utf-8?B?a093bnh3UnlEQ0tjaW51VWZsQkNBZVQ5MDhGMmxKL2Y0a3dVUVRMUGVQVk5j?= =?utf-8?B?Ykh2cGx0MStkMU5VV3JoQWNEMThqT1ZmL3hucWFjdzBLOVhXZkdmR2NQbUJV?= =?utf-8?B?Wnpzblo4RHEvNmNwZlZlbHZDSjcxTWtjeG80MUVzaXVQUVVBdHladG9sNFRh?= =?utf-8?B?YWx2NTJPMlBaN3d5dkFoUlNUaDlwbDgrcXc2UTFhbTlQSC93OVQ4dFBFOWwy?= =?utf-8?B?UnVaN1BuT000cU5Tdmt3ODc1L1RGd04rQlBhOUtIUDNaQVF3bWZYVlFpbENV?= =?utf-8?B?ZXYzQTVlK3h6UDRBVGtVeDdnTUFkNVM3Wm9tMjJWVU02eTlhSE9wNWpIL1Aw?= =?utf-8?B?dm5YUklXWGtlNnovSXpoMmEyTSttMHF1VDIvN1RObmRVeDAvODVQOEtMckRv?= =?utf-8?B?cjNwNUkvcDV3SmZXYkJxcWFKZDdpeVJDNXVlQ1RoMzdTeGRJOWY3M2dTYWcz?= =?utf-8?B?bTZ3T0xLNFYyUFc2dTU3WWFIRWxaVHd6emp5SzExdWVCOFpCalV0NWVmUkNv?= =?utf-8?B?ekVSdy94TG5zeFlSNjlYdklBbW9CdEFTcmVLQUxRaUtxbndaVGMxSkI5LzZj?= =?utf-8?B?S1l3ekhsWUc4SUVQazFyMlR3VEVHdU9OWmpGNjY4ZWRpaUYraHVCTytpTGxO?= =?utf-8?B?SjJaeWhabDc5enhMYk9VQ3RSaVdOM2tQYW45NDZuWUY5aW9iSUxxT3FkUnVl?= =?utf-8?B?ekJUMENid01td3Z3a2tyUW0xamdxWEwzZHRiSmhhTG56ZWREMXM3RER2cXo5?= =?utf-8?B?WjNVdmFrbm8xWVlLZzhoK1dGU1F1THZWVlhVSEN4V29nMGxDSWVSRTRDZkFH?= =?utf-8?B?MkhRVCt2aDRyZ0p3bVMycW44WkhOTjAvWkZHVHlGajZVRlVOZ0cxL1JueEZs?= =?utf-8?B?dzlHR3J6aGoyeGM5b1J2NXN1eDFBSUN5REV6Ym9uQWE4azF5dXhEN1dUV0VI?= =?utf-8?B?WE9SMTIwVEFlTmRVcmovOTFkUmdYbmwyRW9xVWxCbERKK1NOZ0J4dnlMM3Fv?= =?utf-8?B?WmlqNURPcnppa1I5aWFXZ2gyc2pmMmU2eUE0eHFXUzBNSDFtK2d4TG5DOHJD?= =?utf-8?B?MlFMY1huVysxbmtnTUw0SlVtZXZQWlpqeEZIUEhHRnJkYU11MzBjeTQ2OVZ6?= =?utf-8?B?dTFiUm5jMC9JZ25XcU9QVGMyVWZkTTlTckZ2N2RoV05HRjZINXhNd2I4U1l4?= =?utf-8?B?S0tnbGdtZVJ5SCt1M1hiV2JqczhFMlNMNHdKNGNtaGJscUlIUHdVQS9RbDhJ?= =?utf-8?B?dUVJRlpOZ1B0dW0xVlBqcnJHZTBrUWJFSVU1K2dIampzb3pZbWVHZVpxUktW?= =?utf-8?B?QmJRNzZid2ZoWVNobERjWUQ5UFJaTzdPVDh1dWYrL1ZWWEJsMnVaQytOYUwz?= =?utf-8?B?UmxvMVRmSGFjK21OVEU5bk8xeEJoYzRzZ1JLdkhsNlcrQ1NNWXZzOU9XcDhM?= =?utf-8?B?RFZFdUs5UGZuc2RPcCtWazJyWGpvOUNXZFR0NmFWZytQcVh6OEdJSFFNTWZ4?= =?utf-8?B?R3dRVVJYVzhFRG80K0JoSmJMTy9vd2dlMWNSMi9qUEt2ZzZveDk0NU9oNXR0?= =?utf-8?B?R1kwbTR4ZkN0eDNFR0xzKy8rWmp6NGJrWmdDaHFFdGVobVNPNXFpS2lhTmNR?= =?utf-8?B?SHJ1dk1ZK0lzWUVpZkpDOGh5TzByZ0QzQ1E4NWEveWU3NjlhUW5WUGlIUGh1?= =?utf-8?B?RXp5eUZDc2N2MG5nYnNSTTRYTWswWXhhUWpEdFRQY0NzMTFwUWdrUVZDOTI2?= =?utf-8?B?R092VGd0MXNpNWwwbUxrQU5TelF3N1ZiN3VVek5pU3lkcCtzbUQ0TkNRdEZr?= =?utf-8?B?QUtjWjVpVlVCYy9JMXJ4Y0pBbXpURWZ3VGo0Ykc3UnZSTEEwcnlXSDlXMTgw?= =?utf-8?B?V1ozdkg4N2dlRmRsVXFXTFhrN3E0NmxYek1mVGN0ZkFPK05kZG05Qm1JdVFO?= =?utf-8?B?d1VDU0tqcWl0cW5tREo3MGlIajNtYTVyWjVIN3Q1S2J3UGRNczRha0dHejd1?= =?utf-8?B?dkRQSmxndkN0UStyNkZGR2lLMUllVXBDUS9zTDduOWRKdFFVaUwwamg3cmJx?= =?utf-8?B?Y3M0Q3lCbm9qQjNGdFNpbHFnWU0zV0tsaUdQWmRUQ1NkOHZWdW4xMHJuMW12?= =?utf-8?B?enc9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: a28f79c0-992c-471c-d894-08db13cfd811 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 05:52:41.1169 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e2ad2NNyQ+glV5ChokYnHvBFOa6djoqdazML5pRa/3VXECO5ocoAGGrEUJvIyMRM2eL0jFJlgY0iOBIe6+O0ZhMeDsqDJnlgtBLBHdYAec0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5661 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu "NFP_NET_CFG_RSS_IPV4" and "NFP_NET_CFG_RSS_IPV6" represent that firmware will calculate RSS base on l3 rather than udp or tcp information from packets. So the logic of return RSS configuration in driver is wrong. Modify code to return the right configuration. Fixes: 934e4c60fbff ("nfp: add RSS") Cc: louis.peens@corigine.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c index cfc38db65a..a025c67e3b 100644 --- a/drivers/net/nfp/nfp_common.c +++ b/drivers/net/nfp/nfp_common.c @@ -1420,7 +1420,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, cfg_rss_ctrl = nn_cfg_readl(hw, NFP_NET_CFG_RSS_CTRL); if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4) - rss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_TCP | RTE_ETH_RSS_NONFRAG_IPV4_UDP; + rss_hf |= RTE_ETH_RSS_IPV4; if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4_TCP) rss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_TCP; @@ -1435,7 +1435,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, rss_hf |= RTE_ETH_RSS_NONFRAG_IPV6_UDP; if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV6) - rss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_UDP | RTE_ETH_RSS_NONFRAG_IPV6_UDP; + rss_hf |= RTE_ETH_RSS_IPV6; if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4_SCTP) rss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_SCTP; -- 2.29.3