From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D256641D31; Tue, 21 Feb 2023 18:07:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C344743210; Tue, 21 Feb 2023 18:07:39 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id A3CA540E0F for ; Tue, 21 Feb 2023 18:07:38 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id g12so2920512pfi.0 for ; Tue, 21 Feb 2023 09:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=e4jzEIW0yhJD+Nd2bs5P6+Jbdo6ARszOf1iVFLdgGh0=; b=55u7276ubJdjdPNvIVxwyM0PluI9UYstXcTJj6X0FwbijpPofxPxXO0Xx/d3Tgbufn petmX1mOtm4ODI7pqnc8dupw3MKli01JJy+IXil9uU9ExKgfro0z09U+hiH9F44k5k43 eMl3kGRHf5Q+eKJFWWCOwpnOXkLuuCyHo2Ff7U67y5xyQIhgDdZAQ4UhdMJCtpQx8hqO weBZuyW5BnzVfudR7zipZw4wSCdzW9SPEkAVPmPynFbwYNOeWJLePlkb/7Ntg70Ecd6R om8Md9JRs0kB3dANyncsaNPAm9kqVMxUuJXs+dTuaylvhoCYDDfD6W51n7fsgPopjTsa Kr4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e4jzEIW0yhJD+Nd2bs5P6+Jbdo6ARszOf1iVFLdgGh0=; b=CJFnZvo1CFSUfM+Vsc6jCSp+eAPgkh9A4EfHfVKCM1UwFkaRQsugkUBQDU7brzvQbV IE1pwgSxaGLTPp3th30GWZHeki3QTqKyRDI7f7/sJ7BknZVXpXleqMKO8dhsU96HWREH rEDrvEC+kraUseeXL86z7KI22JYQXt8Yv+goHIEl1wr1yxOFxYAbJln9qRomhXkSlZ84 xeu3L+hlr84EzHGB4Sw1mXdjwfA/OVgvUNjk04gz5H5DPFpwNgWTjPvt0Ov+J13Tkl1k 6V/gl/FCCKOoKcBWfnRmC4igfuUaGYVv7FHI8YqRp50zQr/ACgg/qqp+PUv1EdS2nhOH aa7w== X-Gm-Message-State: AO0yUKUtQx8q4t86KwT/o/ou0DvClwf0BNMN6UdHPvkLE8h+5GJ3Haje Ps5eBym8msPd8AaZrox9+2F9r5K0l+UYhxTK/Ag= X-Google-Smtp-Source: AK7set9XyMXEwRO5mtQi+JIvbeWHUgCnWVxbLe9wC9E7hkYgEFWGobEv8rBXrK/pqEFZyrEbhE66KA== X-Received: by 2002:a62:1952:0:b0:5a8:4b70:885f with SMTP id 79-20020a621952000000b005a84b70885fmr5530184pfz.18.1676999257812; Tue, 21 Feb 2023 09:07:37 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j2-20020aa79282000000b00593906a8843sm2127013pfa.176.2023.02.21.09.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 09:07:37 -0800 (PST) Date: Tue, 21 Feb 2023 09:07:35 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH v8 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type Message-ID: <20230221090735.0ca0c050@hermes.local> In-Reply-To: References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230220233556.168553-1-stephen@networkplumber.org> <20230220233556.168553-5-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 Feb 2023 15:55:29 +0100 David Marchand wrote: > On Tue, Feb 21, 2023 at 12:36 AM Stephen Hemminger > wrote: > > > > Replace all uses of the global logtype with a dynamic log type. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/eal/common/eal_common_log.c | 1 - > > lib/eal/include/rte_log.h | 2 +- > > lib/efd/rte_efd.c | 4 ++++ > > 3 files changed, 5 insertions(+), 2 deletions(-) > > [snip] > > > diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c > > index 686a13775742..9edb11799c89 100644 > > --- a/lib/efd/rte_efd.c > > +++ b/lib/efd/rte_efd.c > > @@ -9,6 +9,7 @@ > > #include > > #include > > > > +#include > > #include > > #include > > #include > > This is unrelated, isn't it? Not really, the old code worked only because it would get rte_cpuflags.h included via rte_hash_crc.h. When rte_hash_crc.h was fixed to not do per-cpu setup in inline, then the cpu flags did not need to be included there.