From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1444F41CFC; Tue, 21 Feb 2023 11:36:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6CA5431DA; Tue, 21 Feb 2023 11:35:44 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2111.outbound.protection.outlook.com [40.107.243.111]) by mails.dpdk.org (Postfix) with ESMTP id 6933B431C2; Tue, 21 Feb 2023 11:35:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lq+xO0PGXGd5f+eYA5sio4qcQ3MxrOvvg8/Z3d70JGgwyv6fF+VwB92RzIeU12m8qJSB11L8gMpHvc0KkamKXpOcC8VDnv4DNZR4I27nTaWxqJ6xQSUiRgAUoVm/MNdrwiyIWCVJyVoht7MInR5UeLsmh5g0bMXIgKLizERK9iZJ7DGUvxo4pFLbcOV2+3CKATAaGJFzYOXUMg0ROpzPvsf0bYc5DsXon6Nq/k4wIX2x6NI0H/lDwI7y3hLxZsqWrc6QUkmulMdPL0aQTgRGmnC2UDTaB2jdOXpUsEbtG1wL41Z/W/pqq9RCpRnl8TB5MejC7T0b79/8vLS+mNgtSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/jgaCiGD9TWzWEhGdO5TqaxXplruiQmbK3qr6S1w4oo=; b=WMB0AZNaBihhd9mQCAhXgHrgiYFWKHFP4yVBb/QrFjioe4Bq4dZA9siLl8L9yfIHCCd5r48w83Anq5mDMG84xgjQoK/GBjvNPRCIra22nC/RfbVi+xNVxCuZyKfY8/OtlaJGafxm2VAVWnzRVu6/6U9JG+/ABEcCMow+aDzzsjYLqrqwAUwRdBr13oRlPDks/I6LboWYe7x/OhBrYKQLf7WgorMtMOPgNSu8aqIQ1t92CpGxJt7bv0/yMUuebO3oNtjVYxAR4Dy+uLg62CtPXsT9+1TysUICoxolv+Qh9fki06+qM8pfN4YwkTZuVmwcYtTIcvHxziui4OjMWFrCuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/jgaCiGD9TWzWEhGdO5TqaxXplruiQmbK3qr6S1w4oo=; b=RuE57VWMAQNTdMzlweh0QtjmxDP4EKAGPFqy4ObJuIMi71C0bXu9ceNhXC4jwVd2WcVLp3G8nv76GltSYM/3HebOt2T37mWTHkayus9X1ACJJyZiXvBlP/9hSE0fX26QRODojWktsu/oyEFm7KBk+2i/7vhzob1HZW2kx7PeVZg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5616.namprd13.prod.outlook.com (2603:10b6:510:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:35:40 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:35:40 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2 4/6] net/nfp: fix the set TP flow action Date: Tue, 21 Feb 2023 18:35:11 +0800 Message-Id: <20230221103513.412-5-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221103513.412-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> <20230221103513.412-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2P153CA0038.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: 84d13bb9-6b76-4398-e487-08db13f76031 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ODSZ9j/M24d8/iM/CvrKHz1dmwgxjJgUPVNs6zGCfg1x/HVQkHg7fltJJTvkvbuaXgIfDF6jYsLA+7NQtuQ/lsuRNaBv9BLXNL14WDitE/BB1hETu7Tz5Tffi/r/etcAxozr67vbe2y+ixDyPvVw+dtRqo8XSLYzgGe+MPR5yJPtyF+ZB0/6GCYaHjE59ot6GGLFSqkNUjLGONDAgkEvvrG0ZWEeLSDbhS59VlfVN7a0cvqVkvxlZ3c49/mlZaAxCcXuaplyE4Cf726SdIEsTsVZKwDq+XaVjUwL+7/KB0bS/f+WSUvUN18KQhxxgLuG3Bp6fTeiWql7eJfJZszHT1N12yfM9+ktTol3fWvPSttSd+i1xxc/Twj78U0BUfGLDWbKALGCQBqp2v0j+Qh0YGqhKmpvuC5Barw+aLZUu4t5t1DY3fBBO5hi9IFO0rJPocTsux1q93lEYvIGGfCzVuMT8G1S5ncmrBC8W33IeLHz7i7z/YA1wqPkO9Brc0p6jDou43zj+szWVyH67lViiOkA0JdBUVyUZqHxQHkqZnaIWK5iebiPaFWnGO17B2kF5HLQfte1wRmfxucbU47QRuzBlHYcYTOUhhMt2/v8QD2iWrSUaNro4x77MCSsEbLVX9ANTevt24U5RlYAcuQUzN6oMCzITXgoPXK+fqMx/6m+IwqGfMwvArdnrYDUHqO2T/rgM2/YqmIJK4izkVGM9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39840400004)(136003)(451199018)(83380400001)(450100002)(66476007)(66556008)(26005)(8676002)(66946007)(478600001)(316002)(4326008)(6916009)(6506007)(6666004)(6512007)(186003)(1076003)(36756003)(38100700002)(38350700002)(86362001)(6486002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(52116002)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjRtK0FJa2JQTUs4clEydG5DMkkxbncrRUhBWHFZR1lWZDVtVngrZXVzQnJM?= =?utf-8?B?ZS81azhIU2h4UkVTeFpTais2K2tNMmlSb2cxY2dybUc3WGgvMisxTUlOblRn?= =?utf-8?B?TlBVWSt0a056UEIrekxTMThuTjc0OXRHa0hhOUJabmdUbyt5cjZvVWpuMTFz?= =?utf-8?B?Q0ZIRGN2TEtrSGp1U2t6dWJQVUNwdWJiRDNlemk2Y1NnM0hkL2gvVnJpbGYw?= =?utf-8?B?a3pIQXc5Z3U4Ty9NZ2t3ek0wbVlNQmZ2NFBMd2xuV3g0c082YWUrdHhabFAv?= =?utf-8?B?UWJzdzUvY3lVNlZNQ0lWWmpLWSs1VmJ4VjNlbmtsN2lKQnFOTHFUcWR5WmlJ?= =?utf-8?B?WDZ2dzdHTEFFNWk1V2JXSXY0VENuMEtBYjBHZUkvK0NHL2hmZURHcjFyM1Uz?= =?utf-8?B?ZkFaM3lrbG9XWno1MWVueGpFVThYSnRQd3ZyaUZ6Zk1lRnRYSVBadWgvTlRS?= =?utf-8?B?WU1MSWdFR0xaa3JWZTFmMXdPQjZ5S3VJaW5nT2tVVTdmZUVjNjBiSzB0dXRi?= =?utf-8?B?NUtGM0wyemc5Z1ZpZTYxMTZ2L29nNHJ6ZHlITnFqT3gxblV2aXhwQnhKUUZl?= =?utf-8?B?cVhabGhxT1FpY21NeUtxVWgxRkJWa01NeFZoTTZwZXJwV0h4c1VOSW90K3du?= =?utf-8?B?dnlTQlBZRTIvN2ovbElPUGJvbU9rS3hKMTFEVzFoV3p6QWw1L2VUczlLMVVa?= =?utf-8?B?VGhNVndmMVR1cklBb2VjQWNPRUNoNmJxbFRpM0V4cjRvYjdrRmlKZHk4c1Bq?= =?utf-8?B?WWw4M1NOOWxYWkppVHNJT1VvdDR0OUVOM0FkdFdnM1JMQXpWclBraDdRVkR3?= =?utf-8?B?WXcwN3FTek81T2phbWNFaGxEWGJrWFpaVUcwYzlIM01DUFlvOXFNT3poazV5?= =?utf-8?B?bnF0dlhRN0RZOUJxck9CTzYxR2ZBaXdsUzdna3hHS3Z6UTdBRkFpRnFlL3RL?= =?utf-8?B?enpYYWJ3c1oxbE91dWpJVjIwdWR6MHdkbWlxQS9pRHlJNDJiTWVpQllaVktY?= =?utf-8?B?dzlLVUlERjBZaEFjNVlOZ0tzV0Z0VU1QdHltVEFrYlhGUXZ0OFQzMHpMcEQ5?= =?utf-8?B?aFpDZEhVdUwvdGJPU2Y1RFpJZDl4UEViTEZDMzFBTTZObXYvZE83YlNoZDEv?= =?utf-8?B?OXBXejNXUjBEaFJzcTRwZVNqd3UzejNjSEQrVU43eGZDbVVBb0NoU21oTjdY?= =?utf-8?B?M3RZQm1Bajl2d1RXUHNVbXUwV0NwNEh0Zko2aklLQXdjSkZhZDdOU2JvTXRU?= =?utf-8?B?K0podjkzd29laWsyd2NvL3hhYTQ1Z2Qrb3Z5RGg4REhXYWFXY1hmZzFaVXlh?= =?utf-8?B?eE9LeFNXT1VSeURudUFWN2J1eHcvc3F4blgrRHdYWVUzMFgydTZBcmJkUVZa?= =?utf-8?B?U3JiRG5tQy9Jb3hUb1lpdmhpWUxMZmlFYXM1ckZoUmduY09SMy9ON1Yra2Ni?= =?utf-8?B?RVdMbFZsTGQzQjljTy9LaEZPT0NnayswMHRVOWVFQUdEd2N3bzB0ck03YXFW?= =?utf-8?B?ZEdlMUlXK0xQUzFIazJQRVV2ajF2b01rZm5vdXQrUXlsdXJjYUc3d2c1cVNz?= =?utf-8?B?Rk5WWlFFTjhNdWxEcmhaNzFjdTJ4Q3J5STZXSXByU3NUbktZWUFPQ2hLbnhL?= =?utf-8?B?RWtUTEM2eXF1WlhyaXc5aDJ4bDh5d3BHZGJUQUNVZXNZWjFSOHZsMHlhRm1Y?= =?utf-8?B?MmtrT3dUbEJBNENnRXZFQlN2cjVvSklUNEFvdEVCTW9Qa2VGMnVhdlVtZSsw?= =?utf-8?B?Mk03eE9FTkU0Q3pMZWFqU3BuNnJZT3o0YncybGV1OXBnMHRkYU05ZFowM0d6?= =?utf-8?B?NjVka09QbEduYlhVeTFWemc5dzVOR2JQZXN2Sm1hT2VUY3NRZmNCbjhsRi9j?= =?utf-8?B?QVBSNTZjRWsrNWxibk5xVTcrQXcrS1Jhc2E1ejRwbEtzZG03eGhIODQ0NXNP?= =?utf-8?B?TnAzQytmZG1wVm5wMWIxUkF0UU5MTVJPMDNLcUNVdXczVWpRak5IUzFSNVFR?= =?utf-8?B?cFZRSXpoNnpJdlFiV3BQMFhVSzBESmFPeUxoYVAvVDRZU202VFByWmZvN2lV?= =?utf-8?B?ZmZIQ0Vpc1E3a2J6cGJPQXR1cjJ1L29jcENTa2p6NzVXdHY0YTNtUXFWRzVz?= =?utf-8?B?VmZrTjlDNWdPSWhrTWFRSHg3WmNhRHlyVWwrdXgyTHRocU45YkVCbGoxWjd3?= =?utf-8?B?WkE9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84d13bb9-6b76-4398-e487-08db13f76031 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:35:39.9007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yp6IOX9Hn+AINULhKPhHG1osslYaf0W0cMbj5imTKY03cHqTaLVGxtaoco3P+BjNNMVn86xEpXAYb9BcebBwtEX/KQqZZhZx2Wf2zcvylpY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5616 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set TP source/destination flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right TP as expected. Fixes: fc185097bbe6 ("net/nfp: support TP source flow action") Fixes: 87986df09d75 ("net/nfp: support TP destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index d1fe744758..5be4c4f18a 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2190,10 +2190,13 @@ nfp_flow_action_set_tp(char *act_data, set_tp->reserved = 0; set_tp_conf = (const struct rte_flow_action_set_tp *)action->conf; - if (tp_src_flag) + if (tp_src_flag) { set_tp->src_port = set_tp_conf->port; - else + set_tp->src_port_mask = RTE_BE16(0xffff); + } else { set_tp->dst_port = set_tp_conf->port; + set_tp->dst_port_mask = RTE_BE16(0xffff); + } } static int -- 2.29.3