From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21E6641D31; Tue, 21 Feb 2023 19:46:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A34240C35; Tue, 21 Feb 2023 19:46:55 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 1CB9940A7A for ; Tue, 21 Feb 2023 19:46:54 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id qi12-20020a17090b274c00b002341621377cso5826537pjb.2 for ; Tue, 21 Feb 2023 10:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ByjHsCXgRqI3JzSihTdjzGlJDTAr7epdzxTVUoDxGZw=; b=JSQipS9/lDIr7fFhUcp6bVh1cTNjdVEH1MFaJ76UV/USpj+0q4g+i8yPnY8UQb4aqE 2Luv/Cn6xlYmF8lD/RrMQIryiuJSPz2yKrP6oDs1ebBAtEinC6wLyT/pp3CS1JJdrDE3 zZXrYfdzVne0BiHC0EvyUUmV5cJMKdggtoJcswaNUc2NfUl838N1XGakW163tv6eYGhO Hk5ULso7kwJaYFps8nOFfb1NO9qLNz+4MvDUIx7neTtRZoLmr2QugrrOJcYJyQRasm7g yiOFOnj/xqOJeiaYwrrbmf90LQpopW+nzduhcXL5miamWAROY15yd4xY2LIlApPCssXC Dqxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ByjHsCXgRqI3JzSihTdjzGlJDTAr7epdzxTVUoDxGZw=; b=CNGpOkpjnvDjdDrHFAyEfSHpcn//S7GNqm4SVw0cLgbAOxXfoGY++p1xxmTfbky7I2 Tk2QEsXNwB2dYK++DajHQU40MXXCrfBtVeuU4WCeN5WlB2+Pq91QzdviwQiJdcg1xoAh dLb4YgeeonjLOa9A0ZZjzLXbWKIhytUOvTSuMsyqdnHfric10usF4RMSYUQILjOD85Ue /pg3QwvLIDf+157useVdLJPZcrogWsD8EMcHW6SjY8++1oh+4o7JTkKtbTurMdwDKnu0 GQ1Mf26dtZVColtH3c+JLmSlOITdnoF11scmS2cuLAzKlkwzGrXrQWjo4os6HDmJ2ctM hTjw== X-Gm-Message-State: AO0yUKW8cntmx6iCrqwS2Bb/zlWYKDrfddsIOOp/k1ZUDgvSukA4tqIu jt8JaJCTMz1/xQPDunUAcz7jnw== X-Google-Smtp-Source: AK7set+SuacCrZOH9w9Gkwnrp1GMCev7vlaYsLNvT2TaXo39hX6QwWdyDAA8qHeHyowOkLMDOnbV8Q== X-Received: by 2002:a17:903:803:b0:19a:a404:af47 with SMTP id kr3-20020a170903080300b0019aa404af47mr5858442plb.4.1677005213171; Tue, 21 Feb 2023 10:46:53 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id p9-20020a1709026b8900b00186b7443082sm2687167plk.195.2023.02.21.10.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 10:46:52 -0800 (PST) Date: Tue, 21 Feb 2023 10:46:51 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH v6 0/5] Replace use of RTE_LOGTYPE_USER1 in libraries Message-ID: <20230221104651.5b890716@hermes.local> In-Reply-To: References: <20230208044825.1682620-1-stephen@networkplumber.org> <20230220185001.50714-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 Feb 2023 11:42:45 +0100 David Marchand wrote: > On Mon, Feb 20, 2023 at 7:50 PM Stephen Hemminger > wrote: > > > > The DPDK libraries and drivers should not be using the USER1 logtype. > > > > v6 - fix checkpatch warnings > > > > Stephen Hemminger (5): > > ip_frag: use a dynamic logtype > > reorder: use a dynamic logtype > > latencystats: use dynamic logtype > > vhost: use logtype instead of RTE_LOGTYPE_USER1 > > ipsec: fix usage of RTE_LOGTYPE_USER1 > > > > drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++- > > lib/ip_frag/ip_frag_common.h | 5 ++++- > > lib/ip_frag/rte_ip_frag_common.c | 2 ++ > > lib/latencystats/rte_latencystats.c | 3 ++- > > lib/reorder/rte_reorder.c | 6 +++--- > > lib/vhost/fd_man.c | 4 ++-- > > lib/vhost/vhost_crypto.c | 4 ++++ > > 7 files changed, 19 insertions(+), 8 deletions(-) > > Could you update the power library too? > > lib/power/guest_channel.c:#define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1 I picked that up in the other patch set because lib/power should be using its own logtype.