From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 543FD41D32; Tue, 21 Feb 2023 20:02:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4689240A7A; Tue, 21 Feb 2023 20:02:13 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id E659640691 for ; Tue, 21 Feb 2023 20:02:11 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id ky4so7322862plb.3 for ; Tue, 21 Feb 2023 11:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i3m9lcg81eYvWggsJrnguR87qniJA30wFzht4GFcMfk=; b=79aQuozUKhUbWw3gjqYY+hn9UNnb/RkzUrQ7SSHd371eECyZhtjRFGVofkzbe4jzv4 o7YqIipNtcAdbDbOAEXK3etGgjzH+G+HKnXAna1EXbTd58e1Y8X/oMUD+X+v1ANKmwIr zJEp9B+zr/t5EpGPdrHU3KFxz7Q73YrcnQvfHcCNDlX37iW376dYVr8YZMQlTR+bf2Iy Z5kiN+XxcIMfhLPYoDI3Dg3D9K1xdvuBnxrLp+EYzuF1orcCrS6YfgnLZpD80XJPU5tB HPzw4a2m3l7Q2w6SYtzplorCGueP2bbSC3ixHPxOxFfRTAGiwGTZGLpH7ABilY30Fank qG0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i3m9lcg81eYvWggsJrnguR87qniJA30wFzht4GFcMfk=; b=j1YqqnURBPwTufk15terNzyhJtGIFnCxLlYEovhDM24d3qJk+2yDJUsPdCS7yK0phL kVtMSAcQWznP9d3toyrgCe1SnQG7A9X66t3OEQfpaMHNkno9SlB1ukz2fKi6gf4Je9eX dMcjDYdor5JGkCM6MQC/DQ9yGuyozPl4fuqPerURQGRRw2zc0/JBn9ApjC2FOL6us/3L AidQnWznHd0UmXec5Q6OM1oO2O/XpNsToFpv0S+dE768N2QW64Sub8c/1TL38kv8cUpW KbOppZVOqQNqlqMmtsr40/sRufPJsFr074e3FdEAg/jRzyiqFhu3EF9bMTAmfHLjVrwJ zkag== X-Gm-Message-State: AO0yUKXcMX2skEeL/w+Tb1M7/P7O8dJtFkJs4vL4gugUNrrrM7jKPxGc 3L4LNfmwqZ4lJlFFx9ThL7VI2BZSm6duS68sMzs= X-Google-Smtp-Source: AK7set+JFSU/gUNvYCD3qVocJ/+R1DZTWK01q2bP1Hlob0dW7jlFzfWP0Tup//kin3Nm8eXhFTVeMA== X-Received: by 2002:a17:903:11cf:b0:19a:b32e:cbb with SMTP id q15-20020a17090311cf00b0019ab32e0cbbmr5815482plh.11.1677006130788; Tue, 21 Feb 2023 11:02:10 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id jc4-20020a17090325c400b001991e59fde6sm10213018plb.216.2023.02.21.11.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 11:02:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v9 00/22] Convert static logtypes in libraries Date: Tue, 21 Feb 2023 11:01:46 -0800 Message-Id: <20230221190208.514276-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230207204151.1503491-1-stephen@networkplumber.org> References: <20230207204151.1503491-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since there is no guarantee in current DPDK policies that says they can't be removed. Note: there is one patch in this series that will get flagged incorrectly as an ABI change. v9 - fix handling of crc32 alg in lib/hash. make it an internal global variable. fix gfni stubs for case where they are not used. Stephen Hemminger (22): gso: don't log message on non TCP/UDP eal: drop no longer used GSO logtype log: drop unused RTE_LOGTYPE_TIMER efd: replace RTE_LOGTYPE_EFD with dynamic type mbuf: replace RTE_LOGTYPE_MBUF with dynamic type acl: replace LOGTYPE_ACL with dynamic type examples/power: replace use of RTE_LOGTYPE_POWER examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER power: replace RTE_LOGTYPE_POWER with dynamic type ring: replace RTE_LOGTYPE_RING with dynamic type mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type lpm: replace RTE_LOGTYPE_LPM with dynamic types kni: replace RTE_LOGTYPE_KNI with dynamic type sched: replace RTE_LOGTYPE_SCHED with dynamic type examples/ipsecgw: replace RTE_LOGTYPE_PORT port: replace RTE_LOGTYPE_PORT with dynamic type table: convert RTE_LOGTYPE_TABLE to dynamic logtype app/test: remove use of RTE_LOGTYPE_PIPELINE pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic type hash: move rte_thash_gfni stubs out of header file hash: move rte_hash_set_alg out header hash: convert RTE_LOGTYPE_HASH to dynamic type app/test/test_acl.c | 3 +- app/test/test_table_acl.c | 50 +++++++++++------------ app/test/test_table_pipeline.c | 40 +++++++++--------- examples/distributor/main.c | 2 +- examples/ipsec-secgw/sa.c | 6 +-- examples/l3fwd-power/main.c | 15 +++---- lib/acl/acl_bld.c | 1 + lib/acl/acl_gen.c | 1 + lib/acl/acl_log.h | 4 ++ lib/acl/rte_acl.c | 4 ++ lib/acl/tb_mem.c | 3 +- lib/eal/common/eal_common_log.c | 17 -------- lib/eal/include/rte_log.h | 34 ++++++++-------- lib/efd/rte_efd.c | 4 ++ lib/fib/fib_log.h | 4 ++ lib/fib/rte_fib.c | 3 ++ lib/fib/rte_fib6.c | 2 + lib/gso/rte_gso.c | 5 +-- lib/gso/rte_gso.h | 1 + lib/hash/meson.build | 9 +++- lib/hash/rte_crc_arm64.h | 8 ++-- lib/hash/rte_crc_x86.h | 10 ++--- lib/hash/rte_cuckoo_hash.c | 5 +++ lib/hash/rte_fbk_hash.c | 5 +++ lib/hash/rte_hash_crc.c | 68 +++++++++++++++++++++++++++++++ lib/hash/rte_hash_crc.h | 48 ++-------------------- lib/hash/rte_thash.c | 3 ++ lib/hash/rte_thash_gfni.c | 50 +++++++++++++++++++++++ lib/hash/rte_thash_gfni.h | 28 +++---------- lib/hash/version.map | 11 +++++ lib/kni/rte_kni.c | 3 ++ lib/lpm/lpm_log.h | 4 ++ lib/lpm/rte_lpm.c | 3 ++ lib/lpm/rte_lpm6.c | 1 + lib/mbuf/mbuf_log.h | 4 ++ lib/mbuf/rte_mbuf.c | 4 ++ lib/mbuf/rte_mbuf_dyn.c | 2 + lib/mbuf/rte_mbuf_pool_ops.c | 2 + lib/mempool/rte_mempool.c | 2 + lib/mempool/rte_mempool.h | 8 ++++ lib/mempool/version.map | 3 ++ lib/pipeline/rte_pipeline.c | 3 ++ lib/port/rte_port_ethdev.c | 3 ++ lib/port/rte_port_eventdev.c | 4 ++ lib/port/rte_port_fd.c | 3 ++ lib/port/rte_port_frag.c | 3 ++ lib/port/rte_port_kni.c | 3 ++ lib/port/rte_port_ras.c | 3 ++ lib/port/rte_port_ring.c | 3 ++ lib/port/rte_port_sched.c | 3 ++ lib/port/rte_port_source_sink.c | 3 ++ lib/port/rte_port_sym_crypto.c | 3 ++ lib/power/guest_channel.c | 3 +- lib/power/power_common.c | 2 + lib/power/power_common.h | 3 +- lib/power/power_kvm_vm.c | 1 + lib/power/rte_power.c | 1 + lib/rib/rib_log.h | 4 ++ lib/rib/rte_rib.c | 3 ++ lib/rib/rte_rib6.c | 3 ++ lib/ring/rte_ring.c | 3 ++ lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 +++ lib/sched/rte_sched_log.h | 4 ++ lib/table/rte_table_acl.c | 3 ++ lib/table/rte_table_array.c | 3 ++ lib/table/rte_table_hash_cuckoo.c | 3 ++ lib/table/rte_table_hash_ext.c | 3 ++ lib/table/rte_table_hash_key16.c | 3 ++ lib/table/rte_table_hash_key32.c | 5 ++- lib/table/rte_table_hash_key8.c | 5 ++- lib/table/rte_table_hash_lru.c | 3 ++ lib/table/rte_table_lpm.c | 3 ++ lib/table/rte_table_lpm_ipv6.c | 3 ++ lib/table/rte_table_stub.c | 3 ++ 75 files changed, 405 insertions(+), 179 deletions(-) create mode 100644 lib/acl/acl_log.h create mode 100644 lib/fib/fib_log.h create mode 100644 lib/hash/rte_hash_crc.c create mode 100644 lib/hash/rte_thash_gfni.c create mode 100644 lib/lpm/lpm_log.h create mode 100644 lib/mbuf/mbuf_log.h create mode 100644 lib/rib/rib_log.h create mode 100644 lib/sched/rte_sched_log.h -- 2.39.1