From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4642141D40; Wed, 22 Feb 2023 17:08:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2949B40693; Wed, 22 Feb 2023 17:08:06 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 8CA1440689 for ; Wed, 22 Feb 2023 17:08:05 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id m3-20020a17090ade0300b00229eec90a7fso2098510pjv.0 for ; Wed, 22 Feb 2023 08:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4nVNyATvIQ4OLzOEx3L198L2uHNDXZ9+mWW3OweYHZ8=; b=XlEvCOHXrpeAV1IQrfb2/qOnaPc8rx9P310QtCraO4PxUUctNqBbpMKEhbSOY8n6LK uO/esS7HINsk4puESZB+sGGaH00A+i1QwR0jH31sEk6kPHud+qQv0wNi0sS7OS7KiMW5 8vio9STgnNV/lk7dI7dB3VeetNeqx2k1sJaSR2A41XQNqjyFuyiaoByXos3UhOx9Id+1 05ChvlNKObB4OxkTpMu31BZ9BhfUXAXLofV/W/tiFueq/sD78pAAE+OnsbwEVqg3ijLM eJExHlkeWUPzrsOzbVmbWRle6qgj0ah2mbvq+NtlqkCVq17Ew06LNOb/w3mzq+a+WiBB IJig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4nVNyATvIQ4OLzOEx3L198L2uHNDXZ9+mWW3OweYHZ8=; b=hB1qeq3Vl2ja7L8ygq5SIDLKEKdVDECxlEPvwcd2nzCaaKyrbVWCmqz2cq/8qb/0z5 HkvS9d79+UQeXXT6LuMYszKyD1jeJkTggypzkPqYAAcFI0LNaa6R09nvXcibms65snHB stW6DOhLzFzIACYodIHJFh5x+NBdt2kQ5N3/t2b3cOncYDOze/3dvpzzIdHmbpFwQKUE cchE6xRrSh0Qkd/ON/Hh/lNcxwXLeWLgrpl+zXdItGJwRLhg+cXTKHjGTJj65ni8gJrt qKUKLvlNclzUaIL1jo/tTtoeA6Y1TnQlkWrRtaFSI6LsI9F7jI3g78F+dBhglfnAViui tIuw== X-Gm-Message-State: AO0yUKVFCfd4mTshfnQbe5mu/12C0yHXXuR3rIXR3XlM32rKtaixi2vR +p5rMIDXp8hKrnZx38pHD4bS+KoddE3DDEAewR8= X-Google-Smtp-Source: AK7set9LX5Ve0wemw0ebaEqByxYgpFLzNgLbHOr3exef55sSqsFipP9za9VCzghIEg+FyJps3foe/g== X-Received: by 2002:a05:6a20:734d:b0:c6:6fef:545c with SMTP id v13-20020a056a20734d00b000c66fef545cmr14452pzc.21.1677082084124; Wed, 22 Feb 2023 08:08:04 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x24-20020a63db58000000b004fb71d96d78sm5063778pgi.2.2023.02.22.08.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 08:08:03 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v10 00/22] Convert static log type values in libraries Date: Wed, 22 Feb 2023 08:07:40 -0800 Message-Id: <20230222160802.123611-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230207204151.1503491-1-stephen@networkplumber.org> References: <20230207204151.1503491-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since there is no guarantee in current DPDK policies that says they can't be removed. Note: there is one patch in this series that will get flagged incorrectly as an ABI change. v10 - add necessary rte_compat.h in thash_gfni stub for arm v9 - fix handling of crc32 alg in lib/hash. make it an internal global variable. fix gfni stubs for case where they are not used. Stephen Hemminger (22): gso: don't log message on non TCP/UDP eal: drop no longer used GSO logtype log: drop unused RTE_LOGTYPE_TIMER efd: replace RTE_LOGTYPE_EFD with dynamic type mbuf: replace RTE_LOGTYPE_MBUF with dynamic type acl: replace LOGTYPE_ACL with dynamic type examples/power: replace use of RTE_LOGTYPE_POWER examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER power: replace RTE_LOGTYPE_POWER with dynamic type ring: replace RTE_LOGTYPE_RING with dynamic type mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type lpm: replace RTE_LOGTYPE_LPM with dynamic types kni: replace RTE_LOGTYPE_KNI with dynamic type sched: replace RTE_LOGTYPE_SCHED with dynamic type examples/ipsecgw: replace RTE_LOGTYPE_PORT port: replace RTE_LOGTYPE_PORT with dynamic type table: convert RTE_LOGTYPE_TABLE to dynamic logtype app/test: remove use of RTE_LOGTYPE_PIPELINE pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic type hash: move rte_thash_gfni stubs out of header file hash: move rte_hash_set_alg out header hash: convert RTE_LOGTYPE_HASH to dynamic type app/test/test_acl.c | 3 +- app/test/test_table_acl.c | 50 +++++++++++------------ app/test/test_table_pipeline.c | 40 +++++++++--------- examples/distributor/main.c | 2 +- examples/ipsec-secgw/sa.c | 6 +-- examples/l3fwd-power/main.c | 15 +++---- lib/acl/acl_bld.c | 1 + lib/acl/acl_gen.c | 1 + lib/acl/acl_log.h | 4 ++ lib/acl/rte_acl.c | 4 ++ lib/acl/tb_mem.c | 3 +- lib/eal/common/eal_common_log.c | 17 -------- lib/eal/include/rte_log.h | 34 ++++++++-------- lib/efd/rte_efd.c | 4 ++ lib/fib/fib_log.h | 4 ++ lib/fib/rte_fib.c | 3 ++ lib/fib/rte_fib6.c | 2 + lib/gso/rte_gso.c | 5 +-- lib/gso/rte_gso.h | 1 + lib/hash/meson.build | 9 +++- lib/hash/rte_crc_arm64.h | 8 ++-- lib/hash/rte_crc_x86.h | 10 ++--- lib/hash/rte_cuckoo_hash.c | 5 +++ lib/hash/rte_fbk_hash.c | 5 +++ lib/hash/rte_hash_crc.c | 68 +++++++++++++++++++++++++++++++ lib/hash/rte_hash_crc.h | 48 ++-------------------- lib/hash/rte_thash.c | 3 ++ lib/hash/rte_thash_gfni.c | 50 +++++++++++++++++++++++ lib/hash/rte_thash_gfni.h | 29 +++---------- lib/hash/version.map | 11 +++++ lib/kni/rte_kni.c | 3 ++ lib/lpm/lpm_log.h | 4 ++ lib/lpm/rte_lpm.c | 3 ++ lib/lpm/rte_lpm6.c | 1 + lib/mbuf/mbuf_log.h | 4 ++ lib/mbuf/rte_mbuf.c | 4 ++ lib/mbuf/rte_mbuf_dyn.c | 2 + lib/mbuf/rte_mbuf_pool_ops.c | 2 + lib/mempool/rte_mempool.c | 2 + lib/mempool/rte_mempool.h | 8 ++++ lib/mempool/version.map | 3 ++ lib/pipeline/rte_pipeline.c | 3 ++ lib/port/rte_port_ethdev.c | 3 ++ lib/port/rte_port_eventdev.c | 4 ++ lib/port/rte_port_fd.c | 3 ++ lib/port/rte_port_frag.c | 3 ++ lib/port/rte_port_kni.c | 3 ++ lib/port/rte_port_ras.c | 3 ++ lib/port/rte_port_ring.c | 3 ++ lib/port/rte_port_sched.c | 3 ++ lib/port/rte_port_source_sink.c | 3 ++ lib/port/rte_port_sym_crypto.c | 3 ++ lib/power/guest_channel.c | 3 +- lib/power/power_common.c | 2 + lib/power/power_common.h | 3 +- lib/power/power_kvm_vm.c | 1 + lib/power/rte_power.c | 1 + lib/rib/rib_log.h | 4 ++ lib/rib/rte_rib.c | 3 ++ lib/rib/rte_rib6.c | 3 ++ lib/ring/rte_ring.c | 3 ++ lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 +++ lib/sched/rte_sched_log.h | 4 ++ lib/table/rte_table_acl.c | 3 ++ lib/table/rte_table_array.c | 3 ++ lib/table/rte_table_hash_cuckoo.c | 3 ++ lib/table/rte_table_hash_ext.c | 3 ++ lib/table/rte_table_hash_key16.c | 3 ++ lib/table/rte_table_hash_key32.c | 5 ++- lib/table/rte_table_hash_key8.c | 5 ++- lib/table/rte_table_hash_lru.c | 3 ++ lib/table/rte_table_lpm.c | 3 ++ lib/table/rte_table_lpm_ipv6.c | 3 ++ lib/table/rte_table_stub.c | 3 ++ 75 files changed, 406 insertions(+), 179 deletions(-) create mode 100644 lib/acl/acl_log.h create mode 100644 lib/fib/fib_log.h create mode 100644 lib/hash/rte_hash_crc.c create mode 100644 lib/hash/rte_thash_gfni.c create mode 100644 lib/lpm/lpm_log.h create mode 100644 lib/mbuf/mbuf_log.h create mode 100644 lib/rib/rib_log.h create mode 100644 lib/sched/rte_sched_log.h -- 2.39.1