From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFCEE41D5D; Fri, 24 Feb 2023 09:16:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5639C40697; Fri, 24 Feb 2023 09:16:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6AF6940693 for ; Fri, 24 Feb 2023 09:16:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677226615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6UDBl92iIALu5UAwAo5MoHDFJgtY1zhwBpSrI8jE+V0=; b=Barsl0ts/LLDigC+7XJIMf2js5J2Gb528ihEhxp06dDKcapaexZrdMTJCbKVcBfkoOHSiL J++YaltBAx4hXR5IfVPrcvsQis1ebnUGllRZ/MIZXBsLcQ7U1AkzQt+f5Nonf3gMIFldYU uWEIwYEFsBMpo7TUT+vwsKG1GfyUirc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-78-HjkESQvkPW6jcKp-D7HaQw-1; Fri, 24 Feb 2023 03:16:52 -0500 X-MC-Unique: HjkESQvkPW6jcKp-D7HaQw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19FBB29A9D3A; Fri, 24 Feb 2023 08:16:52 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64D18C15BA0; Fri, 24 Feb 2023 08:16:51 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net Subject: [PATCH 00/14] Enable lock annotations on most libraries and drivers Date: Fri, 24 Feb 2023 09:16:28 +0100 Message-Id: <20230224081642.2566619-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a followup of the series that introduced lock annotations. I reworked and made annotations work in what seemed the easier cases. In most cases, I chose to convert inline wrappers around the EAL lock API to simple macro: I did not see much value in those wrappers and this is way simpler than adding __rte_*lock_function tags everywhere. A list of libraries and drivers still need more work as their code have non obvious locks handling. For those components, the check is opted out. I leave it to their respective maintainers to enable the checks later. Maintainers, please review. -- David Marchand David Marchand (14): malloc: rework heap lock handling mem: rework malloc heap init mem: annotate shared memory config locks hash: annotate cuckoo hash lock graph: annotate graph lock drivers: inherit lock annotations for Intel drivers net/cxgbe: inherit lock annotations net/fm10k: annotate mailbox lock net/sfc: rework locking in proxy code net/sfc: inherit lock annotations net/virtio: annotate lock for guest announce raw/ifpga: inherit lock annotations vdpa/sfc: inherit lock annotations enable lock check .../prog_guide/env_abstraction_layer.rst | 5 +- drivers/bus/dpaa/meson.build | 1 + drivers/common/cnxk/meson.build | 1 + drivers/common/iavf/iavf_osdep.h | 39 +++-------- drivers/common/iavf/iavf_prototype.h | 6 -- drivers/common/idpf/base/idpf_osdep.h | 26 ++------ drivers/common/mlx5/meson.build | 1 + drivers/event/cnxk/meson.build | 1 + drivers/meson.build | 2 +- drivers/net/bnx2x/meson.build | 1 + drivers/net/bnxt/meson.build | 1 + drivers/net/cnxk/meson.build | 1 + drivers/net/cxgbe/base/adapter.h | 35 ++-------- drivers/net/enic/meson.build | 1 + drivers/net/fm10k/fm10k_ethdev.c | 2 + drivers/net/hns3/meson.build | 1 + drivers/net/i40e/base/i40e_osdep.h | 8 +-- drivers/net/i40e/base/i40e_prototype.h | 5 -- drivers/net/i40e/i40e_ethdev.c | 24 ------- drivers/net/ice/base/ice_osdep.h | 26 ++------ drivers/net/mlx5/meson.build | 1 + drivers/net/sfc/sfc.h | 41 ++---------- drivers/net/sfc/sfc_ev.c | 6 +- drivers/net/sfc/sfc_repr.c | 38 ++--------- drivers/net/sfc/sfc_repr_proxy.c | 59 +++++++++-------- drivers/net/virtio/virtio_ethdev.c | 8 +-- drivers/net/virtio/virtio_ethdev.h | 7 +- drivers/raw/ifpga/afu_pmd_core.c | 17 +---- drivers/vdpa/sfc/sfc_vdpa.h | 41 ++---------- drivers/vdpa/sfc/sfc_vdpa_ops.c | 14 ++-- lib/eal/common/eal_common_mcfg.c | 66 +++++++++++-------- lib/eal/common/eal_common_memory.c | 10 +-- lib/eal/common/malloc_heap.c | 55 +++++++++++----- lib/eal/common/malloc_heap.h | 3 + lib/eal/common/rte_malloc.c | 10 --- lib/eal/freebsd/eal.c | 13 ++++ lib/eal/include/rte_eal_memconfig.h | 63 ++++++++++++++---- lib/eal/linux/eal.c | 13 ++++ lib/eal/version.map | 4 ++ lib/eal/windows/eal.c | 13 ++++ lib/graph/graph.c | 10 ++- lib/graph/graph_private.h | 10 ++- lib/hash/rte_cuckoo_hash.c | 8 +++ lib/ipsec/meson.build | 1 + lib/meson.build | 2 +- lib/timer/meson.build | 1 + lib/vhost/meson.build | 1 - 47 files changed, 313 insertions(+), 389 deletions(-) -- 2.39.2