From: Hernan Vargas <hernan.vargas@intel.com>
To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,
maxime.coquelin@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com,
Hernan Vargas <hernan.vargas@intel.com>,
stable@dpdk.org
Subject: [PATCH v3 02/17] test/bbdev: extend HARQ tolerance
Date: Thu, 2 Mar 2023 12:21:56 -0800 [thread overview]
Message-ID: <20230302202211.170017-3-hernan.vargas@intel.com> (raw)
In-Reply-To: <20230302202211.170017-1-hernan.vargas@intel.com>
HARQ memory implementation could have different size assumptions.
Extending HARQ tolerance to cover different implementations.
Fixes: 335c11fd276 ("app/bbdev: support HARQ validation")
Cc: stable@dpdk.org
Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
app/test-bbdev/test_bbdev_perf.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 027f32cbf1b7..74e7e1394092 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -95,6 +95,7 @@
#define K0_3_1 56 /* K0 fraction numerator for rv 3 and BG 1 */
#define K0_3_2 43 /* K0 fraction numerator for rv 3 and BG 2 */
+#define HARQ_MEM_TOLERANCE 256
static struct test_bbdev_vector test_vector;
/* Switch between PMD and Interrupt for throughput TC */
@@ -2090,13 +2091,17 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op,
uint16_t data_len = rte_pktmbuf_data_len(m) - offset;
total_data_size += orig_op->segments[i].length;
- TEST_ASSERT(orig_op->segments[i].length <
- (uint32_t)(data_len + 64),
+ TEST_ASSERT(orig_op->segments[i].length < (uint32_t)(data_len + HARQ_MEM_TOLERANCE),
"Length of segment differ in original (%u) and filled (%u) op",
orig_op->segments[i].length, data_len);
harq_orig = (int8_t *) orig_op->segments[i].addr;
harq_out = rte_pktmbuf_mtod_offset(m, int8_t *, offset);
+ /* Cannot compare HARQ output data for such cases */
+ if ((ldpc_llr_decimals > 1) && ((ops_ld->op_flags & RTE_BBDEV_LDPC_LLR_COMPRESSION)
+ || (ops_ld->op_flags & RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION)))
+ break;
+
if (!(ldpc_cap_flags &
RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS
) || (ops_ld->op_flags &
@@ -2172,7 +2177,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op,
/* Validate total mbuf pkt length */
uint32_t pkt_len = rte_pktmbuf_pkt_len(op->data) - op->offset;
- TEST_ASSERT(total_data_size < pkt_len + 64,
+ TEST_ASSERT(total_data_size < pkt_len + HARQ_MEM_TOLERANCE,
"Length of data differ in original (%u) and filled (%u) op",
total_data_size, pkt_len);
--
2.37.1
next prev parent reply other threads:[~2023-03-02 20:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 20:21 [PATCH v3 00/17] test/bbdev: changes for 23.03 Hernan Vargas
2023-03-02 20:21 ` [PATCH v3 01/17] test/bbdev: fix seg fault for non supported HARQ len Hernan Vargas
2023-03-06 13:17 ` Maxime Coquelin
2023-03-02 20:21 ` Hernan Vargas [this message]
2023-03-02 20:21 ` [PATCH v3 03/17] test/bbdev: remove check for invalid opaque data Hernan Vargas
2023-03-02 20:21 ` [PATCH v3 04/17] test/bbdev: refactor TB throughput report Hernan Vargas
2023-03-02 20:21 ` [PATCH v3 05/17] test/bbdev: add timeout for latency tests Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 06/17] test/bbdev: enable early termination for validation Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 07/17] test/bbdev: report device status in test-bbdev Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 08/17] test/bbdev: test start/stop bbdev API Hernan Vargas
2023-03-03 12:31 ` Maxime Coquelin
2023-03-02 20:22 ` [PATCH v3 09/17] test/bbdev: add timeout for enq/deq loops Hernan Vargas
2023-03-03 12:44 ` Maxime Coquelin
2023-03-02 20:22 ` [PATCH v3 10/17] test/bbdev: add support for BLER for 4G Hernan Vargas
2023-03-03 16:41 ` Maxime Coquelin
2023-03-02 20:22 ` [PATCH v3 11/17] test/bbdev: extend support for large TB Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 12/17] test/bbdev: adjustment for soft output Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 13/17] test/bbdev: expose warning counters Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 14/17] test/bbdev: remove iteration count check Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 15/17] test/bbdev: use mbuf reset function Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 16/17] test/bbdev: remove max iteration from vectors Hernan Vargas
2023-03-02 20:22 ` [PATCH v3 17/17] test/bbdev: remove iter count from bler test Hernan Vargas
2023-03-06 13:20 ` [PATCH v3 00/17] test/bbdev: changes for 23.03 Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302202211.170017-3-hernan.vargas@intel.com \
--to=hernan.vargas@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).