From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D316441DD7;
	Sat,  4 Mar 2023 17:04:45 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B655940ED4;
	Sat,  4 Mar 2023 17:04:45 +0100 (CET)
Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com
 [209.85.214.180])
 by mails.dpdk.org (Postfix) with ESMTP id 4C11240687
 for <dev@dpdk.org>; Sat,  4 Mar 2023 17:04:44 +0100 (CET)
Received: by mail-pl1-f180.google.com with SMTP id i5so5868523pla.2
 for <dev@dpdk.org>; Sat, 04 Mar 2023 08:04:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1677945883;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=GvkLfcQNiR58Tg0Y3v4TDo7Me1GtpS9OPYOsdh/QUlo=;
 b=F2xYiyMLSEETfntr81rt3UXn2JMWBdGMTGe5jn17NpWKNsvH326Jged305O1ZWCN9c
 CujL3GVv6iN+NjLciBbBo7T8kSdRfYTLJ4dj+V2mmlGc/8jKbTOkDizLYty2bHhjE0AB
 89WecSCxngkxSeS1b8UQTTDKhszIokEEt0YXacmT6R8AIfEBNxFar9EoeVG7vamV3/PS
 NIxwSWxJhpn+95H+EVLkn401uNrZrk57SXGfGNXSOGSyExcMPUhA4wdH3cLShYXl5L+b
 rWtCzpFmQ0g6PCEUq+c01Udoj06IC8JjaIT33m78Umq7c5yPFAo7HVWL9x/zA9mYtFPz
 SV0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112; t=1677945883;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=GvkLfcQNiR58Tg0Y3v4TDo7Me1GtpS9OPYOsdh/QUlo=;
 b=0oJPWvdDL9+zmJOQUcuaHxGV+vMcouUPyKd2ZADvECtdetukt7nurX0SmGcZmHyTna
 7GOJpDazFAfKu4M2x4y8HME6PB3tJ/Vdh/MfUpo7vHcr6UpHdlikBhqk4qs4XJanmU+z
 smn8wBr5P4+hzKCmjhSRT+y0fKbjPcr8oHhmb1MVfsbPsGBEcGEhQqITkmrRpqgs+/bU
 pxy0ql9SwBijJ4ZfeBOOu74CHk6pQRHBVzxn0gDQarWNTNJ/DeiwOpz1kTKVo3m61+tJ
 58VnnzFVh5RoDhvknIEgRdRAyGml+fXsnjtFAIdm52Wdhgk7mXDDj0vqiiXFO/0iwu2w
 GhyQ==
X-Gm-Message-State: AO0yUKWJ7bjqGtu210H70FqX9tYW+8afqpetErYhQWVoZZQT6Ci7kkaH
 0oQw7OT4vhhnOew/kAfPTsu1nSSAo38RTVNE1iFpBw==
X-Google-Smtp-Source: AK7set/KWBoV5cd/kYom2GntcIxU3TdQJnAR4q1E+ipY1GXkN8c5P3AEobYxPv23MBCYvE0B+UmzlQ==
X-Received: by 2002:a17:903:41c6:b0:19d:181f:511 with SMTP id
 u6-20020a17090341c600b0019d181f0511mr6804507ple.30.1677945883327; 
 Sat, 04 Mar 2023 08:04:43 -0800 (PST)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
 by smtp.gmail.com with ESMTPSA id
 t5-20020a170902e84500b0019aa6bf4450sm3479035plg.188.2023.03.04.08.04.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 04 Mar 2023 08:04:43 -0800 (PST)
Date: Sat, 4 Mar 2023 08:04:41 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: luzhipeng <luzhipeng@cestc.cn>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [PATCH v3] log: add timestamp for log
Message-ID: <20230304080441.4f69905e@hermes.local>
In-Reply-To: <20230304081421.1352-1-luzhipeng@cestc.cn>
References: <20230304081421.1352-1-luzhipeng@cestc.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Sat,  4 Mar 2023 16:14:21 +0800
luzhipeng <luzhipeng@cestc.cn> wrote:

> From: Zhipeng Lu <luzhipeng@cestc.cn>
> 
> add timestamp for log
> 
> Signed-off-by: Zhipeng Lu <luzhipeng@cestc.cn>

Good idea but:
  - it needs to be optional
  - timestamp only makes sense on the terminal (stdout) log stream
    syslog/journal already have timestamp


I did a similar patch that never made it in that did this.
https://patchwork.dpdk.org/project/dpdk/patch/20200814173441.23086-1-stephen@networkplumber.org/