From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5C1741E34; Thu, 9 Mar 2023 03:41:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2C9140ED7; Thu, 9 Mar 2023 03:41:47 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 5052340A7E for ; Thu, 9 Mar 2023 03:41:46 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id h17-20020a17090aea9100b0023739b10792so793326pjz.1 for ; Wed, 08 Mar 2023 18:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678329705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=sVrniCrh9NZ6UDP4WTfDHILlJQqo9cbSkD0ISRfbxsE=; b=EUbeCJDufhLL4uxW58YG0hcipOYVs9k+2z5l5Fk1sKkIkJeWcPIOp+Jq2aIKoK3fOC cTXpVI0wZxrfFsSAiQfZ0zGxeE1Dfsl7UZmZlhmRkF4sgJMilRoTVQ54TIiCdzXyTWT1 Sn/zGjjBPoOv4DqRPkmQsMjX4AmPmURWg2+ckq46dDJ1hQ91HLe503s/faJXvDnzwZec za1sDJ4qlWbcOWXl3CDvB5IeYsorCrKyq/pMqNHdgaVelUZxReiYt2rUFZ6TgjpfZstV WpvTLOnVbnWVjCyqJxbm7LmChkS+4+vFoNNUdioB6OXtF060KLPcoswdEWp03cAnrgPB AhpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678329705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sVrniCrh9NZ6UDP4WTfDHILlJQqo9cbSkD0ISRfbxsE=; b=Hnm0S5y6EwufKyo76YFTmubMw/tDaKNNprtDpCIqLHW/8sntpAVcZCMz84NfO29xFj k+y9KlhVzQSVSEuIwPskarICdIFz2EH2l5A0qDKeXeR/v00CTjA3V2ztHDIBxJxqXfHX iHgNc2dVrUEsnB7xTQp4qvdCcwOrXBXtlDhCQgvbK5ZTJlkvdt4VWFh1FtyH+muRvP59 j355/9WEv9IgtgAikiivSsu8BsQvt0C0iXqX7TJAx/UUoJcfAxeLPRxZo1T7Ip9fHBwc whN7/QgEoRGP4pgWewYn28NuQtkICP87kuNUnkY1NLckpr2JTr83RVMu1Lk+G2zVfXpc VqSg== X-Gm-Message-State: AO0yUKXRdup4lUwCOxsZ1WIk564JEzaKqeUoWzxNWpISi5MWGTO+bfrK UBK39RrNXmnQGPNYea/cFSDWFg== X-Google-Smtp-Source: AK7set+Y+M3UVpYsVJyjee2ijP276hzNq/heiuD6FI2Ogubax1LJtHLh73yUb+9xPjLIj/jU/Z+cUg== X-Received: by 2002:a17:902:db0e:b0:19c:be03:d1b8 with SMTP id m14-20020a170902db0e00b0019cbe03d1b8mr23506444plx.17.1678329705420; Wed, 08 Mar 2023 18:41:45 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id v12-20020a1709028d8c00b00199203a4fa3sm10310888plo.203.2023.03.08.18.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 18:41:45 -0800 (PST) Date: Wed, 8 Mar 2023 18:41:43 -0800 From: Stephen Hemminger To: Mingxia Liu Cc: dev@dpdk.org, beilei.xing@intel.com, yuying.zhang@intel.com Subject: Re: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode Message-ID: <20230308184143.32a8a6d0@hermes.local> In-Reply-To: <20230309103142.276726-1-mingxia.liu@intel.com> References: <20230309103142.276726-1-mingxia.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 9 Mar 2023 10:31:42 +0000 Mingxia Liu wrote: > iff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c > index db58157ba3..59883af8a8 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -1058,8 +1058,8 @@ idpf_handle_virtchnl_msg(struct idpf_adapter_ext *adapter_ex) > struct idpf_ctlq_msg ctlq_msg; > enum idpf_mbx_opc mbx_op; > struct idpf_vport *vport; > - enum virtchnl_ops vc_op; > uint16_t pending = 1; > + enum virtchnl_ops vc_op; > int ret; > > while (pending) { Why does order of declarations matter here? Compilers are free to reorder this.