From: Stephen Hemminger <stephen@networkplumber.org>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Cc: "J.J. Martzki" <mars14850@gmail.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [PATCH v4] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap
Date: Mon, 13 Mar 2023 10:22:26 -0700 [thread overview]
Message-ID: <20230313102226.29c84784@hermes.local> (raw)
In-Reply-To: <4ba4c9cde28f473fb09a391e8ad9d55b@huawei.com>
On Mon, 13 Mar 2023 17:07:29 +0000
Konstantin Ananyev <konstantin.ananyev@huawei.com> wrote:
> > I've read the libbpf code again and I found some other functions with
> > pure 'bpf_' prefix. Should we rename all the functions whose names
> > start with pure 'bpf_'?
>
> I thought you already prefixed all non-static functions in the lib...
> Or do I miss something?
Right, it was bpf_validate, bpf_jit_XXX that were not prefixed.
.../build/lib/librte_bpf.a.p $ nm * | grep ' T ' | grep -v 'rte_bpf'
0000000000000070 T bpf_jit
0000000000003210 T bpf_jit_x86
00000000000021f0 T bpf_validate
next prev parent reply other threads:[~2023-03-13 17:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 13:56 [PATCH] lib/bpf: Rename 'bpf_validate' " Martzki
2023-03-05 17:16 ` Stephen Hemminger
2023-03-05 17:31 ` Stephen Hemminger
2023-03-06 15:32 ` [PATCH v2] lib/bpf: Rename bpf function names " Martzki
2023-03-06 15:42 ` [PATCH v3] " Martzki
2023-03-11 9:18 ` Thomas Monjalon
2023-03-12 6:20 ` [PATCH v4] " J.J. Martzki
2023-03-12 14:02 ` Konstantin Ananyev
2023-03-13 1:50 ` J.J. Mars
2023-03-13 14:55 ` J.J. Martzki
2023-03-13 15:54 ` Stephen Hemminger
2023-03-13 17:07 ` Konstantin Ananyev
2023-03-13 17:22 ` Stephen Hemminger [this message]
2023-03-14 2:21 ` 马尔斯
2023-03-14 14:20 ` [PATCH v5] " J.J. Martzki
2023-03-16 0:58 ` Konstantin Ananyev
2023-03-20 11:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313102226.29c84784@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mars14850@gmail.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).