From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 921EB41E86; Mon, 13 Mar 2023 18:22:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6667F40E03; Mon, 13 Mar 2023 18:22:30 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 5B84F406BC for ; Mon, 13 Mar 2023 18:22:29 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id y11so13786179plg.1 for ; Mon, 13 Mar 2023 10:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678728148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YIHevP3Y37pTHbWdHg+W7FOBnvrnNmgQoeJppqmXLq0=; b=vWHUNU/KzEx0ahqBZyVfYJ3L0dukAVrZQh15VHqW73OlFw4X0zrW2epU8+gC1xafwe qOnWcjoIMP9uSQ6nhjzWYKESqBWYf8E9ZEh6XD1qtqIU0uJFH1tH0bFNEW7rt19unPYU nWmKAbeSExr6YcKW8302X0tdGW6zMTAv/C0PvgX0ea1jV9c4Emfr1gmllwt7nkQn3xx0 Ep+1WdFtRNeO2WyaNMGxqjXYbD7UrK/DJfgTVzvSbreG+LhMOH/QNBP3rwFjY49iQfli WD/8bfZUrPuidTudHgvH+IgN9aTJTFNLL0gzd2AaalEGzRjArYsAGp4FEJgUv/tMqBvE nydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678728148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YIHevP3Y37pTHbWdHg+W7FOBnvrnNmgQoeJppqmXLq0=; b=bvO4duPOyzrqivX9oqSyI8giIdDJVFWAPiRcv/SwWvB9ovW4QFmiiwSIz0LRJY8riB 8FogVWf9Vn2/pqrtdUW1NL/EKtnGkPIPKnuLieyd1MEjUyHOdWa19P6FPHDY+xfZko9P wQN5J1asMB5zF6vOrYixeIguE5yhsG7rFMfb2hv2g3atW2YvbGjLWhraLU/OFtfdMvKB LYwKVTAmuWW2ZG49gDvUctbjE2lPhp9y5qpHB4Xta3sELmVjLMheX8Hj/0582WdO/V86 UgAdfxgYsrETnlvyODgwuwv4GjJdU08jg+P6u9pxTeg4aNMTlfY7WiFuW9se/JHLsT45 RrpQ== X-Gm-Message-State: AO0yUKWCOSstRExu2dvgiz6UAbCCGTVudJ+QdDtpIe2OhKmlLrGmY8as ItBao0jVSwp4o3irlfQ0BKV6FQ== X-Google-Smtp-Source: AK7set/rL1ehFxltiAuQFEaSy0BxSbS3UuNPGbDPstBijMKmP3Y/uNKOfIUvud5ykas/z1+APX7O0Q== X-Received: by 2002:a05:6a20:4c1f:b0:cc:6d4d:57b3 with SMTP id fm31-20020a056a204c1f00b000cc6d4d57b3mr26441978pzb.12.1678728148532; Mon, 13 Mar 2023 10:22:28 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x21-20020aa784d5000000b00592eb6f239fsm6096pfn.40.2023.03.13.10.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 10:22:28 -0700 (PDT) Date: Mon, 13 Mar 2023 10:22:26 -0700 From: Stephen Hemminger To: Konstantin Ananyev Cc: "J.J. Martzki" , Konstantin Ananyev , "dev@dpdk.org" , "thomas@monjalon.net" , Ruifeng Wang Subject: Re: [PATCH v4] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap Message-ID: <20230313102226.29c84784@hermes.local> In-Reply-To: <4ba4c9cde28f473fb09a391e8ad9d55b@huawei.com> References: <20230306154216.41154-1-mars14850@gmail.com> <20230312062021.7349-1-mars14850@gmail.com> <948b18da-3e41-c65c-7d47-b49ba6a4d810@yandex.ru> <4ba4c9cde28f473fb09a391e8ad9d55b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 Mar 2023 17:07:29 +0000 Konstantin Ananyev wrote: > > I've read the libbpf code again and I found some other functions with > > pure 'bpf_' prefix. Should we rename all the functions whose names > > start with pure 'bpf_'? > > I thought you already prefixed all non-static functions in the lib... > Or do I miss something? Right, it was bpf_validate, bpf_jit_XXX that were not prefixed. .../build/lib/librte_bpf.a.p $ nm * | grep ' T ' | grep -v 'rte_bpf' 0000000000000070 T bpf_jit 0000000000003210 T bpf_jit_x86 00000000000021f0 T bpf_validate