From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BE0A41E28; Tue, 14 Mar 2023 13:55:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6BAE427F2; Tue, 14 Mar 2023 13:55:12 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 95E3941611 for ; Tue, 14 Mar 2023 13:55:10 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PbYMJ6XLzz17KrL; Tue, 14 Mar 2023 20:52:12 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 20:55:08 +0800 From: Chengwen Feng To: , , Reshma Pattan , Stephen Hemminger CC: Subject: [PATCH 1/5] app/pdump: fix segment fault when parse args Date: Tue, 14 Mar 2023 12:48:09 +0000 Message-ID: <20230314124813.39521-2-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230314124813.39521-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse --pdump args with 'only keys' (e.g. 'port,queue=*'). Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- app/pdump/main.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index c6cf9d9c87..d286952483 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -170,6 +170,9 @@ parse_device_id(const char *key __rte_unused, const char *value, { struct pdump_tuples *pt = extra_args; + if (value == NULL || extra_args == NULL) + return -EINVAL; + pt->device_id = strdup(value); pt->dump_by_type = DEVICE_ID; @@ -182,6 +185,9 @@ parse_queue(const char *key __rte_unused, const char *value, void *extra_args) unsigned long n; struct pdump_tuples *pt = extra_args; + if (value == NULL || extra_args == NULL) + return -EINVAL; + if (!strcmp(value, "*")) pt->queue = RTE_PDUMP_ALL_QUEUES; else { @@ -197,6 +203,9 @@ parse_rxtxdev(const char *key, const char *value, void *extra_args) struct pdump_tuples *pt = extra_args; + if (value == NULL || extra_args == NULL) + return -EINVAL; + if (!strcmp(key, PDUMP_RX_DEV_ARG)) { strlcpy(pt->rx_dev, value, sizeof(pt->rx_dev)); /* identify the tx stream type for pcap vdev */ @@ -220,6 +229,9 @@ parse_uint_value(const char *key, const char *value, void *extra_args) char *end; int ret = 0; + if (value == NULL || extra_args == NULL) + return -EINVAL; + errno = 0; v = extra_args; t = strtoul(value, &end, 10); -- 2.17.1