From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37F0A41E28; Tue, 14 Mar 2023 13:55:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F419A42BAC; Tue, 14 Mar 2023 13:55:13 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id C8B2D427F5 for ; Tue, 14 Mar 2023 13:55:10 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PbYMJ6GfjznWqh; Tue, 14 Mar 2023 20:52:12 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 20:55:09 +0800 From: Chengwen Feng To: , , Bruce Richardson , Neil Horman , Ferruh Yigit CC: Subject: [PATCH 4/5] net/ring: fix segment fault when parse devargs Date: Tue, 14 Mar 2023 12:48:12 +0000 Message-ID: <20230314124813.39521-5-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230314124813.39521-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys'. Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking") Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/ring/rte_eth_ring.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index e8bc9b6271..4edff83531 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -562,6 +562,9 @@ static int parse_kvlist(const char *key __rte_unused, char *node; char *end; + if (value == NULL || data == NULL) + return -EINVAL; + name = strdup(value); ret = -EINVAL; @@ -630,6 +633,9 @@ parse_internal_args(const char *key __rte_unused, const char *value, void *args; int ret, n; + if (value == NULL) + return -EINVAL; + /* make sure 'value' is valid pointer length */ if (strnlen(value, ETH_RING_INTERNAL_ARG_MAX_LEN) >= ETH_RING_INTERNAL_ARG_MAX_LEN) { -- 2.17.1