From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF7D441E28; Tue, 14 Mar 2023 13:55:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A55B42C76; Tue, 14 Mar 2023 13:55:16 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 2782041101 for ; Tue, 14 Mar 2023 13:55:11 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PbYMK6d9tz17Kss; Tue, 14 Mar 2023 20:52:13 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 20:55:09 +0800 From: Chengwen Feng To: , , Andrew Rybchenko , Roman Zhukov , Andrew Lee , Robert Stonehouse , Ferruh Yigit , Andy Moreton CC: Subject: [PATCH 5/5] net/sfc: fix segment fault when parse devargs Date: Tue, 14 Mar 2023 12:48:13 +0000 Message-ID: <20230314124813.39521-6-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230314124813.39521-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys'. Fixes: 9e7fc8b8f3be ("net/sfc: add device parameter to choose FW variant") Fixes: c22d3c508e0c ("net/sfc: support parameter to choose performance profile") Fixes: 63d588ff2692 ("net/sfc: libefx-based driver stub") Fixes: df1bfde4ff0d ("net/sfc: factor out libefx-based Rx datapath") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/sfc/sfc.c | 3 +++ drivers/net/sfc/sfc_ev.c | 3 +++ drivers/net/sfc/sfc_kvargs.c | 6 ++++++ 3 files changed, 12 insertions(+) diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c index 22753e3417..c5271347a4 100644 --- a/drivers/net/sfc/sfc.c +++ b/drivers/net/sfc/sfc.c @@ -1108,6 +1108,9 @@ sfc_kvarg_fv_variant_handler(__rte_unused const char *key, { uint32_t *value = opaque; + if (value_str == NULL || opaque == NULL) + return -EINVAL; + if (strcasecmp(value_str, SFC_KVARG_FW_VARIANT_DONT_CARE) == 0) *value = EFX_FW_VARIANT_DONT_CARE; else if (strcasecmp(value_str, SFC_KVARG_FW_VARIANT_FULL_FEATURED) == 0) diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c index f949abbfc3..4cd900bd76 100644 --- a/drivers/net/sfc/sfc_ev.c +++ b/drivers/net/sfc/sfc_ev.c @@ -955,6 +955,9 @@ sfc_kvarg_perf_profile_handler(__rte_unused const char *key, { uint32_t *value = opaque; + if (value_str == NULL || opaque == NULL) + return -EINVAL; + if (strcasecmp(value_str, SFC_KVARG_PERF_PROFILE_THROUGHPUT) == 0) *value = EFX_EVQ_FLAGS_TYPE_THROUGHPUT; else if (strcasecmp(value_str, SFC_KVARG_PERF_PROFILE_LOW_LATENCY) == 0) diff --git a/drivers/net/sfc/sfc_kvargs.c b/drivers/net/sfc/sfc_kvargs.c index 783cb43ae6..f77c4af345 100644 --- a/drivers/net/sfc/sfc_kvargs.c +++ b/drivers/net/sfc/sfc_kvargs.c @@ -85,6 +85,9 @@ sfc_kvarg_bool_handler(__rte_unused const char *key, }; bool *value = opaque; + if (!key || !opaque) + return -EINVAL; + if (sfc_kvarg_match_value(value_str, true_strs, RTE_DIM(true_strs))) *value = true; @@ -120,6 +123,9 @@ int sfc_kvarg_string_handler(__rte_unused const char *key, const char *value_str, void *opaque) { + if (value_str == NULL || opaque == NULL) + return -EINVAL; + *(const char **)opaque = value_str; return 0; -- 2.17.1