From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AFF6141E90;
	Tue, 14 Mar 2023 14:59:57 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9161A40F18;
	Tue, 14 Mar 2023 14:59:57 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id DEC4540A7E
 for <dev@dpdk.org>; Tue, 14 Mar 2023 14:59:56 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 3E6CE20C5A48; Tue, 14 Mar 2023 06:59:56 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3E6CE20C5A48
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1678802396;
 bh=tcm+eWEF2sujZJCXxnXiKc1PenUAMVt0MgE8sweeg7M=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=rXpBJzr4JNe9ePqw8ykp6JjI2H6USgDjbUWtsiinmRZ8h9MhvfNtJQ/XUrDJoTRia
 GoG7M1358Ye3r7qtwnRxl3G2qoxIz2VSKIWZ361NDWjLZpTwy8VKZSpmPgaoHLHNkZ
 rWf+MuG8KuSf/vlpChIlb/S489jts8rRugeMid00=
Date: Tue, 14 Mar 2023 06:59:56 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [PATCH v2 0/2] fix race in rte_thread_create failure path
Message-ID: <20230314135956.GA29381@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1677782682-27200-1-git-send-email-roretzla@linux.microsoft.com>
 <1678750267-3829-1-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8zWJ0vMMzxpQ00a9EzhZ_yJjtJFkYhmx1CKFCRScZS-Hw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8zWJ0vMMzxpQ00a9EzhZ_yJjtJFkYhmx1CKFCRScZS-Hw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Mar 14, 2023 at 12:47:54PM +0100, David Marchand wrote:
> On Tue, Mar 14, 2023 at 12:31 AM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > v2:
> >   * new approach over v1 of the patch to avoid using pthread np API that
> >     is not available on Alpine Linux.
> >   * to conform to rte_thread_create parameter const qualification include
> >     an additional patch to const qualify rte_thread_set_affinity cpusetp
> >     parameter.
> >
> > Tyler Retzlaff (2):
> >   eal: make cpusetp to rte thread set affinity const
> >   eal: fix failure path race setting new thread affinity
> >
> >  lib/eal/common/eal_common_thread.c |  6 ++---
> >  lib/eal/include/rte_thread.h       |  2 +-
> >  lib/eal/unix/rte_thread.c          | 52 ++++++++++++++++++++++++++++++--------
> >  3 files changed, 46 insertions(+), 14 deletions(-)
> 
> ASan flagged some use after free.
> See logs https://github.com/ovsrobot/dpdk/suites/11537702259/artifacts/597032673
> 
> 24/90 DPDK:fast-tests / lcores_autotest       FAIL     1.72 s (exit status 1)

thanks, i'm waiting on a system to test plan to investigate today if it
becomes available.

ty