From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F38AD41E95; Tue, 14 Mar 2023 23:40:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC67E40E5A; Tue, 14 Mar 2023 23:40:27 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id F2D3840A7E for ; Tue, 14 Mar 2023 23:40:26 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id p20so18136727plw.13 for ; Tue, 14 Mar 2023 15:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678833626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=3PQ8FP3Xb+nfps5iSanVWU33zgrSB8LWiZbLr1elDf4=; b=i32yee1ayJUe69hswTubLKYuDQV5ZQtqtJqY0yXMpBQTg6Efq/dzNapx6LCBgrZXFP XQE9o2UUJzhKWfPxLa2b0ZcGenx+TB8Lj18RGab9Fnub2oA5m+4SAa4mJ9TzOXqgpVnl xid7RwKJed8ONRIMn7LlGvnA4mpdSjHmjOm5PPLyJ4gfNOjvk4HPTHR1+vB9P6XneUES OtHSNh1z2rR+bz5Trmy5/IukutSG0GRdzzzqhDpcSDXoQJ5dkunAnLRJO2sWsCrWhAZ6 d+qK9XVpPJ9K6zzMXYjcPoJgTaDs1M+cWZKpFjWp4cYmSjXr+Hcu+f13b36njEoPoL7C XPJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678833626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3PQ8FP3Xb+nfps5iSanVWU33zgrSB8LWiZbLr1elDf4=; b=GpXdDsHnLNWhphCbg1ahQwK8yJW90jF1Z4OsvbCMDMIapGJHAFqJSKV906GP0slbqj sARXtAbjleTeB3TYX3cFzOX0c2b05jGzj7Hj1o1PGS4unaXszjBaVVgpeItVHDbjS/vk YMP2NKsxSadKppCOE6imDFQ+vXWokFY5Nc5LFQXT6oYU3mPhjQq4TIj6jtN5b+Jm3AN9 m6z+3Qj8guTxs70cIxoMZCA03wpyCua+QKynY6pqkhQIGZ2eOrezhqUFaznvX1oom3QF f7cbe9q4YSWob8+E4Fm8J4eq5ThKVusfk+WtcpvOo1bP5P+Go5G/H7BL2BnbNTUwlMqX XYTA== X-Gm-Message-State: AO0yUKVYfukA4DqSGwsD46dO1PJ6rslEuHCskqXQ7YlG7ednWfyjvUeO gR0xPJMiznMbnKLXMxai2Iy9nYohypVV0D84M5boaA== X-Google-Smtp-Source: AK7set+0LZtYNaXvXtGkPayGpG529JDcC96TQYfy1BMfC2QYeq4Xby+hyO/L2cCqn3myFuEAan1XWw== X-Received: by 2002:a17:902:e5cc:b0:19e:898f:8813 with SMTP id u12-20020a170902e5cc00b0019e898f8813mr734541plf.13.1678833625737; Tue, 14 Mar 2023 15:40:25 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id l16-20020a17090ac59000b0023b3d80c76csm2235346pjt.4.2023.03.14.15.40.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 15:40:25 -0700 (PDT) Date: Tue, 14 Mar 2023 15:40:23 -0700 From: Stephen Hemminger To: dev@dpdk.org Subject: Re: [PATCH v3 0/3] testpmd control C fixes Message-ID: <20230314154023.557ac6f4@hermes.local> In-Reply-To: <20230314173648.69528-1-stephen@networkplumber.org> References: <20230313171905.67720-1-stephen@networkplumber.org> <20230314173648.69528-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 14 Mar 2023 10:36:45 -0700 Stephen Hemminger wrote: > Resolve issues around using control-C in testpmd. > Using cmdline_poll() is broken and won't work right so > don't use it. Instead use cmdline_interact() and fix > the signal handling. > > Stephen Hemminger (3): > testpmd: go back to using cmdline_interact > testpmd: use sig_atomic_t for flag > testpmd: enable interrupt in interactive mode > > app/test-pmd/cmdline.c | 27 ++++++++++++++------------- > app/test-pmd/testpmd.c | 17 ++++++++++++----- > app/test-pmd/testpmd.h | 3 ++- > lib/cmdline/cmdline.h | 10 ++++++++++ > lib/cmdline/cmdline_os_unix.c | 8 +++++++- > lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++-- > lib/cmdline/cmdline_private.h | 2 +- > lib/cmdline/version.map | 3 +++ > 8 files changed, 65 insertions(+), 23 deletions(-) > This patch is failing the CI tests from something that seems unrelated. Looks like recent cyrptodev or ixgbe change broke something. -Idrivers/net/ice/base -I../drivers/net/ice/base -Idrivers/net/ice/../../common/iavf -I../drivers/net/ice/../../common/iavf -Idrivers/common/iavf -I../drivers/common/iavf -Idrivers/net/mlx5 -I../drivers/net/mlx5 -Idrivers/net/mlx5/linux -I../drivers/net/mlx5/linux -Idrivers/net/mlx5/hws -I../drivers/net/mlx5/hws -Idrivers/common/mlx5 -I../drivers/common/mlx5 -Idrivers/common/mlx5/linux -I../drivers/common/mlx5/linux -Idrivers/bus/auxiliary -I../drivers/bus/auxiliary -I/usr/include/libnl3 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototyp es -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE -march=armv8-a+crc+crypto -march=armv8-a+crc -moutline-atomics -DALLOW_EXPERIMENTAL_API -Wno-deprecated-declarations -MD -MQ 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o' -MF 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o.d' -o 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o' -c ../drivers/net/ixgbe/ixgbe_testpmd.c In file included from ../drivers/net/ixgbe/ixgbe_ethdev.h:11, from ../drivers/net/ixgbe/ixgbe_testpmd.c:9: ../drivers/net/ixgbe/base/ixgbe_type.h:2945:17: error: conflicting types for 'u64' 2945 | #define __le64 u64 | ^~~ In file included from ../drivers/net/ixgbe/base/ixgbe_type.h:46, from ../drivers/net/ixgbe/ixgbe_ethdev.h:11, from ../drivers/net/ixgbe/ixgbe_testpmd.c:9: ../drivers/net/ixgbe/base/ixgbe_osdep.h:94:18: note: previous declaration of 'u64' was here 94 | typedef uint64_t u64; | ^~~ [2968/3157] Compiling C object 'app/test/3062f5d@@dpdk-test@exe/test_alarm.c.o'. [2969/3157] Compiling C object 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_mlx5_mlx5_testpmd.c.o'. [2970/3157] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk@sta/event_cnxk_tx_cn10k_tx_112_127_seg.c.o'. ninja: build stopped: subcommand failed. ==== End log output ====