From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B209D41EA1; Wed, 15 Mar 2023 17:31:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86FFB40A7A; Wed, 15 Mar 2023 17:31:25 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 8800040141 for ; Wed, 15 Mar 2023 17:31:24 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id u5so20635811plq.7 for ; Wed, 15 Mar 2023 09:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678897883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=12qdKeDwXDBcyv4gga7ZqKsFJxlgSyx6fj9Kds8LRtI=; b=Xs0rty18XTHhgJl9S+xME8Ks0M63/1ls1yfKimlsEKKAX6J2LvAEkCleIyEd6CbLDh T+ecLHyxaqKxbC0DYAKO6VmYEEm6YGKCQTJPwG4+TKnarHItjFSKGWBNxLVNvIHrZ902 58iO3v48Sa4i7KtcvZjs5vAao9+yj9UUHz7JI26LrSwXmemJsGkTxea1VIT4CnxH5Qrn /1dr1dnOy/aVThL0VO695LrkN3AnrhZHDrN7ojuWkWPb9SDx2GcfhSeYxFpVeLPJezMu Na3jeCX0bQVinXOxOfReyG7sR2BC3HyD+3bmhuD8bnZiBC9IiSe6hwgWWWbBXRvyjxKx yzQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678897883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=12qdKeDwXDBcyv4gga7ZqKsFJxlgSyx6fj9Kds8LRtI=; b=FNBIesdPnsbpgvr6XzUvv+8OyXhDO/1mj5Mcs82hIetdt4QDbkrDV8ymIVLeSqdm0m NC1Qi9DCeHqZVWQiobXISBudTBNT9Z5rlr57auQijwcjuV/64L9ioWvhorY5h9plvGU8 TvRzPg5OsnxuWPLDUXwLaT/eJBOfEiaknsvdUQNf3nesT72Nk0nEtlNfH0zE38TKcamQ HLQvysGpZf9XcOVGp/TFDHyYUG6qOo5UpaWbkFb4qN9IHve5CmW8xjCQRS2fi14bet2u wg08Bbv+yhN9CUfyopOvRbDEH78kUSiQk4JTLeZMLcXQKHiYrFvaENe62RlEqRW2gLHg bOMg== X-Gm-Message-State: AO0yUKXtkhpfNXs1mfDFJRRc/+5poegVFz101SJfwFpWU95d1T/zzsUK zU+thrYV+zzF/QIvZYy+nER0hJvanfiNHM3XUuTplw== X-Google-Smtp-Source: AK7set/jcPYTJLW03dybvxYcrjQiZi/xyvvFn3u3irHUz/uoe5lwlvFmE6bc3o7FvoBuJcCsf50MFg== X-Received: by 2002:a05:6a21:99aa:b0:cb:a2eb:841f with SMTP id ve42-20020a056a2199aa00b000cba2eb841fmr289574pzb.53.1678897883290; Wed, 15 Mar 2023 09:31:23 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x11-20020aa784cb000000b005dd975176c3sm1520833pfn.53.2023.03.15.09.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 09:31:23 -0700 (PDT) Date: Wed, 15 Mar 2023 09:31:21 -0700 From: Stephen Hemminger To: dev@dpdk.org Cc: Aman Singh , Yuying Zhang Subject: Re: [PATCH v3 2/3] testpmd: use sig_atomic_t for flag Message-ID: <20230315093121.105ddb86@hermes.local> In-Reply-To: <20230314173648.69528-3-stephen@networkplumber.org> References: <20230313171905.67720-1-stephen@networkplumber.org> <20230314173648.69528-1-stephen@networkplumber.org> <20230314173648.69528-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 14 Mar 2023 10:36:47 -0700 Stephen Hemminger wrote: > Standard conforming signal handling in applications should use sig_atomic_t > for flags set by signal handler. > https://www.gnu.org/software/libc/manual/html_node/Atomic-Data-Access.html > > This is really just a fancy way of saying ''int'' but adds > to platform portablilty for DPDK. > > Signed-off-by: Stephen Hemminger Apparently, this fails on some distros because signal.h ends up including some compatibility definitions that clash with the same definitions in the ixgbe testpmd base code. Since fixing either base code or the distro is a PIA not worth doing.