DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 1/2] bus/platform: fix resource names iteration
@ 2023-03-16  9:41 Tomasz Duszynski
  2023-03-16  9:41 ` [PATCH 2/2] bus/platform: do not allow adding existing device Tomasz Duszynski
  0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Duszynski @ 2023-03-16  9:41 UTC (permalink / raw)
  To: dev, Tomasz Duszynski

Fix stop condition and make sure we have some
sentinel at the end of buffer to make sure
loop can properly terminate.

Coverity issue: 383661
Fixes: 17c839f74da3 ("bus: add platform bus")

Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
---
 drivers/bus/platform/platform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/platform/platform.c b/drivers/bus/platform/platform.c
index 536d9524c6..a2faacdf18 100644
--- a/drivers/bus/platform/platform.c
+++ b/drivers/bus/platform/platform.c
@@ -249,11 +249,11 @@ of_resource_name(const char *dev_name, int index)
 	char *name;
 
 	snprintf(path, sizeof(path), PLATFORM_BUS_DEVICES_PATH "/%s/of_node/reg-names", dev_name);
-	ret = read_sysfs_string(path, buf, sizeof(buf));
+	ret = read_sysfs_string(path, buf, sizeof(buf) - 1);
 	if (ret)
 		return NULL;
 
-	for (name = buf; name; name += strlen(name) + 1) {
+	for (name = buf; *name != 0; name += strlen(name) + 1) {
 		if (num++ != index)
 			continue;
 		return strdup(name);
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] bus/platform: do not allow adding existing device
  2023-03-16  9:41 [PATCH 1/2] bus/platform: fix resource names iteration Tomasz Duszynski
@ 2023-03-16  9:41 ` Tomasz Duszynski
  2023-03-16 16:52   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Duszynski @ 2023-03-16  9:41 UTC (permalink / raw)
  To: dev, Tomasz Duszynski

Do not allow adding the same device multiple times.

Coverity issue: 383663
Fixes: 17c839f74da3 ("bus: add platform bus")

Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
---
 drivers/bus/platform/platform.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/platform/platform.c b/drivers/bus/platform/platform.c
index a2faacdf18..d4b53f6fbc 100644
--- a/drivers/bus/platform/platform.c
+++ b/drivers/bus/platform/platform.c
@@ -103,6 +103,7 @@ dev_add(const char *dev_name)
 				rte_devargs_remove(pdev->device.devargs);
 
 			free(pdev);
+			return -EEXIST;
 		}
 	}
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] bus/platform: do not allow adding existing device
  2023-03-16  9:41 ` [PATCH 2/2] bus/platform: do not allow adding existing device Tomasz Duszynski
@ 2023-03-16 16:52   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2023-03-16 16:52 UTC (permalink / raw)
  To: Tomasz Duszynski; +Cc: dev

16/03/2023 10:41, Tomasz Duszynski:
> Do not allow adding the same device multiple times.
> 
> Coverity issue: 383663
> Fixes: 17c839f74da3 ("bus: add platform bus")
> 
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>

Series applied, thanks.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-16 16:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16  9:41 [PATCH 1/2] bus/platform: fix resource names iteration Tomasz Duszynski
2023-03-16  9:41 ` [PATCH 2/2] bus/platform: do not allow adding existing device Tomasz Duszynski
2023-03-16 16:52   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).