From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD0EE41EB0; Thu, 16 Mar 2023 12:48:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99C3C40DF6; Thu, 16 Mar 2023 12:48:28 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 781EB40A89 for ; Thu, 16 Mar 2023 12:48:27 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id f6-20020a17090ac28600b0023b9bf9eb63so1298441pjt.5 for ; Thu, 16 Mar 2023 04:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1678967306; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FJuLmI0LYcWkfB12Yr14E2sVVlWX1783KGdiNVpklhU=; b=bMYFQPBNfDWQ3zz4Y+gNoFw4d8wX6mdVwNdVSmCQycaH21AtBOsG91qXWP/F0L8CaE 48rnoJIW+5/Gd1MeqdJ1TaUnH9q8cJvINL8tJ3fi6Xmlq85XTB6f4nLjoXFocahryxy1 zlnp/c3S2sO0KoQMSpk+Ms2gSdhPPpNNCFJ1Z8b0SVo4TgqcqvN7eyJHBn8eOBFrwm/4 ixV2PiPp0xRN89ti/FefFwqZK8d0Uf/uKl6g7WLf2bffoiNWqkVHVYtdYtEpEz7EnCGI c4yKo2pINVxyAs1RraViVnzYmySkvDxjy1yEam8HqD16HOd6sECAIEznCP39uk7nrdsg uRFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678967306; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FJuLmI0LYcWkfB12Yr14E2sVVlWX1783KGdiNVpklhU=; b=A04WuAXIO6o5FdUeenRiXkhfl4afnW67g2GxTN6KVhqkBPdpQoKTxwI1sVf2dQZh6j hxADlEesTaaYEGppv24GI7Mr6HxUtuLQwV2stACVwHydl/hJPQZimxeFJtSu1Td6pMpY sz9nc9X0bdY3zeun04vRvfMzCu1gnVcQ8ytCfukZx8ZJBoOHQhsYL8+8O0aYgW2Dxn2W xdQN5dvM2rIK2ikthXqGjVj90SJ64kNZta8vaWXLHzmii/DjFzo/H16bK2bD8ClKaW9f 0d3h1ql0/2yj0RiP5jwrzkYxXwRNY/NIDL1A250tHGbQtayu+wiCCiBYINCVTqTpw3M3 oB7w== X-Gm-Message-State: AO0yUKWfBzEDvEH6L2UvBmgW1ufeiLsYixq8J6ramU8hquJ94uTMv9pb YzTjPHcMZuLEUiYudI/PsnH6c63qUE9ja3urqKY= X-Google-Smtp-Source: AK7set9+oayYQUOr5mJqKJEHqUtYzAoWDLsxgex2Ij6OQxfK5Lyx1GgbQ0TAdhK0xibzeN+K8Xn/bA== X-Received: by 2002:a17:902:868b:b0:199:3f82:ef62 with SMTP id g11-20020a170902868b00b001993f82ef62mr3155816plo.5.1678967306692; Thu, 16 Mar 2023 04:48:26 -0700 (PDT) Received: from HTW5T2C6VL.bytedance.net ([139.177.225.240]) by smtp.gmail.com with ESMTPSA id jg17-20020a17090326d100b0019aeddce6casm2662070plb.205.2023.03.16.04.48.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Mar 2023 04:48:26 -0700 (PDT) From: Fengnan Chang To: ktraynor@redhat.com Cc: dev@dpdk.org, Fengnan Chang Subject: [PATCH 21.11] eal: cleanup alarm and hotplug before memory detach Date: Thu, 16 Mar 2023 19:48:18 +0800 Message-Id: <20230316114818.99552-1-changfengnan@bytedance.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Alarm and multiprocess hotplug still need access hugepage memory, if alarm event processed after memory detach, it may cause SEGV. So cleanup alarm and multiprocess hotplug before memory detach. Signed-off-by: Fengnan Chang --- lib/eal/freebsd/eal.c | 2 +- lib/eal/linux/eal.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 414aad3dd3..717d1f0b9a 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -988,9 +988,9 @@ rte_eal_cleanup(void) rte_mp_channel_cleanup(); rte_trace_save(); eal_trace_fini(); + rte_eal_alarm_cleanup(); /* after this point, any DPDK pointers will become dangling */ rte_eal_memory_detach(); - rte_eal_alarm_cleanup(); eal_cleanup_config(internal_conf); return 0; } diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index e3d34f7b7c..84c42679bf 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -1370,9 +1370,9 @@ rte_eal_cleanup(void) rte_mp_channel_cleanup(); rte_trace_save(); eal_trace_fini(); + rte_eal_alarm_cleanup(); /* after this point, any DPDK pointers will become dangling */ rte_eal_memory_detach(); - rte_eal_alarm_cleanup(); eal_cleanup_config(internal_conf); return 0; } -- 2.37.1 (Apple Git-137.1)