From: Srikanth Yalavarthi <syalavarthi@marvell.com>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>,
Prince Takkar <ptakkar@marvell.com>
Cc: <dev@dpdk.org>, <sshankarnara@marvell.com>, <aprabhu@marvell.com>,
<pshukla@marvell.com>
Subject: [PATCH v3 7/8] ml/cnxk: avoid variable name reuse in a function
Date: Thu, 16 Mar 2023 14:29:03 -0700 [thread overview]
Message-ID: <20230316212904.9318-8-syalavarthi@marvell.com> (raw)
In-Reply-To: <20230316212904.9318-1-syalavarthi@marvell.com>
Avoid reusing variable name in different scopes with in same
function. Move variable declarations to beginning of function.
Fixes: b7d0650ebce0 ("ml/cnxk: reserve and free OCM pages")
Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
drivers/ml/cnxk/cn10k_ml_ocm.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/ml/cnxk/cn10k_ml_ocm.c b/drivers/ml/cnxk/cn10k_ml_ocm.c
index 2367f40a1d..93505c9c09 100644
--- a/drivers/ml/cnxk/cn10k_ml_ocm.c
+++ b/drivers/ml/cnxk/cn10k_ml_ocm.c
@@ -390,6 +390,7 @@ cn10k_ml_ocm_reserve_pages(struct rte_ml_dev *dev, uint16_t model_id, uint64_t t
void
cn10k_ml_ocm_free_pages(struct rte_ml_dev *dev, uint16_t model_id)
{
+ struct cn10k_ml_model *local_model;
struct cn10k_ml_model *model;
struct cn10k_ml_dev *mldev;
struct cn10k_ml_ocm *ocm;
@@ -420,17 +421,15 @@ cn10k_ml_ocm_free_pages(struct rte_ml_dev *dev, uint16_t model_id)
if (wb_page_end == ocm->tile_ocm_info[tile_id].last_wb_page)
ocm->tile_ocm_info[tile_id].last_wb_page = wb_page_start - 1;
- /* Update scratch page size and clear extra bits */
- scratch_resize_pages = 0;
/* Get max scratch pages required, excluding the current model */
+ scratch_resize_pages = 0;
for (i = 0; i < dev->data->nb_models; i++) {
- struct cn10k_ml_model *model = dev->data->models[i];
-
- if ((i != model_id) && (model != NULL)) {
- if (IS_BIT_SET(model->model_mem_map.tilemask, tile_id))
- scratch_resize_pages =
- PLT_MAX((int)model->model_mem_map.scratch_pages,
- scratch_resize_pages);
+ local_model = dev->data->models[i];
+ if ((i != model_id) && (local_model != NULL)) {
+ if (IS_BIT_SET(local_model->model_mem_map.tilemask, tile_id))
+ scratch_resize_pages = PLT_MAX(
+ (int)local_model->model_mem_map.scratch_pages,
+ scratch_resize_pages);
}
}
--
2.17.1
next prev parent reply other threads:[~2023-03-16 21:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 13:54 [PATCH 1/1] ml/cnxk: fix multiple coverity issues Srikanth Yalavarthi
2023-03-16 9:33 ` [PATCH v2 " Srikanth Yalavarthi
2023-03-16 17:00 ` Thomas Monjalon
2023-03-16 17:02 ` [EXT] " Srikanth Yalavarthi
2023-03-16 17:07 ` Thomas Monjalon
2023-03-16 21:28 ` [PATCH v3 0/8] Fixes to ml/cnxk driver Srikanth Yalavarthi
2023-03-16 21:28 ` [PATCH v3 1/8] ml/cnxk: fix evaluation order violation issues Srikanth Yalavarthi
2023-03-16 21:28 ` [PATCH v3 2/8] ml/cnxk: fix potential division by zero Srikanth Yalavarthi
2023-03-16 21:28 ` [PATCH v3 3/8] ml/cnxk: add pointer check after memory allocation Srikanth Yalavarthi
2023-03-16 21:29 ` [PATCH v3 4/8] ml/cnxk: remove logically dead code Srikanth Yalavarthi
2023-03-16 21:29 ` [PATCH v3 5/8] ml/cnxk: fix potential memory leak in xstats Srikanth Yalavarthi
2023-03-16 21:29 ` [PATCH v3 6/8] ml/cnxk: check for null pointer before dereference Srikanth Yalavarthi
2023-03-16 21:29 ` Srikanth Yalavarthi [this message]
2023-03-16 21:29 ` [PATCH v3 8/8] ml/cnxk: reduce levels of nested variables access Srikanth Yalavarthi
2023-03-19 19:01 ` [PATCH v3 0/8] Fixes to ml/cnxk driver Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316212904.9318-8-syalavarthi@marvell.com \
--to=syalavarthi@marvell.com \
--cc=aprabhu@marvell.com \
--cc=dev@dpdk.org \
--cc=pshukla@marvell.com \
--cc=ptakkar@marvell.com \
--cc=sshankarnara@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).