From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38FF5427E0; Mon, 20 Mar 2023 10:31:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 548A442F9C; Mon, 20 Mar 2023 10:28:55 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 3896542D3C for ; Mon, 20 Mar 2023 10:28:15 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Pg8X30yPvzrVPW; Mon, 20 Mar 2023 17:27:15 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 17:28:14 +0800 From: Chengwen Feng To: , , Timothy McDaniel , Abdullah Sevincer CC: Subject: [PATCH v2 38/44] event/dlb2: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:21:04 +0000 Message-ID: <20230320092110.37295-39-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys'. Fixes: 8d1d9070bbe9 ("event/dlb2: optimize producer port probing") Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- drivers/event/dlb2/dlb2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 60c5cd4804..d436cf852a 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -329,6 +329,9 @@ set_numa_node(const char *key __rte_unused, const char *value, void *opaque) int *socket_id = opaque; int ret; + if (value == NULL) + return -EINVAL; + ret = dlb2_string_to_int(socket_id, value); if (ret < 0) return ret; @@ -542,7 +545,7 @@ set_cos_bw(const char *key __rte_unused, { struct dlb2_cos_bw *cos_bw = opaque; - if (opaque == NULL) { + if (value == NULL || opaque == NULL) { DLB2_LOG_ERR("NULL pointer\n"); return -EINVAL; } -- 2.17.1