From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85634427E0; Mon, 20 Mar 2023 10:31:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41E0942FAE; Mon, 20 Mar 2023 10:28:59 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id E894842D42 for ; Mon, 20 Mar 2023 10:28:15 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Pg8Tg1DyLz17MVP; Mon, 20 Mar 2023 17:25:11 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 17:28:14 +0800 From: Chengwen Feng To: , , Liang Ma , Peter Mccarthy CC: Subject: [PATCH v2 41/44] event/opdl: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:21:07 +0000 Message-ID: <20230320092110.37295-42-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys'. Fixes: 3c7f3dcfb099 ("event/opdl: add PMD main body and helper function") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- drivers/event/opdl/opdl_evdev.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 9ce8b39b60..f90d31aa19 100644 --- a/drivers/event/opdl/opdl_evdev.c +++ b/drivers/event/opdl/opdl_evdev.c @@ -580,6 +580,8 @@ static int assign_numa_node(const char *key __rte_unused, const char *value, void *opaque) { int *socket_id = opaque; + if (value == NULL) + return -EINVAL; *socket_id = atoi(value); if (*socket_id >= RTE_MAX_NUMA_NODES) return -1; @@ -590,6 +592,10 @@ static int set_do_validation(const char *key __rte_unused, const char *value, void *opaque) { int *do_val = opaque; + + if (value == NULL) + return -EINVAL; + *do_val = atoi(value); if (*do_val != 0) *do_val = 1; @@ -601,6 +607,9 @@ set_do_test(const char *key __rte_unused, const char *value, void *opaque) { int *do_test = opaque; + if (value == NULL) + return -EINVAL; + *do_test = atoi(value); if (*do_test != 0) -- 2.17.1