From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DCBE4280A; Wed, 22 Mar 2023 15:44:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0DDA4282D; Wed, 22 Mar 2023 15:44:43 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2081.outbound.protection.outlook.com [40.107.223.81]) by mails.dpdk.org (Postfix) with ESMTP id 8BD1940A84; Wed, 22 Mar 2023 15:44:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RNu5vkzkWP46AA2Fc7TJo+gzcArI5ZnMmYNDvybVEVE/PMi4oyVuZl7l9gtRb9+NpLUmTUQUAQ5LNDeuvSkHR0fuB6NlMRLbBDtcGYcO4v7X7FCNLqCpnq/uZz8b0MVs8/qA+gD9UXOndjkOeACq8FrGU4HkJpTm8RCRgZURIRRQZFJatBUU8vQZlkL/bhxbgA2+EtUVsa/h/HBr8+60X2t4UuPzI4LtaEDSvbXws3VzfxktnrQTG0XpPsxgXkDjA1P1e2HWO0sD+6nX+Pyb9i/wg6q9MAt75iwL7doFrhc1zRWJtIaPq/ArtZiMMzWmrstpGUWNENMcJ/EydgbDXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZO6UiC598p1s+vjipSI0Bp7QxIBb8KtgAaHarXeH6Qs=; b=RZMEgWm0B/fsTpSyeHJDxcfiVyipAIXDe1JyxVBOvUTkKeExV5sP+bke3xpQzVmLvuvZvJMs1KuZLdZMLy/pSadj9k+XUlTNApyXzkI08ECp0gyouWiXm1yUwZuxUvNNpBbKWZ9m13AyqjybKq8ec/QHIFi+jBwAcE8DaDgWdd0y+Ga7Iw82nY1ke1R6mRbuHk1D5u45yduD/t1VOprDEcYR3YX4Y8bpg+EmAhTsVcKU5CaCGYLJ26DB2wg4upgPXnh+ruQR3IQqmDbLsnnsaHpq7Rj60D82T3at2qvdvVPdraRBE+3UHdeJ6OQdkebPWgGN4Xjkhp4e+PIjUp0GvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZO6UiC598p1s+vjipSI0Bp7QxIBb8KtgAaHarXeH6Qs=; b=DIeqdux5zWHKuKo9RmpGcdevaGRbMexxduDUTwcPvx7gnvyD2oKUVxqWgQv87TFS1EhvbwLS8uIegtmQnYX+QSwD6t4j9jPuAlMwFuqG2TlrpQdZb+FhQRkhislv7V0QZOSVGWpL6n5F7PFSuIv6j8hgO1o3PlHML+mZe34I/EFLxxTcvDAh85LR0hlxKqoUe83uybHKdzCSnECQxW0KGQ14kajZK/VoBWKkBJJ3Xay+vR3rtwAcLbBCX1a0a5fAayA5dnzbXAa0TCZdk1TBeCpBQAHIAr1dHq9p7TFJFa28Xacc1vYadfdEq8CrD2LfArWJzXGjQ8SqdbykhIRiig== Received: from CY5PR03CA0033.namprd03.prod.outlook.com (2603:10b6:930:8::15) by CH0PR12MB5187.namprd12.prod.outlook.com (2603:10b6:610:ba::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 14:44:41 +0000 Received: from CY4PEPF0000C980.namprd02.prod.outlook.com (2603:10b6:930:8:cafe::7b) by CY5PR03CA0033.outlook.office365.com (2603:10b6:930:8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Wed, 22 Mar 2023 14:44:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000C980.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.30 via Frontend Transport; Wed, 22 Mar 2023 14:44:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 22 Mar 2023 07:44:28 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 22 Mar 2023 07:44:26 -0700 From: Erez Shitrit To: CC: , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH v4] net/mlx5/hws: fix saving of jumbo tag for deletion Date: Wed, 22 Mar 2023 16:44:13 +0200 Message-ID: <20230322144413.656047-1-erezsh@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20230322101621.642765-3-erezsh@nvidia.com> References: <20230322101621.642765-3-erezsh@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C980:EE_|CH0PR12MB5187:EE_ X-MS-Office365-Filtering-Correlation-Id: d88039af-988f-447a-6ed2-08db2ae3f7d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wb6LIvzOabk7zwdpJuUhlMS72dXeUuFIatB3UOyD3+uu9KQLl3mWpalZIZjgotEcfTXZg6/u6I/EcRdmowdBHR8hKAjEJiVvHnzbQID4aQ40ogzWR8AaqosNi2eUFmiQnhFJae6VYH3Sx4IjGEBG8K71+B5Jmxk8Uas5d7QXkkHT41aeBRZr7pHheS8Nu0dsi7bb+WMVYF/wS45MwPDE3gcbqSXKT5TgWdIJC3hzyfDEjSLGrnAAqvThJWm3bnRCB6rVFMfCsA/oCKQv8xxkG0u3P8HrBOHVNMt84Hk6DjIDUdFup95boKOgChirYK0noLTjEyKFV3S3lJ9yw/YNHwudmqgMhVGlRsa0BXRTQ3iSkUWPdkaf33p1pSu+Bl8cJKIPlsDse+a/3lSUYS7d5MqxK8xDNBR10Ala1vfEktGTUCvj34Mzr3meeHNkE58F23cBVU5R75hq9SMB34jAHhpe2tMmE6w7TA2MiT5vmaIq1Zc9Mf9XhYNwbDwSApYwJi9r5HCYSesEOG6Q1losgypESlkC/kssyXTpGpe1e3QOD3YNX9XSS5eapbxdLHwJUS62XVsaJHAI5knZVC4d9ltA8ouJiQmMq0BWhNTrtFYNAQOMP3qddNJ0/xMZa4+UOhcUKpDZ7HZFFsD7hZh2Py6qoz/wF+a/es3SoH5P8OQ5QAPoayozvJofWKKxB4XBlC3uZIt+CSZxF9WNB/KNcgYp5ANNlkOx3ovcOMWQbHnePxZqLw2JJXtrYt1ALipM X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199018)(36840700001)(46966006)(40470700004)(2616005)(1076003)(336012)(16526019)(47076005)(26005)(186003)(6286002)(6666004)(426003)(8676002)(70586007)(316002)(478600001)(4326008)(83380400001)(450100002)(107886003)(6916009)(54906003)(70206006)(36860700001)(41300700001)(82740400003)(8936002)(2906002)(7636003)(5660300002)(356005)(82310400005)(7696005)(86362001)(55016003)(36756003)(40480700001)(40460700003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 14:44:40.5331 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d88039af-988f-447a-6ed2-08db2ae3f7d4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C980.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5187 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In cases with more than one STE we didn't update the whole tag of the match jumbo STE, Instead of 11B we kept only 8B like in regular STE. The ste_attr that keeps that indication was not updated at the last iteration. Now we indicate it is a jumbo frame before saving the tag for future deletion of it. Fixes: 405242c52dd5 ("net/mlx5/hws: add rule object") Cc: stable@dpdk.org Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 9d5e5b11a5..2418ca0b26 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -116,6 +116,9 @@ static void mlx5dr_rule_save_delete_info(struct mlx5dr_rule *rule, struct mlx5dr_send_ste_attr *ste_attr) { + struct mlx5dr_match_template *mt = rule->matcher->mt; + bool is_jumbo = mlx5dr_matcher_mt_is_jumbo(mt); + if (unlikely(mlx5dr_matcher_req_fw_wqe(rule->matcher))) { uint8_t *src_tag; @@ -136,7 +139,7 @@ mlx5dr_rule_save_delete_info(struct mlx5dr_rule *rule, return; } - if (ste_attr->wqe_tag_is_jumbo) + if (is_jumbo) memcpy(rule->tag.jumbo, ste_attr->wqe_data->jumbo, MLX5DR_JUMBO_TAG_SZ); else memcpy(rule->tag.match, ste_attr->wqe_data->tag, MLX5DR_MATCH_TAG_SZ); -- 2.18.2