From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1703F42868; Thu, 30 Mar 2023 01:31:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8908540E5A; Thu, 30 Mar 2023 01:31:05 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 854CC40685 for ; Thu, 30 Mar 2023 01:31:03 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id lr16-20020a17090b4b9000b0023f187954acso17853566pjb.2 for ; Wed, 29 Mar 2023 16:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1680132662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=d8FPvqKm8F91j0X6KzNNvW9j+4oIUG1MEDZvu3mx9rE=; b=RDWYt8lgXNcTQwOhXD1w9uqBPD1v19zTjYohBYWqGBGgCjE26421vHAKs9KNMEQAn6 RkM8ic/Np/w+rnxSMqhFzHJPcSgn0scuCoNq5jp6BqyM0grTqC1UUlAl6+6txotcltWS s2ht4ex89eINNWA1uVabyxPmAexXIEH8Y+5snhqHIXr5+UmN+A2DukH+oFb2OWrYshrI rVo8gxUoTWX/d/nJdPNp7Sh0ipTnNY0DSKdMc/y2+ccy/TMn5YjwSPX11qo2Uq03rtcW SNB4daGAsQBrBhqpL9BSh6u6iXAUjNTHoGVMlyNzI8zyHdgg93KMIoz3qpnZBSX5Dl1k xRFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680132662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d8FPvqKm8F91j0X6KzNNvW9j+4oIUG1MEDZvu3mx9rE=; b=SsZ1fRvEVfqEA2cib3MF7h9isRPRIRHyLxU8WkrsMvnVUSfI15AVujmmc/MO26zUDv CW8JJknylkd5qPorm0oym+5Oq9WbUdMB0HmZW0uKe78ueVms+LXTXJmFQ9dVyLciLk+C WINYEL3Z9lJ/e7fUOCu3HGF9p4ZunDTMal/Lahj8UPEtMR5+G5YvZOFQzl7fHNZh9TYu KuOWEkDNJnTun6kUMW3Y0/BkSc2vcJks4SpZQX/4yxayjKy8XA/G1zFPADP0U8Tx2W4o R8l8qmWb9/12wQUjecVEwiXMCBDLasEwyG44J2smVTKGabFhqhANsb8WoiDjzP1jbciT 0o9g== X-Gm-Message-State: AO0yUKWHC1fNrzN7LdqqGJTkdda6T95YLaF+ZxV0/a4mGa2LPYTcxIHN 2Nu5Kwad9l5iB2KSk8UesqDUjA== X-Google-Smtp-Source: AK7set8o2/5ENKGa8Eq3Dd4QroH3cbY44sX11r+/JHAxoVMvOeqQMVkEGAviUqXX1wIH2gdeQR+t7A== X-Received: by 2002:a05:6a20:671f:b0:d8:f312:b3b with SMTP id q31-20020a056a20671f00b000d8f3120b3bmr17636334pzh.3.1680132662260; Wed, 29 Mar 2023 16:31:02 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id g5-20020aa78745000000b006262932a30csm23280850pfo.34.2023.03.29.16.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 16:31:01 -0700 (PDT) Date: Wed, 29 Mar 2023 16:31:00 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH v8 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type Message-ID: <20230329163100.3e6f5de6@hermes.local> In-Reply-To: References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230220233556.168553-1-stephen@networkplumber.org> <20230220233556.168553-5-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 Feb 2023 15:55:29 +0100 David Marchand wrote: > On Tue, Feb 21, 2023 at 12:36 AM Stephen Hemminger > wrote: > > > > Replace all uses of the global logtype with a dynamic log type. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/eal/common/eal_common_log.c | 1 - > > lib/eal/include/rte_log.h | 2 +- > > lib/efd/rte_efd.c | 4 ++++ > > 3 files changed, 5 insertions(+), 2 deletions(-) > > [snip] > > > diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c > > index 686a13775742..9edb11799c89 100644 > > --- a/lib/efd/rte_efd.c > > +++ b/lib/efd/rte_efd.c > > @@ -9,6 +9,7 @@ > > #include > > #include > > > > +#include > > #include > > #include > > #include > > This is unrelated, isn't it? Not really, previously the hash library would cause cpuflags to be included. But that doesn't happen now that the hash function is not inline there.