From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C0CD428D6; Thu, 6 Apr 2023 04:25:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC18840F18; Thu, 6 Apr 2023 04:25:50 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id F33C740DF6 for ; Thu, 6 Apr 2023 04:25:48 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id r7-20020a17090b050700b002404be7920aso37467314pjz.5 for ; Wed, 05 Apr 2023 19:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1680747947; x=1683339947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DHRTRJQo5trizTalT1jZawU99OtChFAtYT7FxIfVBc0=; b=WEAcbCcGF39XBINc8eVxZOz+KNv0NvA3TVLpSMV6ywHMXTkFBdM7L7DBr6/FqpVHag PFHv5GEqypXSEmuS/mFBcuXVU4tn95EjnSWqEUhugOxLjiAGGkCn25VBRLnNNJJOhH3+ +jl8N3Y8BHDbmMnvEDZNUCKRZ7ldri2fnHy0iku5QKDTAXXkqlAzmZmOdIyWTd/rMgpM 8WhCInx0h/04mBxIu6DXvPCAd9ytYOOvxFXQ6nyGmsf2XqRW+xF+nN6EZdXGCXu2jagT rmUxTQKPD8SDQfmjFOur6dQ0212tTtxnPF+0kNFbFbGzSVbP85pGLOyExBHJFANikM7b A7Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680747947; x=1683339947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DHRTRJQo5trizTalT1jZawU99OtChFAtYT7FxIfVBc0=; b=jSU0dQU6hxVXpTFFS4YzSH7Ui/P1zE0t57SjZofYlVt7VITpnEGWQdd8StJmXCR99H +bKNC/6/KMmr8tLXoPfHNAJGbmyI/6BIROEQDPCtx89wBCbnmXmt4WHxsgkGx4QTlika zC58lZtjD/oXcFrOmpew6iUvRq8OUY9Gjk2g6h0K6ji2/PxeCDAp/AviMmwBzLLghXjy n0LNl9YAQOOwDmyAaJgAtVCufXzn6VUuttbfVhCi0ygBoPbPsFEybWoyXk/HvkOPPkx+ Eom1fen0mIv6WjknZigVSMT1m02L/PUcYMAuAwB9WIR7CWMxFLGBFS4kHHnRcpcD2Ea1 I3dg== X-Gm-Message-State: AAQBX9eDAGGAVIhiDYk6Kzv4RV+Ah3atZ7JO7z5Na+HmS4hCsN32hL+U vPU4M76yOlkIvPg0jvIQW/b97Q== X-Google-Smtp-Source: AKy350bgthWAFivsTWpyUsPGKS2wbMasZGg411LgbkGmXp5ZZL79EIZ3r7T/vSSt1vphkpfozFchUg== X-Received: by 2002:a05:6a20:6055:b0:e4:a0b7:9053 with SMTP id s21-20020a056a20605500b000e4a0b79053mr1277675pza.28.1680747947347; Wed, 05 Apr 2023 19:25:47 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id b17-20020aa78111000000b005825b8e0540sm59038pfi.204.2023.04.05.19.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 19:25:47 -0700 (PDT) Date: Wed, 5 Apr 2023 19:25:45 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com, thomas@monjalon.net, mb@smartsharesystems.com, konstantin.ananyev@huawei.com Subject: Re: [PATCH v3 08/11] eal: expand most macros to empty when using msvc Message-ID: <20230405192545.5fb2cd33@hermes.local> In-Reply-To: <1680741919-22102-9-git-send-email-roretzla@linux.microsoft.com> References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> <1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com> <1680741919-22102-9-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 5 Apr 2023 17:45:16 -0700 Tyler Retzlaff wrote: > For now expand a lot of common rte macros empty. The catch here is we > need to test that most of the macros do what they should but at the same > time they are blocking work needed to bootstrap of the unit tests. > > Later we will return and provide (where possible) expansions that work > correctly for msvc and where not possible provide some alternate macros > to achieve the same outcome. > > Signed-off-by: Tyler Retzlaff Ok, but doesn't SAL have definitions for most of these?