From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48E57428B5; Thu, 6 Apr 2023 08:44:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CBA242BB1; Thu, 6 Apr 2023 08:44:05 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 3CC2940DF6 for ; Thu, 6 Apr 2023 08:44:03 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 55487210DEFC; Wed, 5 Apr 2023 23:44:02 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 55487210DEFC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1680763442; bh=dvC3wxId/1Ix2KD0n+/kDvmH5RHH4Nc8ERWZ1+Qgn/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T2kkW9TCGN1EFQ5V7J3KnLR7MQ4DJhzEmm2ssY+y+UuNg2E2G8tWtnHE+ZOUCqQ89 17jQpJb6EL+lTcLZBd3/EUaRHA2tinkU4YS10Jgcjdi0B6AdZayvgmbE0RJSLjLYph 8KrrYKeygqcscNSOmgsoiOOaOQvEoRx0ET90TQ/w= Date: Wed, 5 Apr 2023 23:44:02 -0700 From: Tyler Retzlaff To: Stephen Hemminger Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com, thomas@monjalon.net, mb@smartsharesystems.com, konstantin.ananyev@huawei.com Subject: Re: [PATCH v3 08/11] eal: expand most macros to empty when using msvc Message-ID: <20230406064402.GA20529@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> <1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com> <1680741919-22102-9-git-send-email-roretzla@linux.microsoft.com> <20230405192545.5fb2cd33@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230405192545.5fb2cd33@hermes.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 05, 2023 at 07:25:45PM -0700, Stephen Hemminger wrote: > On Wed, 5 Apr 2023 17:45:16 -0700 > Tyler Retzlaff wrote: > > > For now expand a lot of common rte macros empty. The catch here is we > > need to test that most of the macros do what they should but at the same > > time they are blocking work needed to bootstrap of the unit tests. > > > > Later we will return and provide (where possible) expansions that work > > correctly for msvc and where not possible provide some alternate macros > > to achieve the same outcome. > > > > Signed-off-by: Tyler Retzlaff > > Ok, but doesn't SAL have definitions for most of these? SAL could be used too, but i was considering that more as an integration with David's recent clang annotation additions. SAL is a broader topic since to be useful it would need to leverage tooling. depending on the macros some will come from existing msvc e.g. __declspec some will come from standard C e.g. _Noreturn many may not be critical for correct behavior but when used can decrease misuse or increase performance through better codegen. once we have things functioning correctly there will naturally be improvements in both areas that follow.